Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Does diamond graphs configure() methods that remove options shared/fpic could be broken? #8375

Closed
memsharded opened this issue Jan 21, 2021 · 4 comments
Assignees
Milestone

Comments

@memsharded
Copy link
Member

It is possible if evaluated more than once, with different branches values.

@memsharded memsharded added this to the 1.34 milestone Jan 21, 2021
@SSE4 SSE4 mentioned this issue Jan 22, 2021
5 tasks
@SSE4
Copy link
Contributor

SSE4 commented Jan 22, 2021

I spotted a serious issue in validate implementation: #8383

@memsharded
Copy link
Member Author

This is not an issue at all in the validate(), it is working as expected. It is an issue in the options processing: #8383 (review)

@memsharded memsharded self-assigned this Jan 28, 2021
@memsharded memsharded modified the milestones: 1.34, 1.35 Feb 24, 2021
@memsharded memsharded modified the milestones: 1.35, 1.36 Mar 29, 2021
@memsharded memsharded modified the milestones: 1.36, 2.0 Apr 20, 2021
@memsharded
Copy link
Member Author

The new graph resolution model in Conan 2.0 will try not to re-evaluate same recipe when diamonds, just check consistency. So that might solve this issue, which is otherwise simply too risky to solve for Conan 1.X

@memsharded
Copy link
Member Author

Solved in 2.0, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants