[feat] Send HTTP GET header with settings when looking for a 'package_reference' #8046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
approved these changes
Nov 13, 2020
| @@ -107,9 +110,9 @@ def _evaluate_remote_pkg(self, node, pref, remote, remotes): | |||
| # If the "remote" came from the registry but the user didn't specified the -r, with | |||
| # revisions iterate all remotes | |||
| if not remote or (not remote_info and self._cache.config.revisions_enabled): | |||
| for r in remotes.values(): | |||
| for r in remotes.values(): # FIXME: Here we hit the same remote we did before | |||
czoido
approved these changes
Nov 13, 2020
memsharded
approved these changes
Nov 13, 2020
|
I've tried a local Artifactory in docker, my Bintray account, and a cloud Artifactory (staging environment for ConanCenter). |
4 tasks
redradist
pushed a commit
to redradist/conan
that referenced
this pull request
Sep 12, 2021
…_reference' (conan-io#8046) * pass settings to the remote_manager * basic implementation * add tests * add comments * call function from test requires argument * add parameter to None * list options too in headers too * handle info variable with care * get the value from the one assigned by the test environment * add default argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Add headers with settings and options to HTTP GET requests when searching for packages.
Docs: Omit
closes #7870
Conan sends a request header
Conan-PkgID-Settingswhen looking for aprefin the remotes:if using revisions, it is sent when looking for the latest package revision, URL like:
if not using revisions, it is in the downloads_url:
These are the headers, do we want this information in a single header? do we want to use different names?
#REVISIONS: 1