Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Identify configuration in remote requests when querying for a packageID #7870

Closed
jgsogo opened this issue Oct 13, 2020 · 2 comments · Fixed by #8046
Closed

[feature] Identify configuration in remote requests when querying for a packageID #7870

jgsogo opened this issue Oct 13, 2020 · 2 comments · Fixed by #8046

Comments

@jgsogo
Copy link
Contributor

jgsogo commented Oct 13, 2020

When Conan checks if a package for a given configuration is available in a remote, it sends just the package ID. It would be very useful to send the information used to compute that hash:

  • We can send all the configuration: package ID computation is reproducible (needed? desired?)
  • We can send only the information taken into account to compute the package ID (~conaninfo.txt)
@jgsogo
Copy link
Contributor Author

jgsogo commented Nov 10, 2020

I've been having a look at it and it can be very challenging to pass the information about the configuration to the place where the calls to the remote are being done. I would say we need first to store the actual configuration for a package (settings, options, requirements,...) in the node object to have it available here

remote_info, pref = self._remote_manager.get_package_info(pref, remote)

Then we can deal with whatever is needed on the RemoteManager side.

@memsharded
Copy link
Member

I've been having a look at it and it can be very challenging to pass the information about the configuration to the place where the calls to the remote are being done. I would say we need first to store the actual configuration for a package (settings, options, requirements,...) in the node object to have it available here

That would be accessible in node.conanfile.info object at that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants