Fix upload return codes

conans/client/rest/uploader_downloader.py

@@ -28,6 +28,9 @@ def upload(self, url, abs_path, auth=None, dedup=False, retry=1, retry_wait=0, h
                 dedup_headers.update(headers)
             response = self.requester.put(url, data="", verify=self.verify, headers=dedup_headers,
                                           auth=auth)
+            if response.status_code == 401:
+                raise AuthenticationException(response.content)
+
             if response.status_code == 403:
                 if auth.token is None:
                     raise AuthenticationException(response.content)
@@ -53,6 +56,9 @@ def _upload_file(self, url, data,  headers, auth):
         try:
             response = self.requester.put(url, data=data, verify=self.verify,
                                           headers=headers, auth=auth)
+            if response.status_code == 401:
+                raise AuthenticationException(response.content)
+
             if response.status_code == 403:
                 if auth.token is None:
                     raise AuthenticationException(response.content)

conans/test/unittests/client/rest/uploader_test.py

@@ -0,0 +1,57 @@
+import tempfile
+import unittest
+from collections import namedtuple
+
+import six
+
+from conans.client.rest.uploader_downloader import Uploader
+from conans.errors import AuthenticationException, ForbiddenException
+from conans.test.utils.tools import TestBufferConanOutput
+from conans.util.files import save
+
+
+class UploaderUnitTest(unittest.TestCase):
+
+    def test_401_raises_unauthoirzed_exception(self):
+
+        class MockRequester(object):
+
+            def put(self, *args, **kwargs):
+                return namedtuple("response", "status_code content")(401, "tururu")
+
+        out = TestBufferConanOutput()
+        uploader = Uploader(MockRequester(), out, verify=False)
+        f = tempfile.mktemp()
+        save(f, "some contents")
+        with six.assertRaisesRegex(self, AuthenticationException, "tururu"):
+            uploader.upload("fake_url", f)
+
+    def test_403_raises_unauthoirzed_exception_if_no_token(self):
+
+        class MockRequester(object):
+
+            def put(self, *args, **kwargs):
+                return namedtuple("response", "status_code content")(403, "tururu")
+
+        out = TestBufferConanOutput()
+        auth = namedtuple("auth", "token")(None)
+        uploader = Uploader(MockRequester(), out, verify=False)
+        f = tempfile.mktemp()
+        save(f, "some contents")
+        with six.assertRaisesRegex(self, AuthenticationException, "tururu"):
+            uploader.upload("fake_url", f, auth=auth)
+
+    def test_403_raises_forbidden_exception_if_token(self):
+
+        class MockRequester(object):
+
+            def put(self, *args, **kwargs):
+                return namedtuple("response", "status_code content")(403, "tururu")
+
+        out = TestBufferConanOutput()
+        auth = namedtuple("auth", "token")("SOMETOKEN")
+        uploader = Uploader(MockRequester(), out, verify=False)
+        f = tempfile.mktemp()
+        save(f, "some contents")
+        with six.assertRaisesRegex(self, ForbiddenException, "tururu"):
+            uploader.upload("fake_url", f, auth=auth)