Fix upload return codes #4857
Merged
Fix upload return codes #4857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
lasote
commented
Mar 28, 2019
| with six.assertRaisesRegex(self, AuthenticationException, "tururu"): | ||
| uploader.upload("fake_url", f) | ||
|
|
||
| def test_403_raises_unauthoirzed_exception_if_no_token(self): |
There was a problem hiding this comment.
this manages the (my point of view) weird artifactory behavior while uploading
lasote
commented
Mar 28, 2019
|
|
||
| class UploaderUnitTest(unittest.TestCase): | ||
|
|
||
| def test_401_raises_unauthoirzed_exception(self): |
There was a problem hiding this comment.
This test a regular behavior of a 401 returned when trying to upload (bintray)
lasote
commented
Mar 28, 2019
| with six.assertRaisesRegex(self, AuthenticationException, "tururu"): | ||
| uploader.upload("fake_url", f, auth=auth) | ||
|
|
||
| def test_403_raises_forbidden_exception_if_token(self): |
There was a problem hiding this comment.
This test a classic wrong token while uploading
memsharded
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Fixed authentication management when a server returns 401 uploading a file.
Docs: omit