msbuild temp props in build folder #4113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
lasote
changed the title
danimtb
previously approved these changes
Dec 12, 2018
|
maybe add a check in the existing tests to check file is generated in the build folder now using a custom |
danimtb
approved these changes
Dec 12, 2018
memsharded
approved these changes
Dec 12, 2018
| self.build_env.parallel = parallel | ||
|
|
||
| with tools.environment_append(self.build_env.vars): | ||
| # Path for custom properties file | ||
| props_file_contents = self._get_props_file_contents() | ||
| with tmp_file(props_file_contents) as props_file_path: |
There was a problem hiding this comment.
The tmp_file context manager is now dead code, please remove it.
…an into feature/msbuild_prop_in_build
grisumbras
pushed a commit
to grisumbras/conan
that referenced
this pull request
Dec 27, 2018
…build msbuild temp props in build folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: The property file that the
MSBuild()is now generated in thebuild_folderinstead of a temporary folder to allow more reproducible builds.Docs: conan-io/docs#980
Closes #4085
PENDING DOCS