Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in MSBuild helper properties injection #4471

Closed
Minimonium opened this issue Feb 5, 2019 · 4 comments
Closed

Regression in MSBuild helper properties injection #4471

Minimonium opened this issue Feb 5, 2019 · 4 comments
Assignees
@memsharded
Labels
complex: low priority: critical type: bug
Milestone
1.12.2

Comments

@Minimonium
Copy link
Contributor

Unfortunately, in #4113 we have missed the fact the ForceImportBeforeCppTargets parameter requires an absolute path to the properties files to be injected.
@Minimonium Minimonium mentioned this issue Feb 5, 2019
Closed
@memsharded
Copy link
Member

If this is a regression and it breaks badly MSBuild projects, it should be fixed in conan 1.12.2.

I have had a look, didn't understand why the test in https://github.com/conan-io/conan/pull/4113/files was not failing.

@Minimonium
Copy link
Contributor Author

@memsharded
Because it doesn't test the ForceImportBeforeCppTargets. Configuration and arch are handled by other MSBuild parameters. To make a correct test one should test a different Runtime.

@memsharded
Copy link
Member

This is true, this is a regression and will be fixed in Conan 1.12.2 asap.

@memsharded memsharded added this to the 1.12.2 milestone Feb 8, 2019
@memsharded memsharded mentioned this issue Feb 8, 2019
Merged
@memsharded
Copy link
Member

Released in Conan 1.12.2

@ghost ghost removed the stage: review label Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@memsharded memsharded

Labels
complex: low priority: critical type: bug
Projects
None yet
Milestone
1.12.2
Development

No branches or pull requests
3 participants
@lasote @memsharded @Minimonium