Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --allowed-packges to remotes to limit what references a remote can supply #15464

Merged
merged 8 commits into from
Jan 19, 2024

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Jan 17, 2024

Changelog: Feature: Add --allowed-packges to remotes to limit what references a remote can supply.
Docs: conan-io/docs#3534

@AbrilRBS AbrilRBS requested a review from memsharded January 17, 2024 10:25
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

conans/client/cache/remote_registry.py Outdated Show resolved Hide resolved
conans/client/graph/proxy.py Outdated Show resolved Hide resolved
@AbrilRBS AbrilRBS added this to the 2.1 milestone Jan 17, 2024
@AbrilRBS AbrilRBS changed the title Initial work for recipe filters per remote Add recipe filters to remotes to limit what references a remote can supply Jan 17, 2024
@memsharded memsharded requested a review from czoido January 17, 2024 18:36
Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, I think that --filter name is a bit confusing. It's being used in conan remote command, and it's filtering recipe references. I'd prefer to see another param name.

@AbrilRBS
Copy link
Member Author

Let's talk with the team about what the best naming is, yeah :)

@czoido
Copy link
Contributor

czoido commented Jan 18, 2024

Let's talk with the team about what the best naming is, yeah :)

I think the name suggest that the packages added with --filter will be filtered out, but those are the ones that you can fetch from the remote, so I thin it may be better to use a name that suggests those packages are the ones allowed in the server. Something like --allowed, --allowed-packages, --allowed-patterns ? or any derivatives

@AbrilRBS AbrilRBS changed the title Add recipe filters to remotes to limit what references a remote can supply Add --allowed-packges to remotes to limit what references a remote can supply Jan 19, 2024
@memsharded memsharded merged commit 8c21caf into conan-io:develop2 Jan 19, 2024
2 checks passed
@AbrilRBS AbrilRBS deleted the rr/filter-recipes-per-remote branch January 19, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants