Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor for RemotesAPI #15462

Merged
merged 9 commits into from
Jan 19, 2024
Merged

Refactor for RemotesAPI #15462

merged 9 commits into from
Jan 19, 2024

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jan 16, 2024 •
edited by czoido
Loading

Changelog: Feature: Initial documentation to make RemotesAPI publicly available (experimental).
Docs: Omit

I plan to docoument and publish in docs the RemotesAPI as the first "experimental" but released and documented sub API

Should probably be merged after #15464

@memsharded memsharded added this to the 2.1 milestone Jan 16, 2024
@memsharded memsharded requested a review from AbrilRBS January 16, 2024 17:43
AbrilRBS
AbrilRBS approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reaally nice. We still need to discuss how much we want to/if we want to specify types for the methods

conans/test/integration/command/remote_test.py Outdated Show resolved Hide resolved
@memsharded memsharded requested a review from czoido January 17, 2024 10:23
@memsharded memsharded mentioned this pull request Jan 17, 2024
Closed
@memsharded memsharded self-assigned this Jan 17, 2024
@memsharded memsharded merged commit fa991f3 into conan-io:develop2 Jan 19, 2024
2 checks passed
@memsharded memsharded deleted the refactor/remotes_api branch January 19, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@czoido czoido czoido approved these changes

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@memsharded @czoido @AbrilRBS