Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support clang-cl in default profile plugin #14682

Merged

Conversation

lukester1975
Copy link
Contributor

@lukester1975 lukester1975 commented Sep 6, 2023

Changelog: Feature: Support clang-cl in default profile plugin.
Docs: conan-io/docs#3387

This is a follow up to ##13424 (comment), item 2 this time.

It would be nice if cl and clang-cl were consistent wrt runtime_type, though since the profile can set the value explicitly, it's not the end of the world if you think this is a bad idea (as far as I've looked runtime would only be set with a cl-like compiler, so should be good?).

If it's viable:

Thanks

  • Refer to the issue that supports this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks!

Yes, this is viable, the change makes sense, and it has no risk, as runtime is an user input, they explicitly decide if it is clang with msvc runtime (both clang and clang-cl) or clang with gnu/msys2 backend

@memsharded memsharded added this to the 2.0.11 milestone Sep 6, 2023
@memsharded memsharded merged commit 89b1852 into conan-io:release/2.0 Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants