Feature/set meson b_vscrt with clang-cl #14664
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Ensure meson toolchain sets
b_vscrt
with clang-cl.Docs: Omit
This is a follow up to ##13424 (comment), specifically item 3.
if compiler in ("msvc", "clang")
is a bit ugly but as I mentioned in the issue, I couldn't see a way to see if the compiler is reallyclang-cl
at that point. Safe enough given themsvc_runtime_flag
implementation (note I changed it to returnNone
for all non-compiler.runtime
cases such that _b_vscrt is consistentlyNone
; all other usages seem OK with that).if compiler in ("msvc", "clang")
test could be removed. Intel's cl-like frontend?pytest.mark.tool
working, so they are commented out. I'm sure I'm just missing some magic incantation somewhere despite VS2022 being enable in my env.compiler.version={{ os.popen("clang-cl --version").read().removeprefix("clang version ").split(".")[0] }}
. I guess this could do something similar if necessary?develop
branch, documenting this one.