-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/pkg list #13928
Merged
Merged
Feature/pkg list #13928
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
618f9f1
pkglist
memsharded 36735fa
wip
memsharded 8a525ec
fix test
memsharded 0ef65f5
Merge branch 'release/2.0' into feature/pkg_list
memsharded eb69a43
changed PackageList approach to include multiple remotes
memsharded 6d29cbc
fixes
memsharded d723570
Merge branch 'release/2.0' into feature/pkg_list
memsharded ad7b1d8
review
memsharded dbc0987
Merge branch 'release/2.0' into feature/pkg_list
memsharded 6d2bc7c
wip
memsharded 50398de
Conan 2.0.6
czoido ad22ad3
Fix format for id property in graph output json (#13964)
czoido d3d9fbf
test_requires shouldn't affect package_id (#13966)
memsharded 2609566
[graph][json] Same json output for conan graph info, create, install …
franramirez688 299169f
wip
memsharded d49d7b8
Merge branch 'release/2.0' into feature/pkg_list
memsharded 0beed42
wip
memsharded 1556da4
fixes
memsharded 5261c8d
review
memsharded 531caa1
Merge branch 'release/2.0' into feature/pkg_list
memsharded 659ab7c
added download of pkg-list
memsharded dcc3a54
Update conan/cli/commands/download.py
memsharded 9b39a4a
review
memsharded dd7f34f
solve conflicts
memsharded File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then, the
graphfile
param and the function itself are only supposed to fill theLocal Cache
field, aren't they? Shouldload_graph
mention anything in a docstring to clarify it? Ifload
are addingremotes
and this is not, I think both docstrings could be useful.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good point.
Indeed, this is hardcoding the assumption that
load_graph
at the moment only happens for packages that have been installed in the cache, and then exists there for sure.We need to check if there is some scenario with
graph info
that do not retrieve the binaries to the local cache if this makes sense or not. I'll have a look.