Feature/pkg list #13928
Feature/pkg list #13928
Conversation
memsharded
requested review from
AbrilRBS,
franramirez688 and
czoido
and removed request for
AbrilRBS and
franramirez688
* convert to str * franchus review
* test_requires shouldn't affect package_id * test with transitive * remove prints
…and export-pkg (conan-io#13967) * Ensuring the output for the rest of commands * export-pkg too * graph as first output level * wip * typo * typos
| assert "Local Cache" in client.load("pkglist.json") | ||
| # Download binary too! Just to make sure it is in the cache, but not uploaded | ||
| # because it is not in the orignal list of only recipes | ||
| client.run(f"download * -r=default") | ||
| client.run("remove * -r=default -c") | ||
| client.run("upload --list=pkglist.json -r=default") | ||
| assert f"Uploading recipe 'zlib/1.0.0" in client.out | ||
| assert f"Uploading recipe 'zli/" not in client.out |
There was a problem hiding this comment.
This neatly shows the usecase, I think it was a good call to have both download & upload available at first :)
| recipes = [r.lower() for r in graph_recipes or []] | ||
| binaries = [b.lower() for b in graph_binaries or []] | ||
|
|
||
| pkglist.lists["Local Cache"] = cache_list |
There was a problem hiding this comment.
Then, the graphfile param and the function itself are only supposed to fill the Local Cache field, aren't they? Should load_graph mention anything in a docstring to clarify it? If load are adding remotes and this is not, I think both docstrings could be useful.
There was a problem hiding this comment.
This is a good point.
Indeed, this is hardcoding the assumption that load_graph at the moment only happens for packages that have been installed in the cache, and then exists there for sure.
We need to check if there is some scenario with graph info that do not retrieve the binaries to the local cache if this makes sense or not. I'll have a look.
Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Changelog: Feature: Use
PackagesListas input argument forconan upload --list=pkglist.json.Changelog: Feature: Use
--graphinput forconan listto create aPackagesListthat can be used as input forconan upload.Docs: conan-io/docs#3257
Close #13274
Close #10436
Close #6925
Close #6647