Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcap: add version 0.1.0 #9848

Merged
merged 8 commits into from
Apr 1, 2022
Merged

mcap: add version 0.1.0 #9848

merged 8 commits into from
Apr 1, 2022

Conversation

jtbandes
Copy link
Contributor

Hello 👋

I'm part of a team developing a file format, MCAP, and we would like the C++ reader/writer libraries to be available on ConanCenter. This is the first published version of the package, which is a header-only library, with dependencies on fmt, lz4, and zstd.

Closes foxglove/mcap#201

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Mar 18, 2022
Merged
Merged
jtbandes added a commit to foxglove/mcap that referenced this pull request Mar 18, 2022
@jtbandes
Add missing #include <cstddef> for std::byte (#315)
33bddb9 
**Public-Facing Changes**
None

**Description**
Found via test failure on conan-io/conan-center-index#9848
@jtbandes jtbandes changed the title mcap: add version 0.1.1 mcap: add version 0.1.0 Mar 18, 2022
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@jtbandes jtbandes marked this pull request as ready for review March 20, 2022 23:39
@conan-center-bot

This comment has been minimized.

Sign in to view
@prince-chrismc prince-chrismc mentioned this pull request Mar 21, 2022
Open
uilianries
uilianries reviewed Mar 21, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

@jtbandes jtbandes requested a review from uilianries March 21, 2022 17:07
@conan-center-bot
Copy link
Collaborator

All green in build 8 (0fd136be2c8422af734d318a1766c32d797c2249):

  • mcap/0.1.0@:
    All packages built successfully! (All logs)

jtbandes added a commit to foxglove/mcap that referenced this pull request Mar 22, 2022
@jtbandes
Fix range check in unit test Buffer::read (#314)
e826316 
**Public-Facing Changes**
None


**Description**
Fixed an incorrect `>=` check in `Buffer`. Updated tests to generate data using Buffer instead of a fixture file, thus exercising the fixed code.
 
Found when writing test code for conan-io/conan-center-index#9848
uilianries
uilianries approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot requested a review from jgsogo March 22, 2022 11:59
@jtbandes
Copy link
Contributor Author

Hi, is there any update on this, or anything else I can do to help shepherd it along?

@uilianries
Copy link
Member

@danimtb could you please review this PR, so we can merge it.

@uilianries uilianries requested a review from danimtb March 31, 2022 09:35
@conan-center-bot conan-center-bot merged commit fb4b0d6 into conan-io:master Apr 1, 2022
SpaceIm
SpaceIm reviewed Apr 1, 2022
View reviewed changes
recipes/mcap/all/conanfile.py
raise ConanInvalidConfiguration("Compiler version is not supported, c++17 support is required")
if (self.settings.compiler == "gcc" or self.settings.compiler == "clang") and tools.Version(self.settings.compiler.version) <= 8:
raise ConanInvalidConfiguration("Compiler version is not supported, c++17 support is required")
if self.settings.compiler == "Visual Studio" and tools.Version(self.settings.compiler.version) <= "16.8":
Copy link
Contributor

@SpaceIm SpaceIm Apr 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't compare Visual Studio version like that, it raises for Visual Studio 2019.

Copy link
Contributor Author

@jtbandes jtbandes Apr 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got this pattern from conan-io/conan#8002, which is linked from the readme: https://github.com/conan-io/conan-center-index/blob/master/docs/faqs.md#why-is-a-toolscheck_min_cppstd-call-not-enough, via this conversation on another package I worked on: #8662 (comment) cc @prince-chrismc

Maybe the version requirement can be relaxed but this previous package failed to build with lower version numbers. Example failure: https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/8662/11-configs/windows-visual_studio/foxglove-websocket/0.0.1//summary.json

@jtbandes jtbandes deleted the jacob/add-mcap branch April 1, 2022 20:42
This was referenced Apr 2, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceIm SpaceIm SpaceIm left review comments

@SSE4 SSE4 SSE4 approved these changes

@uilianries uilianries uilianries approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@jgsogo jgsogo Awaiting requested review from jgsogo

@danimtb danimtb Awaiting requested review from danimtb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish c++ conan package
6 participants
@jtbandes @conan-center-bot @uilianries @SSE4 @prince-chrismc @SpaceIm