-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
foxglove-websocket: add version 0.0.1 #8662
foxglove-websocket: add version 0.0.1 #8662
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really freaking good! Just two small details to keep it inline with CCI
Having used websocketpp in the past this looks like a welcomed improvement!
This comment has been minimized.
This comment has been minimized.
Hm, I wonder if this new error is due to the |
yes, I think so. it tries to compile with old standard, but as I can see, it needs C++17 at very least, right? |
Yes, that was the purpose of adding |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@prince-chrismc If you have some advice that would be appreciated! I'm stuck...it really seems like |
conan_basic_setup() | ||
|
||
add_executable(test_package test_package.cpp) | ||
target_link_libraries(test_package ${CONAN_LIBS}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking quickly you'll need to configure C++17 here ... here's an example
set_target_properties(example PROPERTIES CXX_STANDARD 17) |
I'll take a better look tomorrow of theres anything else I can find
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that helped for setting the language standard but still running into problems with the standard library version.
This comment has been minimized.
This comment has been minimized.
Yuck. My system was out of date... Sadly everything checks out on my setup 🤔
Maybe try bumping the min compiler to 8? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This reverts commit 60416ef.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
raise ConanInvalidConfiguration("Compiler version is not supported, c++17 support is required") | ||
|
||
def configure(self): | ||
self.options["websocketpp"].asio = "standalone" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. The default value is "boost", without it, this package would be invalid.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
All green in build 15 (
|
Hello 👋
I'm the author of this package,
foxglove-websocket
, which is part of a larger project at foxglove/ws-protocol (read more here). We would like the C++ server library to be available on ConanCenter. This is the first version of the package. It's currently a header-only library, with dependencies onnlohmann_json
andwebsocketpp
.conanio/clang10
Docker container using-s compiler.cppstd=17 -s compiler.libcxx=libc++
.