Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost: compiler=msvc support + bump dependencies #9790

Merged
merged 4 commits into from
Mar 18, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Mar 15, 2022

other minor modifications:

  • move few ConanInvalidConfiguration from configure() to validate()
  • use conan.tools.files.rename() instead of tools.rename()

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@ghost
Copy link

ghost commented Mar 15, 2022

I detected other pull requests that are modifying boost/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

}.get(str(self.settings.compiler), str(self.settings.compiler))
if (self.settings.compiler, self.settings.os) == ("gcc", "Windows"):
compiler = "mgw"
os_ = ""
if self.settings.os == "Macos":
os_ = "darwin"
toolset_version = str(tools.Version(self.settings.compiler.version).major)
if str(self.settings.compiler) in ("msvc", "Visual Studio"):
if self._is_msvc:
toolset_version = self._toolset_version.replace(".", "")
Copy link
Contributor Author

@SpaceIm SpaceIm Mar 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_toolset_version() relies on tools.msvs_toolset() which doesn't support compiler=msvc, but I don't see a similar function in conan.tools.microsoft (I see something in MSBuildToolchain but I'm a little bit reluctant to instantiate this class just to get toolset version).

/cc @memsharded @lasote

@conan-center-bot
Copy link
Collaborator

All green in build 1 (e4ef0e71fca079d52b46b2eecc18f4162d46ffb0):

  • boost/1.70.0@:
    All packages built successfully! (All logs)

  • boost/1.72.0@:
    All packages built successfully! (All logs)

  • boost/1.71.0@:
    All packages built successfully! (All logs)

  • boost/1.74.0@:
    All packages built successfully! (All logs)

  • boost/1.77.0@:
    All packages built successfully! (All logs)

  • boost/1.69.0@:
    All packages built successfully! (All logs)

  • boost/1.78.0@:
    All packages built successfully! (All logs)

  • boost/1.73.0@:
    All packages built successfully! (All logs)

  • boost/1.76.0@:
    All packages built successfully! (All logs)

  • boost/1.75.0@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 5d67732 into conan-io:master Mar 18, 2022
@SpaceIm SpaceIm deleted the boost-msvc-support branch March 18, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants