Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[boost] Apply patch to fix https://github.com/boostorg/graph/issues/268 #6132

Closed
wants to merge 5 commits into from

Conversation

cqc-alec
Copy link
Contributor

@cqc-alec cqc-alec commented Jul 2, 2021

Closes #6131 .

@CLAassistant
Copy link

CLAassistant commented Jul 2, 2021

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Jul 2, 2021

I detected other pull requests that are modifying boost/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@cqc-alec
Copy link
Contributor Author

cqc-alec commented Jul 2, 2021

PR to apply this fix to boost: boostorg/graph#269 .

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@cqc-alec
Copy link
Contributor Author

I do not seem to have permission to view the logs for the CI failure, so I don't know what the "unexpected error" is -- in any case it is for a configuration that should not be affected by this patch at all.

@SSE4 SSE4 closed this Jul 10, 2021
@SSE4 SSE4 reopened this Jul 10, 2021
@conan-center-bot

This comment has been minimized.

@SSE4 SSE4 closed this Jul 21, 2021
@SSE4 SSE4 reopened this Jul 21, 2021
@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request Sep 20, 2021
4 tasks
@ghost ghost mentioned this pull request Nov 19, 2021
4 tasks
@ghost ghost mentioned this pull request Jan 10, 2022
4 tasks
@cqc-alec
Copy link
Contributor Author

For the record, this patch has been accepted into boost::graph on develop:
boostorg/graph@fa3bd05

@SSE4 SSE4 requested a review from jgsogo February 21, 2022 07:44
@prince-chrismc
Copy link
Contributor

https://github.com/boostorg/graph/pull/269/files

Thanks for taking the time to see that through

@ghost ghost mentioned this pull request Mar 15, 2022
4 tasks
@ghost ghost mentioned this pull request Apr 10, 2022
4 tasks
@conan-center-bot
Copy link
Collaborator

Failure in build 2 (c268543a4f94a2317517924166f6c6803b6f0195):

An unexpected error happened and has been reported. Help is on its way! 🏇

@cqc-alec
Copy link
Contributor Author

I am going to close this, since the consensus is that we shouldn't apply code patches to libraries, and I can keep using my workaround until the next version of boost graph is released.

@cqc-alec cqc-alec closed this Apr 21, 2022
@prince-chrismc prince-chrismc mentioned this pull request Apr 7, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Affected by an external issue and waiting until it is solved Unexpected Error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[boost] graph: patch for https://github.com/boostorg/graph/issues/268
8 participants