Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate co recipe in favor of cocoyaxi #8916

Merged
merged 2 commits into from
Jan 25, 2022
Merged

deprecate co recipe in favor of cocoyaxi #8916

merged 2 commits into from
Jan 25, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jan 14, 2022

see #8915 (comment)

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@SpaceIm SpaceIm mentioned this pull request Jan 14, 2022
Closed
4 tasks
SpaceIm
SpaceIm commented Jan 14, 2022
View reviewed changes
recipes/co/all/conanfile.py
@@ -12,6 +11,9 @@ class CoConan(ConanFile):
license = "MIT"
description = "A go-style coroutine library in C++11 and more."
topics = ("co", "coroutine", "c++11")

deprecated = "cocoyaxi"
Copy link
Contributor Author

@SpaceIm SpaceIm Jan 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering: shouldn't there be provides also?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familar with conan. So what I should do now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering: shouldn't there be provides also?

I have added cocoyaxi in #8930

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For co 2.0.2, the sha256 sum should be 5dbb90e18627ebe563a6a437e8e28329a6bfc07f266718318bd3adf26027d156

@conan-center-bot

This comment has been minimized.

Sign in to view
idealvin
idealvin previously approved these changes Jan 15, 2022
View reviewed changes
recipes/co/all/conanfile.py
@@ -12,6 +11,9 @@ class CoConan(ConanFile):
license = "MIT"
description = "A go-style coroutine library in C++11 and more."
topics = ("co", "coroutine", "c++11")

deprecated = "cocoyaxi"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For co 2.0.2, the sha256 sum should be 5dbb90e18627ebe563a6a437e8e28329a6bfc07f266718318bd3adf26027d156

@conan-center-bot
Copy link
Collaborator

All green in build 2 (9bb5ef0309d9e24a06e5610b4b2382b9f031b12a):

  • co/2.0.2@:
    All packages built successfully! (All logs)

@prince-chrismc prince-chrismc mentioned this pull request Jan 18, 2022
Open
@SSE4
Copy link
Contributor

SSE4 commented Jan 19, 2022

was it rebranded upstream, or what exactly happened? I can't get from #8915

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 19, 2022

see #8930

@prince-chrismc
Copy link
Contributor

It was renamed, https://github.com/idealvin/co points to new name

@SSE4
Copy link
Contributor

SSE4 commented Jan 25, 2022

It was renamed, https://github.com/idealvin/co points to new name

thanks for the clarification!

@SSE4 SSE4 requested a review from uilianries January 25, 2022 11:55
@conan-center-bot conan-center-bot merged commit 7e4c441 into conan-io:master Jan 25, 2022
@SpaceIm SpaceIm deleted the co-deprecate branch January 25, 2022 15:58
Sahnvour pushed a commit to Sahnvour/conan-center-index that referenced this pull request Jan 30, 2022
@SpaceIm @Sahnvour
(conan-io#8916) deprecate co recipe in favor of cocoyaxi
5e9f14a 
* deprecate co recipe in favor of cocoyaxi

* fix sha
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@uilianries uilianries uilianries approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@idealvin idealvin idealvin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SpaceIm @conan-center-bot @SSE4 @prince-chrismc @uilianries @idealvin