Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename co to cocoyaxi #8915

Closed
wants to merge 3 commits into from
Closed

rename co to cocoyaxi #8915

wants to merge 3 commits into from

Conversation

idealvin
Copy link
Contributor

@idealvin idealvin commented Jan 14, 2022 •
edited
Loading

co/2.0.2

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

Sign in to view
@idealvin idealvin changed the title deprecate co in cocoyaxi rename co to cocoyaxi Jan 14, 2022
@idealvin idealvin mentioned this pull request Jan 14, 2022
Closed
4 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@ghost ghost mentioned this pull request Jan 14, 2022
Closed
SpaceIm
SpaceIm reviewed Jan 14, 2022
View reviewed changes
recipes/co/all/conanfile.py
@@ -14,6 +14,7 @@ class CoConan(ConanFile):
topics = ("co", "coroutine", "c++11")
exports_sources = "CMakeLists.txt", "patches/*"
generators = "cmake", "cmake_find_package"
deprecated = "cocoyaxi"
Copy link
Contributor

@SpaceIm SpaceIm Jan 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said, this modification should live in another PR than this one. Indeed conan-center-index doesn't allow to modify 2 different recipes in the same PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened #8916, so just focus on cocoyaxi please

@SpaceIm SpaceIm mentioned this pull request Jan 14, 2022
Merged
4 tasks
@conan-center-bot
Copy link
Collaborator

config.yml syntax error in build 3:

Only one library can be changed in the same PR: [co/all, cocoyaxi/all]

@idealvin idealvin closed this Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceIm SpaceIm SpaceIm left review comments

Assignees
No one assigned
Labels
Failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@idealvin @conan-center-bot @SpaceIm