gperf: fix PR #5835. Correct patch file name and apply patches #6254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in source() method
This comment has been minimized.
This comment has been minimized.
ghost
mentioned this pull request
|
I detected other pull requests that are modifying gperf/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
ghost
mentioned this pull request
|
This PR might be obsoleted by PR #6226. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
madebr
reviewed
Jul 10, 2021
recipes/gperf/all/conanfile.py
Outdated
Comment on lines
33
to
34
| for patch in self.conan_data.get("patches", {}).get(self.version, []): | ||
| tools.patch(**patch) |
There was a problem hiding this comment.
Please move the patching to the start of the build method.
|
All green in build 4 (
|
madebr
approved these changes
Jul 10, 2021
theirix
approved these changes
Jul 10, 2021
SSE4
approved these changes
Jul 10, 2021
AndreyMlashkin
pushed a commit
to AndreyMlashkin/conan-center-index
that referenced
this pull request
Jul 19, 2021
…and apply patches * gperf: fix PR conan-io#5835. Correct patch file name and apply patches in source() method * gperf: implement feedback from PR conan-io#6254, move patch code to build method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rce() method
Specify library name and version: gperf/3.1
PR #5835 added a patch to remove a register keyword. However the patch is never applied because:
I compiled gperf 3.1 successfully with clang12 (that uses C++17 by default) with this PR.
conan-center hook activated.