remove register keyword as not cpp17 complient

[AndreyMlashkin]

Specify library name and version: gperf/3.1

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!

---

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the
  conan-center hook activated.

[intelligide]

The recipe should not change the sources in this way. If the library does not support C++17, it is better to patch the upstream than to modify the sources. For more information, see this discussion (#3951).

[ericLemanissier]

the patch needs to be added to conandata.yml, and tools.patch must be called, otherwise nothing changes here

[conan-center-bot]

All green in build 3 (367374d9ead928dceff05ab692a5bc795f08a138):

• gperf/3.1@:
  All packages built successfully! (All logs)

[uilianries]

@AndreyMlashkin Please, read #3951. It's still a draft, but that's the way. We usually only accept security and build system patches. I would suggest you sending this patch to the upstream, otherwise, we will need to replicate for every new release.

[ericLemanissier]

AFAIU, we are exactly in the case described in https://github.com/conan-io/conan-center-index/pull/3951/files#diff-8aa07bf0dad3063ca38d5b842b934aa4f6d59bdab84855edc30d54e333c05409R21-R24 : the package does not compile std=C++17, because the register keyword was removed from the language. Nonetheless, the patch should be submitted upstream.

[madebr]

It's already upstream: see #5835 (comment)

[madebr]

I think the patch is the less of all evil.
You could conditionally lower the -std=c++ standard but that would require custom code in the recipe.
A patch is an ideal way to change something once, and forget about it for the following releases.

[wdobbe]

This PR doesn't work: the name of the patch file in conandata.yml is incorrect (probably copy/paste error).
This was not discovered because the source() method of the conanfile.py misses the code to apply the patches.

I will submit a new PR to correct.