rocksdb: add versions 6.0.2 and 6.20.3 #6018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for backwards compatibility on a project.
RocksDB 6.0.2 had an invalid use of const, which was later fixed in facebook/rocksdb#6048 Applying the fix as a patch to 6.0.2 could result in a regression, so just don't compile with this compiler instead
This was referenced Jun 22, 2021
This comment has been minimized.
This comment has been minimized.
This was referenced Jun 22, 2021
This comment has been minimized.
This comment has been minimized.
…n-center-index into rocksdb/add_v6.0.2_v6.20.3
This comment has been minimized.
This comment has been minimized.
|
I investigated the error for version 6.10.2 and package ID e9395492247c902e986bb43e0038bb2a0c2e606e. It seems to be a temporary problem on the runner machine while executing tests. And the same version and package ID for roughly the same recipe succeeded on #5900. So I now re-triggered a build by fetching master. I think that shall work. |
fennibay
changed the title
|
@conan-center-bot how can I trigger the build? Why is it aborted? |
|
Hi! I'm tracking this PR and (besides fighting for resources with some Qt pull-request) it is taking too long to build, longer that I would expect in the Linux machines. I've restarted it just in case. I hope it succeeds or I'll try to investigate the failure. 🕵️ |
|
All green in build 8 ( |
jgsogo
approved these changes
Jun 24, 2021
uilianries
approved these changes
Jun 25, 2021
theirix
approved these changes
Jun 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: rocksdb/6.0.2 rocksdb/6.20.3
I actually need exactly v6.0.2 for backwards compatibility on one of my projects. I created PR #5900 for that.
If things go well, we could actually add also the latest version v6.20.3, so I'm creating this PR for this. If this succeeds, we can ignore #5900.
conan-center hook activated.