rocksdb: Add version 6.0.2 #5900

fennibay · 2021-06-15T12:32:46Z

Specify library name and version: rocksdb/6.0.2

For backwards compatibility on one of my projects, I need exactly the version 6.0.2. And instead of solving this for myself, I thought contributing to this repo would help others, too.

Current latest version of RocksDB is 6.20.3, I could also add that as a separate PR if desired.

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes. // no change needed in the py files.
I've used the latest Conan client version. // v1.37.2
I've tried at least one configuration locally with the
conan-center hook activated. // tested with conan create and conan test

This is needed for backwards compatibility on a project.

CLAassistant · 2021-06-15T12:32:50Z

All committers have signed the CLA.

ghost · 2021-06-17T14:49:45Z

I detected other pull requests that are modifying rocksdb/all recipe:

rocksdb: add versions 6.0.2 and 6.20.3 #6018

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

prince-chrismc · 2021-06-22T00:37:41Z

Thank you for stating you need this exact version

Current latest version of RocksDB is 6.20.3, I could also add that as a separate PR if desired.

You can add it in this one... if it takes more changes (ie recipe modifications) save it for another PR

RocksDB 6.0.2 had an invalid use of const, which was later fixed in facebook/rocksdb#6048 Applying the fix as a patch to 6.0.2 could result in a regression, so just don't compile with this compiler instead

fennibay · 2021-06-22T15:07:10Z

Setting back to draft until I figure out the build problems

conan-center-bot · 2021-06-22T21:13:09Z

Failure in build 4 (dfd98147508802b1dac998d61732d238a5f12800):

rocksdb/6.0.2@:
CI failed to create some packages (All logs)

Logs for packageID 41f9523a0b8902f880bc9b145935e445607146b0:

[settings]
arch=x86_64
arch_build=x86_64
build_type=Debug
compiler=clang
compiler.libcxx=libstdc++
compiler.version=10
os=Linux
os_build=Linux
[options]
rocksdb:shared=False

[...]
    NUMBER_KEYS_WRITTEN,
    ^
/home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/include/rocksdb/statistics.h:121:3: note: previous declaration is here
  NUMBER_KEYS_WRITTEN,
  ^
In file included from /home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/utilities/blob_db/blob_compaction_filter.cc:8:
In file included from /home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/utilities/blob_db/blob_compaction_filter.h:13:
In file included from /home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/utilities/blob_db/blob_db_impl.h:22:
In file included from /home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/db/db_iter.h:13:
In file included from /home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/db/db_impl.h:23:
In file included from /home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/db/compaction_job.h:24:
/home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/db/internal_stats.h:116:5: warning: declaration shadows a variable in namespace 'rocksdb' [-Wshadow]
    WRITE_DONE_BY_OTHER,
    ^
/home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/include/rocksdb/statistics.h:198:3: note: previous declaration is here
  WRITE_DONE_BY_OTHER,  // Equivalent to writes done for others
  ^
In file included from /home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/utilities/blob_db/blob_compaction_filter.cc:8:
In file included from /home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/utilities/blob_db/blob_compaction_filter.h:13:
In file included from /home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/utilities/blob_db/blob_db_impl.h:22:
In file included from /home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/db/db_iter.h:13:
In file included from /home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/db/db_impl.h:23:
In file included from /home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/db/compaction_job.h:24:
/home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/db/internal_stats.h:117:5: warning: declaration shadows a variable in namespace 'rocksdb' [-Wshadow]
    WRITE_DONE_BY_SELF,
    ^
/home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/include/rocksdb/statistics.h:197:3: note: previous declaration is here
  WRITE_DONE_BY_SELF,
  ^
In file included from /home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/utilities/blob_db/blob_compaction_filter.cc:8:
In file included from /home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/utilities/blob_db/blob_compaction_filter.h:13:
In file included from /home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/utilities/blob_db/blob_db_impl.h:22:
In file included from /home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/db/db_iter.h:13:
In file included from /home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/db/db_impl.h:23:
In file included from /home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/db/compaction_job.h:24:
/home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/db/internal_stats.h:118:5: warning: declaration shadows a variable in namespace 'rocksdb' [-Wshadow]
    WRITE_WITH_WAL,
    ^
/home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/source_subfolder/include/rocksdb/statistics.h:200:3: note: previous declaration is here
  WRITE_WITH_WAL,       // Number of Write calls that request WAL
  ^
8 warnings generated.
make[1]: *** [source_subfolder/CMakeFiles/rocksdb-shared.dir/all] Error 2
make: *** [all] Error 2
rocksdb/6.0.2: WARN: Build folder is dirty, removing it: /home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0
rocksdb/6.0.2: ERROR: Package '41f9523a0b8902f880bc9b145935e445607146b0' build failed
rocksdb/6.0.2: WARN: Build folder /home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0
ERROR: rocksdb/6.0.2: Error in build() method, line 164
	cmake.build()
	ConanException: Error 2 while executing cmake --build '/home/conan/w/BuildSingleReference/.conan/data/rocksdb/6.0.2/_/_/build/41f9523a0b8902f880bc9b145935e445607146b0/build_subfolder' '--' '-j3'

rocksdb/6.8.1@:
All packages built successfully! (All logs)
rocksdb/6.10.2@:
All packages built successfully! (All logs)

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

fennibay · 2021-06-26T16:11:05Z

Superseded by #6018. Closing

fennibay added 2 commits June 15, 2021 10:14

rocksdb: Add version 6.0.2

5f969ca

This is needed for backwards compatibility on a project.

fix: adapt patch file to 6.0.2

2ac901a

This comment has been minimized.

Sign in to view

conan-center-bot added the No Beta user label Jun 15, 2021

This was referenced Jun 17, 2021

[service] Potentially conflicting recipes #3571

Closed

[rocksdb][m1] Enable CRC features, not activated by default #5945

Merged

Merge branch 'conan-io:master' into rocksdb/add_v6.0.2

ff45efe

fennibay marked this pull request as ready for review June 21, 2021 18:50

conan-center-bot removed the No Beta user label Jun 21, 2021

github-actions bot mentioned this pull request Jun 21, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

prince-chrismc previously approved these changes Jun 22, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Jun 22, 2021

Do not compile RocksDB 6.0.2 with VS > 15

dfd9814

RocksDB 6.0.2 had an invalid use of const, which was later fixed in facebook/rocksdb#6048 Applying the fix as a patch to 6.0.2 could result in a regression, so just don't compile with this compiler instead

fennibay dismissed prince-chrismc’s stale review via dfd9814 June 22, 2021 07:21

fennibay mentioned this pull request Jun 22, 2021

rocksdb: add versions 6.0.2 and 6.20.3 #6018

Merged

4 tasks

prince-chrismc approved these changes Jun 22, 2021

View reviewed changes

fennibay marked this pull request as draft June 22, 2021 15:07

fennibay closed this Jun 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rocksdb: Add version 6.0.2 #5900

rocksdb: Add version 6.0.2 #5900

fennibay commented Jun 15, 2021

CLAassistant commented Jun 15, 2021 •

edited

Loading

This comment has been minimized.

ghost commented Jun 17, 2021 •

edited by ghost

Loading

prince-chrismc commented Jun 22, 2021

This comment has been minimized.

fennibay commented Jun 22, 2021

conan-center-bot commented Jun 22, 2021

fennibay commented Jun 26, 2021

rocksdb: Add version 6.0.2 #5900

rocksdb: Add version 6.0.2 #5900

Conversation

fennibay commented Jun 15, 2021

CLAassistant commented Jun 15, 2021 • edited Loading

This comment has been minimized.

ghost commented Jun 17, 2021 • edited by ghost Loading

prince-chrismc commented Jun 22, 2021

This comment has been minimized.

fennibay commented Jun 22, 2021

conan-center-bot commented Jun 22, 2021

fennibay commented Jun 26, 2021

CLAassistant commented Jun 15, 2021 •

edited

Loading

ghost commented Jun 17, 2021 •

edited by ghost

Loading