Boost: Treat empty CXX, AR, RANLIB env as undefined #5593
Conversation
| @@ -1045,23 +1045,23 @@ def _build_cross_flags(self): | |||
|
|
|||
| @property | |||
| def _ar(self): | |||
| if "AR" in os.environ: | |||
| if os.environ.get("AR"): | |||
There was a problem hiding this comment.
Use tools.get_env instead?
There was a problem hiding this comment.
It looks like tools.get_env (aka conans.util.env_reader.get_env) doesn't really do anything when the default is None or a str as it is in this case, it seems like the purpose is to coerce the type when default is a bool, int, float, or list.
ghost
mentioned this pull request
|
I detected other pull requests that are modifying boost/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
#5575 will fix this conflict. By the way I don't fully understand why it complains about a build requirement of libbacktrace, build_requirements shouldn't be evaluated since a pre built package is available. |
|
@SpaceIm Yes, I think that's just the state of |
Fixes Issue conan-io#5569 A bug in cmake-gui would have it sometimes set CXX to empty instead of leaving it undefined. CXX detection in the boost recipe would use the blank value and fail to build. Now we treat empty the same as undefined and move on to e.g. xcrun detection for these properties.
This is a limitation in Conan when using only one profile: the graph is expanding build-requires in the same context and they can conflict 😞 . Mid-term we will start to use two-profiles in CCI, so these issues should be gone. |
|
The prior referenced pull requests have all merged, I've rebased this PR to incorporate the updates. |
|
All green in build 2 (
|
There was a problem hiding this comment.
I think this is the issue on the CMake side https://gitlab.kitware.com/cmake/cmake/-/issues/21449 (already fixed via https://gitlab.kitware.com/cmake/cmake/-/merge_requests/6151 for 3.21.0).
Fixes Issue conan-io#5569 A bug in cmake-gui would have it sometimes set CXX to empty instead of leaving it undefined. CXX detection in the boost recipe would use the blank value and fail to build. Now we treat empty the same as undefined and move on to e.g. xcrun detection for these properties.
Fixes Issue #5569
A bug in cmake-gui would have it sometimes set CXX to
empty instead of leaving it undefined. CXX detection
in the boost recipe would use the blank value and fail
to build. Now we treat empty the same as undefined
and move on to e.g. xcrun detection for these properties.
Specify library name and version: boost/1.76.0 (Really all versions)
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
On MacOS, when specifying options other than those used in the prebuilt variants on conan center
and using
build=missingboost was failing to build. Conan was invoked from CMake which wasconfigured from cmake-gui, a common developer workflow in our environment.
conan-center hook activated.