boost: fix with_stacktrace_backtrace for Macos & MinGW + bump dependencies

[SpaceIm]

Specify library name and version: lib/1.0

closes #5556
closes #5571

---

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the
  conan-center hook activated.

[ghost]

I detected other pull requests that are modifying boost/all recipe:

• Boost: Treat empty CXX, AR, RANLIB env as undefined #5593
• boost: Improve option for i18n backend #5553
• [boost] For Visual Studio, pass some values of settings.compiler.toolset to B2 #5119
• boost: header only boost::system #5051
• boost: use clang-win toolset when compiler=Visual Studio and compiler.toolset=ClangCL #4749
• Boost/1.72.0/mpi #3959

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

[SpaceIm]

It still fails with MinGW on Windows out of the box because default value of addr2line_location option is /usr/bin/addr2line

[SpaceIm]

Interesting, now we can see that with_stacktrace_backtrace doesn't work as is on Macos.

[madebr]

Looks like this error got triggered before at #5420 (comment) but I didn't look into it because it went away.

This is the culprit: https://github.com/boostorg/stacktrace/blob/b37e0d8e9f9613813534b6765559bdec693f34d5/include/boost/stacktrace/detail/libbacktrace_impls.hpp#L95-L101

The failed logs contain:

/Users/jenkins/w/BuildSingleReference@2/.conan/data/b2/4.5.0/_/_/package/46f53f156846659bf39ad6675fa0ee8156e859fe/lib
boost/1.72.0: WARN: Build folder is dirty, removing it: /Users/jenkins/w/BuildSingleReference@2/.conan/data/boost/1.72.0/_/_/build/f05b37ef109e11cd86bbb8d64d51015777db9870
WARN: replace_in_file didn't find pattern '/* thread_local */' in '/Users/jenkins/w/BuildSingleReference@2/.conan/data/boost/1.72.0/_/_/source/source_subfolder/boost/stacktrace/detail/libbacktrace_impls.hpp' file.
WARN: replace_in_file didn't find pattern '/* static __thread */' in '/Users/jenkins/w/BuildSingleReference@2/.conan/data/boost/1.72.0/_/_/source/source_subfolder/boost/stacktrace/detail/libbacktrace_impls.hpp' file.

It looks like my fix at the top of the build method does not apply/work on older boost releases...

[SpaceIm]

Yes, tools.replace_in_file with strict=False is bad bad bad ;)

[madebr]

No wait, the patch is ok, but is currently only applied for clang.
It should be expanded to apple-clang. I don't know for what versions though.

[SpaceIm]

Oh I see, there are 2 successive patches, it's not obvious to understand what happen. The first 2 ones seem to be useless, these patterns don't exist.

[madebr]

Don't know whether it would make it easier to understand, but a regex could do it in one line 😄
conan-io/conan#7007

tools.replace_regex_in_file(r"(thread_local|static __thread)", r"/*\1*/")

[SpaceIm]

I mean, I didn't understand why there was first a patch to replace /* thread_local */ by thread_local with strict=False, then another one to do the opposite based on a condition.
But I get it, boost recipe does not copy source code, so any conditional patch is a mess.

[madebr]

I mean, I didn't understand why there was first a patch to replace /* thread_local */ by thread_local with strict=False, then another one to do the opposite based on a condition.
But I get it, boost recipe does not copy source code, so any conditional patch is a mess.

That was one of the comments on my earlier review.
Perhaps add a comment/FIXME. jgsogo commented to maybe remove no_copy_source = True in a future pr.

[SpaceIm]

There should be a way to patch those lines in libbacktrace_impls.hpp with macros.

[madebr]

There is BOOST_NO_CXX11_THREAD_LOCAL (https://github.com/boostorg/stacktrace/blob/b37e0d8e9f9613813534b6765559bdec693f34d5/include/boost/stacktrace/detail/libbacktrace_impls.hpp#L95-L101).
Maybe my testing was incorrect and defining that macro suffices?

[SpaceIm]

Maybe this in source()?

        tools.replace_in_file(os.path.join(self.source_folder, self._source_subfolder, "boost", "stacktrace", "detail", "libbacktrace_impls.hpp"),
                              "#   ifndef BOOST_NO_CXX11_THREAD_LOCAL",
                              "#   if defined(__APPLE__) || (defined(__clang__) && __clang_major__ < 6)\n#   elif !defined(BOOST_NO_CXX11_THREAD_LOCAL)")

[SpaceIm]

off-topic: any reason why installation is done in build()?

[madebr]

I didn't investigate but I think because configuration + build + install is tightly coupled in boost.build (b2).
You need to do b2 <args> to build and b2 <args> install to install.
b2 will re-run all tests in package, unless it stores state.

It would be nice to have the boost recipe behaving normal.

[SpaceIm]

Seems to be properly split in https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-boost/PKGBUILD, I'll try to split those steps.

[SpaceIm]

But first fix this issue in test_package on macOS:

/Users/jenkins/w/BuildSingleReference@2/.conan/data/boost/1.70.0/_/_/package/9b6ef57289b8c95bc978159b9aa7bfb003dfb749/include/boost/stacktrace/detail/collect_unwind.ipp:33:2: error: "Boost.Stacktrace requires `_Unwind_Backtrace` function. Define `_GNU_SOURCE` macro or `BOOST_STACKTRACE_GNU_SOURCE_NOT_REQUIRED` if _Unwind_Backtrace is available without `_GNU_SOURCE`."
#error "Boost.Stacktrace requires `_Unwind_Backtrace` function. Define `_GNU_SOURCE` macro or `BOOST_STACKTRACE_GNU_SOURCE_NOT_REQUIRED` if _Unwind_Backtrace is available without `_GNU_SOURCE`."
 ^

[SpaceIm]

Well, waiting for #5575. I'm surprised to see that CI uses --dry-build option, which is the reason why coherency of build requirements of dependencies is tested.

[conan-center-bot]

All green in build 8 (a310eb3362dddb89220eab8b1c48eed3176fa6eb):

• boost/1.70.0@:
  All packages built successfully! (All logs)

• boost/1.69.0@:
  All packages built successfully! (All logs)

• boost/1.71.0@:
  All packages built successfully! (All logs)

• boost/1.72.0@:
  All packages built successfully! (All logs)

• boost/1.73.0@:
  All packages built successfully! (All logs)

• boost/1.74.0@:
  All packages built successfully! (All logs)

• boost/1.75.0@:
  All packages built successfully! (All logs)

• boost/1.76.0@:
  All packages built successfully! (All logs)

[madebr]

The logs look fine.
Thanks for fixing this up.

[garethsb]

Thanks 👍