mongo-cxx-driver: use validate() for checking configuration #4057

mathbunnyru · 2021-01-02T11:06:44Z

Specify library name and version: mongo-cxx-driver/3.6.2

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

…guration

mathbunnyru · 2021-01-02T11:09:15Z

recipes/mongo-cxx-driver/all/conanfile.py

+        if self.options.with_ssl and not bool(self.options["mongo-c-driver"].with_ssl):
+            raise ConanInvalidConfiguration("mongo-cxx-driver with_ssl=True requires mongo-c-driver with a ssl implementation")


The old code here, everything is from configure() or build() methods.

I followed the recommendation from here:
https://blog.conan.io/2020/12/14/New-conan-release-1-32.html
the validate() method should take over all responsibility for raising ConanInvalidConfiguration errors

mathbunnyru · 2021-01-02T11:10:30Z

conan create all mongo-cxx-driver/3.6.2@ --build=missing -o mongo-cxx-driver:with_ssl=True -o mongo-c-driver:with_ssl=False now doesn't build dependencies, which is awesome.

conan-center-bot · 2021-01-02T11:46:48Z

An unexpected error happened and has been reported. Help is on its way! 🏇

prince-chrismc · 2021-01-02T16:40:43Z

Should the be a new hook?

prince-chrismc · 2021-01-02T16:43:16Z

recipes/mongo-cxx-driver/all/conanfile.py

+        version = tools.Version(self.settings.compiler.version)
+        if version < self._compilers_minimum_version[compiler]:
+            raise ConanInvalidConfiguration(
+                "{} requires a compiler that supports at least C++{}".format(


I'll have to read that blog post but I would have expected this in configure method

SpaceIm · 2021-01-02T17:03:47Z

I would move validate() between requirements() and source(). It helps to understand the logic and eventually consequences.

You can also bump mongo-c-driver to 1.17.3

mathbunnyru · 2021-01-02T20:56:41Z

Should the be a new hook?

For now I created the issue https://github.com/conan-io/conan/issues/8278

mathbunnyru · 2021-01-02T21:00:16Z

I would move validate() between requirements() and source(). It helps to understand the logic and eventually consequences.

You can also bump mongo-c-driver to 1.17.3

Done. Also bumped boost.

conan-center-bot · 2021-01-02T21:17:05Z

An unexpected error happened and has been reported. Help is on its way! 🏇

prince-chrismc

very weak approval, I dont know this new method 🙊

conan-center-bot · 2021-01-04T07:27:54Z

Some configurations of 'mongo-cxx-driver/3.6.1' failed in build 3 (9792706f6a0ff3d04eefdf7565d6bf247ed83221):

Linux x86_64, Release, clang 6.0, libc++ . Options: mongo-cxx-driver:shared-False
Access to all the logs
Linux x86_64, Release, clang 6.0, libstdc++ . Options: mongo-cxx-driver:shared-False
Access to all the logs

mathbunnyru · 2021-01-04T09:04:29Z

Both errors are: ERROR: Missing prebuilt package for 'mongo-c-driver/1.17.3'
What should I do to fix this?

SpaceIm · 2021-01-04T10:40:23Z

Indeed:

with conan search mongo-c-driver/1.17.3@ --table=file.html -r conan-center, I see 87 packages (1 is missing: Linux/clang6.0/static)
1.17.3 is not even displayed on https://conan.io/center/mongo-c-driver

You can open an issue in CCI.

prince-chrismc · 2021-01-04T14:58:44Z

What should I do to fix this?

Call the ~~ghostbusters~~ infra team!

//cc @jgsogo @danimtb if you guys have some time to take a peek at the issue we always appreciate it!

mathbunnyru · 2021-01-04T15:52:51Z

If it's somethin' weird an' it don't look good
Who ya gonna call?
(Ghostbusters!)

#4076

ghost · 2021-01-08T13:51:05Z

I detected other pull requests that are modifying mongo-cxx-driver/all recipe:

[mongo-cxx-driver] remove wrong includedirs #4176

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

mathbunnyru · 2021-01-15T18:34:36Z

I decided to stick with the current version of mongo-c-driver, to merge this PR faster.
The version could be updated later without any problems (when the package is fixed).

prince-chrismc · 2021-01-15T19:08:02Z

🤞 CI passes... dang missing binaries

mathbunnyru · 2021-01-15T19:16:42Z

Merged master, there was an important fix to this recipe.

mathbunnyru · 2021-01-15T19:17:00Z

🤞 CI passes... dang missing binaries

Let's hope and pray :)

conan-center-bot · 2021-01-15T19:19:52Z

Some configurations of 'mongo-cxx-driver/3.6.1' failed in build 4 (8e05648d34c2ec5139159cbe148b6676f2d3c2ee):

conan-center-bot · 2021-01-15T21:14:33Z

All green in build 5 (8e05648d34c2ec5139159cbe148b6676f2d3c2ee)! 😊

mongo-cxx-driver/3.6.1: Generated 132 packages (+ 1 invalid config from build()). All logs here
mongo-cxx-driver/3.6.2: Generated 132 packages (+ 1 invalid config from build()). All logs here

mathbunnyru · 2021-01-18T13:44:12Z

@Croydon may I ask you to review again, please?

mongo-cxx-driver: bump to 3.6.2 and use validate() for checking confi…

86f3929

…guration

mathbunnyru commented Jan 2, 2021

View reviewed changes

conan-center-bot added the Unexpected Error label Jan 2, 2021

This was referenced Jan 2, 2021

Updatable recipes qchateau/conan-center-bot#1

Open

[request] Updatable recipes #3470

Open

prince-chrismc reviewed Jan 2, 2021

View reviewed changes

Ayaz Salikhov added 2 commits January 2, 2021 23:57

Update dependencies

d89cc7f

Review suggestion

9792706

prince-chrismc previously approved these changes Jan 2, 2021

View reviewed changes

mathbunnyru mentioned this pull request Jan 2, 2021

[feature] Do not allow to raise ConanInvalidConfiguration in build() #4062

Closed

1 task

Croydon previously approved these changes Jan 3, 2021

View reviewed changes

mathbunnyru closed this Jan 4, 2021

mathbunnyru reopened this Jan 4, 2021

conan-center-bot added Failed and removed Unexpected Error labels Jan 4, 2021

prince-chrismc mentioned this pull request Jan 6, 2021

OpenCascade 7.5.0 #4094

Merged

4 tasks

This was referenced Jan 8, 2021

[service] Potentially conflicting recipes #3571

Closed

[mongo-cxx-driver] remove wrong includedirs #4176

Merged

Update conanfile.py

8e05648

mathbunnyru dismissed stale reviews from Croydon and prince-chrismc via 8e05648 January 15, 2021 18:32

mathbunnyru changed the title ~~mongo-cxx-driver: bump to 3.6.2 and use validate() for checking confi…~~ mongo-cxx-driver: use validate() for checking configuration Jan 15, 2021

Merge branch 'master' into asalikhov/mongo-cxx-bump

4b45437

conan-center-bot removed the Failed label Jan 15, 2021

prince-chrismc approved these changes Jan 15, 2021

View reviewed changes

SpaceIm approved these changes Jan 15, 2021

View reviewed changes

github-actions bot mentioned this pull request Jan 16, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

SSE4 approved these changes Jan 18, 2021

View reviewed changes

conan-center-bot merged commit d383eb9 into conan-io:master Jan 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mongo-cxx-driver: use validate() for checking configuration #4057

mongo-cxx-driver: use validate() for checking configuration #4057

mathbunnyru commented Jan 2, 2021 •

edited

Loading

mathbunnyru Jan 2, 2021 •

edited

Loading

mathbunnyru commented Jan 2, 2021

conan-center-bot commented Jan 2, 2021

prince-chrismc commented Jan 2, 2021

prince-chrismc Jan 2, 2021

SpaceIm commented Jan 2, 2021 •

edited

Loading

mathbunnyru commented Jan 2, 2021

mathbunnyru commented Jan 2, 2021 •

edited

Loading

conan-center-bot commented Jan 2, 2021

prince-chrismc left a comment

conan-center-bot commented Jan 4, 2021

mathbunnyru commented Jan 4, 2021

SpaceIm commented Jan 4, 2021 •

edited

Loading

prince-chrismc commented Jan 4, 2021

mathbunnyru commented Jan 4, 2021

ghost commented Jan 8, 2021

mathbunnyru commented Jan 15, 2021 •

edited

Loading

prince-chrismc commented Jan 15, 2021

mathbunnyru commented Jan 15, 2021

mathbunnyru commented Jan 15, 2021

conan-center-bot commented Jan 15, 2021

conan-center-bot commented Jan 15, 2021

mathbunnyru commented Jan 18, 2021

		if self.options.with_ssl and not bool(self.options["mongo-c-driver"].with_ssl):
		raise ConanInvalidConfiguration("mongo-cxx-driver with_ssl=True requires mongo-c-driver with a ssl implementation")

mongo-cxx-driver: use validate() for checking configuration #4057

mongo-cxx-driver: use validate() for checking configuration #4057

Conversation

mathbunnyru commented Jan 2, 2021 • edited Loading

mathbunnyru Jan 2, 2021 • edited Loading

Choose a reason for hiding this comment

mathbunnyru commented Jan 2, 2021

conan-center-bot commented Jan 2, 2021

prince-chrismc commented Jan 2, 2021

prince-chrismc Jan 2, 2021

Choose a reason for hiding this comment

SpaceIm commented Jan 2, 2021 • edited Loading

mathbunnyru commented Jan 2, 2021

mathbunnyru commented Jan 2, 2021 • edited Loading

conan-center-bot commented Jan 2, 2021

prince-chrismc left a comment

Choose a reason for hiding this comment

conan-center-bot commented Jan 4, 2021

mathbunnyru commented Jan 4, 2021

SpaceIm commented Jan 4, 2021 • edited Loading

prince-chrismc commented Jan 4, 2021

mathbunnyru commented Jan 4, 2021

ghost commented Jan 8, 2021

mathbunnyru commented Jan 15, 2021 • edited Loading

prince-chrismc commented Jan 15, 2021

mathbunnyru commented Jan 15, 2021

mathbunnyru commented Jan 15, 2021

conan-center-bot commented Jan 15, 2021

conan-center-bot commented Jan 15, 2021

mathbunnyru commented Jan 18, 2021

mathbunnyru commented Jan 2, 2021 •

edited

Loading

mathbunnyru Jan 2, 2021 •

edited

Loading

SpaceIm commented Jan 2, 2021 •

edited

Loading

mathbunnyru commented Jan 2, 2021 •

edited

Loading

SpaceIm commented Jan 4, 2021 •

edited

Loading

mathbunnyru commented Jan 15, 2021 •

edited

Loading