boost: be more strict about boost libraries #3999

madebr · 2020-12-26T20:30:12Z

Specify library name and version: boost/all

After this pr, the libraries are added more stricter.
Before, it allowed missing libraries.
Now we/I better understand how boost builds libraries (or does not), it is possible to be more explicit/strict about adding libraries.
Most importantly, this will result in clearer error messages.

The situation this pr hopes to fix is the following:
Because Boost.Build silently doesn't build boost libraries when some precondition fails, some boost component/module could become unavailable and some conan dependencies not used.
This results in unclear error messages, see #3992

Also, added numa option for boost_fiber_numa library.

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

ghost · 2020-12-26T20:43:22Z

I detected other pull requests that are modifying boost/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

conan-center-bot · 2020-12-26T21:31:36Z

Some configurations of 'boost/1.69.0' failed in build 1 (d55f01fa62e0f6542f2417b3e87e4147487d5cca):

Linux x86_64, Debug, clang 3.9, libstdc++ . Options: boost:shared-False
Access to all the logs
Linux x86_64, Debug, gcc 9, libstdc++ . Options: boost:shared-False
Access to all the logs
Linux x86_64, Debug, clang 7.0, libstdc++ . Options: boost:shared-False
Access to all the logs
Linux x86_64, Debug, clang 8, libc++ . Options: boost:shared-False
Access to all the logs
Linux x86_64, Debug, clang 7.0, libc++ . Options: boost:shared-False
Access to all the logs

conan-center-bot · 2020-12-26T23:24:15Z

Some configurations of 'boost/1.69.0' failed in build 2 (aa40beb726b3af6f20caed5ffa8d98f4da9b2267):

Linux x86_64, Debug, gcc 5, libstdc++11 . Options: boost:shared-False
Access to all the logs
Linux x86_64, Debug, gcc 5, libstdc++ . Options: boost:shared-False
Access to all the logs

conan-center-bot · 2020-12-27T03:02:46Z

Some configurations of 'boost/1.69.0' failed in build 3 (6a358efca602f45aeb87233f470adccf59b642e1):

Windows x86_64, Release, Visual Studio 14, MD. Options: boost:shared-True
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MD. Options: boost:shared-True
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MDd. Options: boost:shared-True
Access to all the logs

conan-center-bot · 2020-12-27T11:36:31Z

All green in build 4 (e00ca36dbd4e615af84660472c855636e2aebe42)! 😊

boost/1.69.0: Generated 131 packages. All logs here
boost/1.70.0: Generated 131 packages. All logs here
boost/1.71.0: Generated 131 packages. All logs here
boost/1.72.0: Generated 131 packages. All logs here
boost/1.73.0: Generated 131 packages. All logs here
boost/1.74.0: Generated 131 packages. All logs here
boost/1.75.0: Generated 131 packages. All logs here

madebr · 2020-12-27T19:15:33Z

recipes/boost/all/conanfile.py

+        if self.settings.compiler == "Visual Studio" and self.options.shared and self.options.numa:
+            raise ConanInvalidConfiguration("Cannot build a shared boost with numa support on Visual Studio")


@prince-chrismc
The limitation to shared is intentional.
dll's don't allow missing symbols, static libraries allow it.
This means a static numa library can be built, but not a shared library.

I said: it can be built. I didn't say that it will work 😄

conan-center-bot · 2020-12-28T01:13:56Z

Some configurations of 'boost/1.69.0' failed in build 5 (d3d719c77092d27529732af613df1c5ef742e1e0):

Windows x86_64, Debug, Visual Studio 16, MTd. Options: boost:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MTd. Options: boost:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 14, MDd. Options: boost:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 14, MTd. Options: boost:shared-False
Access to all the logs

…end on addr2line

conan-center-bot · 2020-12-28T21:51:17Z

Some configurations of 'boost/1.69.0' failed in build 6 (2aaa63aeb1233fbbcb04c82bfd15f9ac31991008):

Linux x86_64, Debug, clang 5.0, libstdc++ . Options: boost:shared-False
Access to all the logs
Linux x86_64, Debug, gcc 5, libstdc++11 . Options: boost:shared-False
Access to all the logs
Linux x86_64, Debug, clang 3.9, libstdc++ . Options: boost:shared-False
Access to all the logs
Linux x86_64, Debug, gcc 8, libstdc++11 . Options: boost:shared-False
Access to all the logs
Linux x86_64, Release, clang 4.0, libc++ . Options: boost:shared-False
Access to all the logs
Linux x86_64, Debug, gcc 8, libstdc++ . Options: boost:shared-False
Access to all the logs
Linux x86_64, Release, clang 8, libstdc++ . Options: boost:shared-False
Access to all the logs
Linux x86_64, Release, clang 9, libstdc++ . Options: boost:shared-False
Access to all the logs

conan-center-bot · 2020-12-29T06:24:03Z

All green in build 7 (cc2b8b41cc203accbd6791136edc414e7544efde)! 😊

boost/1.69.0: Generated 131 packages. All logs here
boost/1.70.0: Generated 131 packages. All logs here
boost/1.71.0: Generated 131 packages. All logs here
boost/1.72.0: Generated 131 packages. All logs here
boost/1.73.0: Generated 131 packages. All logs here
boost/1.74.0: Generated 131 packages. All logs here
boost/1.75.0: Generated 131 packages. All logs here

recipes/boost/all/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

conan-center-bot · 2020-12-29T19:34:39Z

An unexpected error happened and has been reported. Help is on its way! 🏇

conan-center-bot · 2020-12-30T09:33:33Z

All green in build 9 (840b7ce4de04ef9b164fe6b3f8cd707deb35fcac)! 😊

boost/1.69.0: Generated 131 packages. All logs here
boost/1.70.0: Generated 131 packages. All logs here
boost/1.71.0: Generated 131 packages. All logs here
boost/1.72.0: Generated 131 packages. All logs here
boost/1.73.0: Generated 131 packages. All logs here
boost/1.74.0: Generated 131 packages. All logs here
boost/1.75.0: Generated 131 packages. All logs here

garethsb · 2021-01-05T18:13:11Z

After this PR, when GitHub Actions are building on macOS, I see a new failure:

2021-01-05T11:19:55.3633560Z boost/1.72.0: WARN: Boost component 'fiber' is missing libraries. Try building boost with '-o boost:without_fiber'.
2021-01-05T11:19:55.3634940Z boost/1.72.0: WARN: Boost component 'fiber_numa' is missing libraries. Try building boost with '-o boost:without_fiber_numa'.
2021-01-05T11:19:55.3635970Z ERROR: boost/1.72.0: Error in package_info() method, line 1331
2021-01-05T11:19:55.3636810Z 	raise ConanException("These libraries were expected to be built, but were not built: {}".format(non_built))
2021-01-05T11:19:55.3638230Z 	ConanException: These libraries were expected to be built, but were not built: {'boost_fiber_numa', 'boost_fiber'}

Previously, as the description of this PR says, the recipe allowed missing libraries, understanding that Boost.Build would do the right thing for the platform.

I understand the rationale for being "explicit/strict about adding libraries", but this PR means that in order to build at all I have to exclude Boost.Fiber with:

[options]
boost:without_fiber=True

and that means a custom build always, not just a download, on all platforms.

The custom build would at least be efficient if I could easily specify just with_ options for the three or four Boost libraries I actually need, but the recipe only provides the without_ variants defaulting to False.

Any ideas?

prince-chrismc · 2021-01-05T21:00:36Z

~~Can you share the link to the action run? Might be an issue with the profile you are running.~~

Are you referring to this? https://github.com/sony/nmos-cpp/runs/1649513648?check_suite_focus=true#step:20:137

In your logs it's wants boost/1.72.0:94cf772abbc62fdba36047acf49db3d6d9235ddb - Build but that package ID does not exist in CCI

https://c3i.jfrog.io/artifactory/misc/logs/pr/3999/9/boost/1.72.0/94cf772abbc62fdba36047acf49db3d6d9235ddb-build.txt shows the library being built

But this failed to build according to the logs! 😖 //cc @jgsogo @danimtb I think there are missing packages here

I do not see this revision added for boost/1.75.0 (at least there's no numa option available) on the website

Running a search I get the following Package_ID: d8e8e6181ea3a679ea2441e9703270817233cdf4 (full output attached) which matches your profile but the wrong recipe revision.

You might want to consider using recipe revisions, #3890 (comment) to avoid these kind of issues

conan-boost-macos-packages.txt

madebr · 2021-01-05T22:55:44Z

@garethsb-sony
The Macos aspect is kind of a black spot for me (I only have Linux+Windows).
There is #3977 trying to find the correct settings/configuration for Macos.

garethsb · 2021-01-06T16:00:02Z

~~Can you share the link to the action run? Might be an issue with the profile you are running.~~

Are you referring to this? https://github.com/sony/nmos-cpp/runs/1649513648?check_suite_focus=true#step:20:137

I was referring to that run; the build error I mentioned is a way down, here:

https://github.com/sony/nmos-cpp/runs/1649513648?check_suite_focus=true#step:20:16982

You might want to consider using recipe revisions, #3890 (comment) to avoid these kind of issues

Thanks, @prince-chrismc, that does look helpful... more stuff to learn!

garethsb · 2021-01-06T16:05:31Z

How about this:

The custom build would at least be efficient if I could easily specify just with_ options for the three or four Boost libraries I actually need, but the recipe only provides the without_ variants defaulting to False.

Have I missed a way of specifying only the components I need inclusively rather than specifying the ones I don't need?

prince-chrismc · 2021-01-06T16:31:01Z

Issue was also reported #4097

boost: be more strict about boost libraries

d55f01f

conan-center-bot added the Failed label Dec 26, 2020

boost: libs of deps_info needs to be a list

aa40beb

boost: give clemency to stacktrace_backtrace

6a358ef

boost: disable shared numa on MSVC + prefix pkg_config names with boost_

e00ca36

madebr mentioned this pull request Dec 27, 2020

[package] boost/1.75.0: Build error for iOS on Mac #3992

Closed

conan-center-bot removed the Failed label Dec 27, 2020

github-actions bot mentioned this pull request Dec 27, 2020

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

prince-chrismc previously approved these changes Dec 27, 2020

View reviewed changes

madebr commented Dec 27, 2020

View reviewed changes

madebr added 2 commits December 28, 2020 00:00

boost: print suggestion when missing component(s) in package_info

c7c6a0e

boost: set CXX_STANDARD for some boost components in test_package

d3d719c

madebr dismissed prince-chrismc’s stale review via d3d719c December 27, 2020 23:00

conan-center-bot added the Failed label Dec 28, 2020

boost: boost_stacktrace_basic and boost_stacktrace_addr2line both dep…

2aaa63a

…end on addr2line

boost: ignore boost_stacktrace_windbg_cached on non-Windows builds

cc2b8b4

conan-center-bot removed the Failed label Dec 29, 2020

SSE4 requested a review from uilianries December 29, 2020 07:55

uilianries reviewed Dec 29, 2020

View reviewed changes

recipes/boost/all/conanfile.py Outdated Show resolved Hide resolved

uilianries reviewed Dec 29, 2020

View reviewed changes

recipes/boost/all/conanfile.py Outdated Show resolved Hide resolved

boost: throw ConanException instead of RuntimeError

840b7ce

Co-authored-by: Uilian Ries <uilianries@gmail.com>

prince-chrismc approved these changes Dec 29, 2020

View reviewed changes

conan-center-bot added the Unexpected Error label Dec 29, 2020

madebr closed this Dec 30, 2020

madebr reopened this Dec 30, 2020

conan-center-bot removed the Unexpected Error label Dec 30, 2020

uilianries approved these changes Dec 30, 2020

View reviewed changes

SSE4 approved these changes Jan 2, 2021

View reviewed changes

conan-center-bot merged commit 552189c into conan-io:master Jan 2, 2021

madebr deleted the boost_strict branch January 2, 2021 08:48

dmn-star mentioned this pull request Jan 6, 2021

[package] boost/1.75.0: Missing libraries: boost_fiber, boost_nowide, boost_fiber_numa, boost_json #4097

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

boost: be more strict about boost libraries #3999

boost: be more strict about boost libraries #3999

madebr commented Dec 26, 2020 •

edited

Loading

ghost commented Dec 26, 2020

conan-center-bot commented Dec 26, 2020

conan-center-bot commented Dec 26, 2020

conan-center-bot commented Dec 27, 2020

conan-center-bot commented Dec 27, 2020

madebr Dec 27, 2020

conan-center-bot commented Dec 28, 2020

conan-center-bot commented Dec 28, 2020

conan-center-bot commented Dec 29, 2020

conan-center-bot commented Dec 29, 2020

conan-center-bot commented Dec 30, 2020

garethsb commented Jan 5, 2021

prince-chrismc commented Jan 5, 2021

madebr commented Jan 5, 2021

garethsb commented Jan 6, 2021

garethsb commented Jan 6, 2021

prince-chrismc commented Jan 6, 2021

		if self.settings.compiler == "Visual Studio" and self.options.shared and self.options.numa:
		raise ConanInvalidConfiguration("Cannot build a shared boost with numa support on Visual Studio")

boost: be more strict about boost libraries #3999

boost: be more strict about boost libraries #3999

Conversation

madebr commented Dec 26, 2020 • edited Loading

ghost commented Dec 26, 2020

conan-center-bot commented Dec 26, 2020

conan-center-bot commented Dec 26, 2020

conan-center-bot commented Dec 27, 2020

conan-center-bot commented Dec 27, 2020

madebr Dec 27, 2020

Choose a reason for hiding this comment

conan-center-bot commented Dec 28, 2020

conan-center-bot commented Dec 28, 2020

conan-center-bot commented Dec 29, 2020

conan-center-bot commented Dec 29, 2020

conan-center-bot commented Dec 30, 2020

garethsb commented Jan 5, 2021

prince-chrismc commented Jan 5, 2021

madebr commented Jan 5, 2021

garethsb commented Jan 6, 2021

garethsb commented Jan 6, 2021

prince-chrismc commented Jan 6, 2021

madebr commented Dec 26, 2020 •

edited

Loading