Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost: fix i18n_backend=icu support for version 1.7{1,2,3}.0 #1704

Closed
wants to merge 3 commits into from

Conversation

ledocc
Copy link
Contributor

@ledocc ledocc commented May 22, 2020

Specify library name and version: boost/1.7{1,2,3}.0

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'boost/1.69.0' failed in build 1 (547c997bcb07d0013539da03b4e9f6a91a35b3b6):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'boost/1.69.0' failed in build 2 (f2781e87e24b2e2f365e6f40cbd4277179f7cc86):

@ledocc ledocc force-pushed the feature/icu_support branch from f2781e8 to 37cc2b8 Compare May 25, 2020 10:06
@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

1 similar comment
@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@conan-center-bot
Copy link
Collaborator

All green in build 5 (213e2c7e8d83057acc22f9508b5b59f2bf6468ca)! 😊

@jgsogo
Copy link
Contributor

jgsogo commented May 26, 2020

@ledocc , I would like to know about these patches, are they considered upstream? maybe for 1.74?

@ledocc
Copy link
Contributor Author

ledocc commented May 26, 2020

@jgsogo : for the boost_build patch, I add a PR 582,
for locale and regex, I will propose them when the boostbuild PR was accepted

@jgsogo
Copy link
Contributor

jgsogo commented May 27, 2020

Maybe we should wait a little bit for some feedback from the boost side, just in case they think that the patch need to be modified.

@ghost
Copy link

ghost commented Nov 16, 2020

@stale
Copy link

stale bot commented Dec 17, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocked

possibly fixed by #3872

@ghost ghost mentioned this pull request Dec 26, 2020
4 tasks
@SSE4
Copy link
Contributor

SSE4 commented Jan 2, 2021

@prince-chrismc as #3872 is already merged, do we still need this one?

@prince-chrismc
Copy link
Contributor

@SSE4 I think it's safe to close.

The i18n option works for all platforms even android and apple watches based on the other prs that have been merged

@SSE4 SSE4 closed this Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants