Add VTK/9.0.1 - help needed!

recipes/vtk/all/CMakeLists.txt

@@ -0,0 +1,9 @@
+cmake_minimum_required(VERSION 2.8)
+project(conanvtk)
+
+message(STATUS "Conan CMake Wrapper")
+include(conanbuildinfo.cmake)
+conan_basic_setup()
+
+include_directories(${CMAKE_SOURCE_DIR}/source_subfolder)
+add_subdirectory("source_subfolder")

recipes/vtk/all/conandata.yml

@@ -0,0 +1,10 @@
+sources:
+  "9.0.1":
+    sha256: 9229bf40d4d9a9e4d8a118149cff031b5199cd2cd20df6c41e5da7cd1c7ad23d
+    url: https://github.com/Kitware/VTK/archive/v9.0.1.tar.gz
+patches:
+  "8.2.0":
+    - patch_file: "patches/vtknetcdf_snprintf.patch"
+      base_path: "source_subfolder"
+    - patch_file: "patches/vtktiff_mangle.patch"
+      base_path: "source_subfolder"

recipes/vtk/all/conanfile.py

@@ -0,0 +1,176 @@
+import os
+import re
+import shutil
+
+from fnmatch import fnmatch
+from conans import ConanFile, CMake, tools
+
+class VTKConan(ConanFile):
+    name = "vtk"
+    version = "9.0.1"
+    url = "https://github.com/conan-io/conan-center-index"
+    homepage = "https://vtk.org/"
+    license = "BSD license"
+    description = "Visualization Toolkit by Kitware"
+    generators = "cmake"
+    settings = "os", "arch", "compiler", "build_type"
+    exports_sources = ["CMakeLists.txt", "patches/**"]
+    source_subfolder = "source_subfolder"
+    options = {"shared": [True, False], "qt": [True, False], "mpi": [True, False],
+                "fPIC": [True, False], "minimal": [True, False], "ioxml": [True, False],
+                "ioexport": [True, False], "mpi_minimal": [True, False]}
+    default_options = {"shared": False, "qt": False, "mpi": False, "fPIC": False,
+                "minimal": False, "ioxml": False, "ioexport": False, "mpi_minimal": False}
+    topics = ("conan", "VTK", "3D rendering", "2D plotting", "3D interaction", "3D manipulation", 
+                "graphics", "image processing", "scientific visualization", "geometry modeling")
+    short_paths = True
+
+    version_split = version.split('.')
+    short_version = "{}.{}".format(version_split[0], version_split[1])
+
+    def source(self):
+        tools.get(**self.conan_data["sources"][self.version])
+        os.rename("{}-{}".format(self.name, self.version), self.source_subfolder)
+
+    def requirements(self):
+        if self.options.qt:
+            self.requires("qt/5.15.1@bincrafters/stable")
+            self.options["qt"].shared = True
+            if tools.os_info.is_linux:
+                self.options["qt"].qtx11extras = True
+
+    def _system_package_architecture(self):
+        if tools.os_info.with_apt:
+            if self.settings.arch == "x86":
+                return ':i386'
+            elif self.settings.arch == "x86_64":
+                return ':amd64'
+
+        if tools.os_info.with_yum:
+            if self.settings.arch == "x86":
+                return '.i686'
+            elif self.settings.arch == 'x86_64':
+                return '.x86_64'
+        return ""
+
+    def build_requirements(self):
+        pack_names = None
+        if not self.options.minimal and tools.os_info.is_linux:
+            if tools.os_info.with_apt:
+                pack_names = [
+                    "freeglut3-dev",
+                    "mesa-common-dev",
+                    "mesa-utils-extra",
+                    "libgl1-mesa-dev",
+                    "libglapi-mesa",
+                    "libsm-dev",
+                    "libx11-dev",
+                    "libxext-dev",
+                    "libxt-dev",
+                    "libglu1-mesa-dev"]
+
+        if pack_names:
+            installer = tools.SystemPackageTool()
+            for item in pack_names:
+                installer.install(item + self._system_package_architecture())
+
+    def config_options(self):
+        if self.settings.compiler == "Visual Studio":
+            del self.options.fPIC
+
+    def _configure_cmake(self):
+        cmake = CMake(self)
+        cmake.definitions["BUILD_TESTING"] = "OFF"
+        cmake.definitions["BUILD_EXAMPLES"] = "OFF"
+        cmake.definitions["BUILD_SHARED_LIBS"] = self.options.shared
+
+        if self.options.minimal:
+            cmake.definitions["VTK_Group_StandAlone"] = "OFF"
+            cmake.definitions["VTK_Group_Rendering"] = "OFF"
+        if self.options.ioxml:
+            cmake.definitions["Module_vtkIOXML"] = "ON"
+        if self.options.ioexport:
+            cmake.definitions["Module_vtkIOExport"] = "ON"
+        if self.options.qt:
+            cmake.definitions["VTK_Group_Qt"] = "ON"
+            cmake.definitions["VTK_QT_VERSION"] = "5"
+            cmake.definitions["VTK_BUILD_QT_DESIGNER_PLUGIN"] = "OFF"
+        if self.options.mpi:
+            cmake.definitions["VTK_Group_MPI"] = "ON"
+            cmake.definitions["Module_vtkIOParallelXML"] = "ON"
+        if self.options.mpi_minimal:
+            cmake.definitions["Module_vtkIOParallelXML"] = "ON"
+            cmake.definitions["Module_vtkParallelMPI"] = "ON"
+
+        if self.settings.os == 'Macos':
+            self.env['DYLD_LIBRARY_PATH'] = os.path.join(self.build_folder, 'lib')
+            self.output.info("cmake build: %s" % self.build_folder)
+
+        cmake.configure(build_folder='build')
+        return cmake
+
+    def build(self):
+        for patch in self.conan_data.get("patches", {}).get(self.version, []):
+            tools.patch(**patch)
+
+        cmake = self._configure_cmake()
+        cmake.build()
+
+    def package(self):
+        cmake = self._configure_cmake()
+        cmake.install()
+
+        # "$\package\lib\vtk" contains "hierarchy\conanvtk\" and a lot of *.txt files in it.
+        shutil.rmtree(os.path.join(self.package_folder, 'lib', 'vtk')) #
+        # "$\package\lib\cmake" contains a lot of *.cmake files. conan-center HOOK disallow *.cmake files in package.
+        shutil.rmtree(os.path.join(self.package_folder, 'lib', 'cmake'))
+        # Licences are created in "$\package\share\licenses\conanvtk\" while their must be in "$\package\licenses\"
+        os.rename(os.path.join(self.package_folder, 'share', 'licenses', 'conanvtk'), os.path.join(self.package_folder, 'licenses'))
+        shutil.rmtree(os.path.join(self.package_folder, 'share'))
+
+    # GCC static linking require providing libraries in appropriate order.
+    # Below "order" is not necessary is correct (couldn't find the correct one), but it is used as good starting point.
+    def _sort_libs(self, libs):
+        if self.settings.compiler != "gcc":
+            return libs
+        libs_ordered = []
+        print('VTK libs before sort: ' + (';'.join(libs)))
+        order = ['vtkViewsCore', 'vtkViewsContext2D', 'vtkRenderingVolumeOpenGL2', 'vtkRenderingContextOpenGL2', 'vtkRenderingContext2D', 'vtkRenderingVolume', 'vtkfreetype', 'vtkRenderingFreeType', 'vtkRenderingAnnotation', 'vtkInteractionWidgets', 'vtkInteractionStyle', 'vtkImagingMath', 'vtkImagingHybrid', 'vtkImagingGeneral', 'vtkImagingColor', 'vtkexpat', 'vtkIOXMLParser', 'vtkIOXML', 'vtkIOLegacy', 'vtkIOGeometry', 'vtkgl2ps', 'vtkglew', 'vtkRenderingOpenGL2', 'vtkRenderingGL2PSOpenGL2', 'vtktiff', 'vtkpng', 'vtkjpeg', 'vtkmetaio', 'vtkIOImage', 'vtkIOExport', 'vtkzlib', 'vtkIOCore', 'vtkFiltersModeling', 'vtkFiltersSources', 'vtkRenderingCore', 'vtkImagingSources', 'vtkFiltersHybrid', 'vtkFiltersGeometry', 'vtkalglib', 'vtkImagingCore', 'vtkImagingFourier', 'vtkFiltersStatistics', 'vtkFiltersGeneral', 'vtkFiltersExtraction', 'vtkFiltersCore', 'vtkDICOMParser', 'vtkCommonExecutionModel', 'vtkCommonComputationalGeometry', 'vtkCommonDataModel', 'vtkCommonSystem', 'vtkCommonTransforms', 'vtkCommonMath', 'vtkCommonMisc', 'vtkCommonCore', 'vtkCommonColor', 'vtksys']
+        for item in order:
+            for idx in range(len(libs)): 
+                if item.lower() in libs[idx].lower():
+                    value = libs.pop(idx)
+                    libs_ordered.append(value)
+                    break
+        libs_ordered = libs + libs_ordered # add unordered elements, if any
+        print('VTK libs ordered: ' + (';'.join(libs_ordered)))
+        return libs_ordered
+
+    def package_info(self):
+        self.cpp_info.names["cmake_find_package"] = "VTK"
+        self.cpp_info.names["cmake_find_package_multi"] = "VTK"
+        libs = tools.collect_libs(self)
+        self.cpp_info.libs = self._sort_libs(libs)
+
+        # Adding system libs without 'lib' prefix and '.so' or '.so.X' suffix.
+        if self.settings.os == 'Linux':
+            self.cpp_info.system_libs.append('pthread')
+            self.cpp_info.system_libs.append('dl')            # 'libvtksys-7.1.a' require 'dlclose', 'dlopen', 'dlsym' and 'dlerror' which on CentOS are in 'dl' library
+
+        if not self.options.shared and self.options.qt:
+            if self.settings.os == 'Windows':
+                self.cpp_info.system_libs.append('Ws2_32')    # 'vtksys-9.0d.lib' require 'gethostbyname', 'gethostname', 'WSAStartup' and 'WSACleanup' which are in 'Ws2_32.lib' library
+                self.cpp_info.system_libs.append('Psapi')     # 'vtksys-9.0d.lib' require 'GetProcessMemoryInfo' which is in 'Psapi.lib' library
+                self.cpp_info.system_libs.append('dbghelp')   # 'vtksys-9.0d.lib' require '__imp_SymGetLineFromAddr64', '__imp_SymInitialize' and '__imp_SymFromAddr' which are in 'dbghelp.lib' library
+
+            if self.settings.os == 'Macos':
+                self.cpp_info.frameworks.extend(["CoreFoundation"]) # 'libvtkRenderingOpenGL2-9.0.a' require '_CFRelease', '_CFRetain', '_objc_msgSend' and much more which are in 'CoreFoundation' library
+                self.cpp_info.frameworks.extend(["Cocoa"])          # 'libvtkRenderingOpenGL2-9.0.a' require '_CGWarpMouseCursorPosition' and more, 'libvtkRenderingUI-9.0.a' require '_OBJC_CLASS_$_NSApplication' and more, which are in 'Cocoa' library
+
+        # Why "vtknetcdf" and "vtknetcdfcpp" are treated exceptionally from all other modules?
+        # There are a lot of other *.h in subfolders, should they be directly exposed too?
+        self.cpp_info.includedirs = [
+            "include/vtk-%s" % self.short_version,
+            "include/vtk-%s/vtknetcdf/include" % self.short_version,
+            "include/vtk-%s/vtknetcdfcpp" % self.short_version
+        ]

recipes/vtk/all/patches/vtknetcdf_snprintf.patch

@@ -0,0 +1,12 @@
+diff --git a/ThirdParty/netcdf/vtknetcdf/CMakeLists.txt b/ThirdParty/netcdf/vtknetcdf/CMakeLists.txt
+index daf4a218b84549340006df4e2775fff27a464780..af8c272e7b82f4eee5da69d296ac9eb0bd3547f3 100644
+--- a/ThirdParty/netcdf/vtknetcdf/CMakeLists.txt
++++ b/ThirdParty/netcdf/vtknetcdf/CMakeLists.txt
+@@ -143,6 +143,7 @@ check_symbol_exists("strdup" "string.h" HAVE_STRDUP)
+ check_symbol_exists("strlcat" "string.h" HAVE_STRLCAT)
+ check_symbol_exists("st_blocksize" "sys/stat.h" HAVE_STRUCT_STAT_ST_BLKSIZE)
+ check_symbol_exists("sysconf" "unistd.h" HAVE_SYSCONF)
++check_symbol_exists("snprintf" "stdio.h" HAVE_SNPRINTF)
+
+ set(HAVE_HDF5_H 1)
+ check_symbol_exists("H5free_memory" "vtk_hdf5.h" HDF5_HAS_H5FREE)

recipes/vtk/all/patches/vtktiff_mangle.patch

@@ -0,0 +1,28 @@
+diff --git a/ThirdParty/tiff/vtktiff/libtiff/vtk_tiff_mangle.h b/ThirdParty/tiff/vtktiff/libtiff/vtk_tiff_mangle.h
+index ef121abeab..9f6818d7bc 100644
+--- a/ThirdParty/tiff/vtktiff/libtiff/vtk_tiff_mangle.h
++++ b/ThirdParty/tiff/vtktiff/libtiff/vtk_tiff_mangle.h
+@@ -45,6 +45,7 @@
+ #define TIFFError vtktiff_TIFFError
+ #define TIFFErrorExt vtktiff_TIFFErrorExt
+ #define _TIFFerrorHandler vtktiff__TIFFerrorHandler
++#define _TIFFerrorHandlerExt vtktiff__TIFFerrorHandlerExt
+ #define _TIFFFax3fillruns vtktiff__TIFFFax3fillruns
+ #define TIFFFaxBlackCodes vtktiff_TIFFFaxBlackCodes
+ #define TIFFFaxBlackTable vtktiff_TIFFFaxBlackTable
+@@ -134,6 +135,7 @@
+ #define TIFFNumberOfStrips vtktiff_TIFFNumberOfStrips
+ #define TIFFNumberOfTiles vtktiff_TIFFNumberOfTiles
+ #define TIFFOpen vtktiff_TIFFOpen
++#define TIFFOpenW vtktiff_TIFFOpenW
+ #define TIFFPredictorCleanup vtktiff_TIFFPredictorCleanup
+ #define TIFFPredictorInit vtktiff_TIFFPredictorInit
+ #define _TIFFprintAscii vtktiff__TIFFprintAscii
+@@ -235,6 +237,7 @@
+ #define TIFFWarning vtktiff_TIFFWarning
+ #define TIFFWarningExt vtktiff_TIFFWarningExt
+ #define _TIFFwarningHandler vtktiff__TIFFwarningHandler
++#define _TIFFwarningHandlerExt vtktiff__TIFFwarningHandlerExt
+ #define TIFFWriteBufferSetup vtktiff_TIFFWriteBufferSetup
+ #define TIFFWriteCheck vtktiff_TIFFWriteCheck
+ #define TIFFWriteCustomDirectory vtktiff_TIFFWriteCustomDirectory

recipes/vtk/all/test_package/CMakeLists.txt

@@ -0,0 +1,32 @@
+cmake_minimum_required(VERSION 3.1.3) # 3.1.3 is first fully functional cross-platform version with Targets
+project(test_vtk_package)
+
+set(CMAKE_CXX_STANDARD 11)
+
+include(${CMAKE_BINARY_DIR}/conanbuildinfo.cmake)
+conan_basic_setup(TARGETS)
+
+add_executable(${PROJECT_NAME} test_package.cpp)
+target_link_libraries(${PROJECT_NAME} CONAN_PKG::vtk)
+
+# From oryginal recipe
+# if(UNIX AND NOT APPLE)
+#     TARGET_LINK_LIBRARIES(${PROJECT_NAME} m)
+# endif()
+
+
+#############################
+# Below is working test for "cmake_find_package_multi" generator (above is for "cmake" generator).
+#
+# cmake_minimum_required(VERSION 3.1.3) # 3.1.3 is first fully functional cross-platform version with Targets
+#
+# set(CMAKE_CXX_STANDARD 11)
+#
+# project(test_vtk_package)
+#
+# find_package(VTK REQUIRED CONFIG)
+#
+# add_executable(${PROJECT_NAME} test_package.cpp)
+# target_link_libraries(${PROJECT_NAME} VTK::VTK)
+#
+

recipes/vtk/all/test_package/conanfile.py

@@ -0,0 +1,17 @@
+import os
+from conans import ConanFile, CMake, tools, RunEnvironment
+
+class TestVTKConan(ConanFile):
+    settings = "os", "compiler", "arch", "build_type"
+    generators = "cmake" # Replace "cmake" by "cmake_find_package_multi" to test multi
+
+    def build(self):
+        cmake = CMake(self)
+        cmake.configure()
+        cmake.build()
+
+    def test(self):
+        # Replace "bin" by "Debug" on Win or by "." (dot) on Mac for "cmake_find_package_multi"
+        bin_path = os.path.join("bin", "test_vtk_package")
+        # Lnx: self.run("LD_LIBRARY_PATH=%s %s" % (os.environ.get('LD_LIBRARY_PATH', ''), bin_path), run_environment=True)
+        self.run(bin_path, run_environment=True)

recipes/vtk/all/test_package/test_package.cpp

@@ -0,0 +1,31 @@
+#include <vtkSortDataArray.h>
+#include <vtkDoubleArray.h>
+#include <vtkIntArray.h>
+#include <vtkSmartPointer.h>
+
+int main(int, char *[])
+{
+    vtkSmartPointer<vtkDoubleArray> valueArray = vtkSmartPointer<vtkDoubleArray>::New();
+    valueArray->InsertNextValue(20.0);
+    valueArray->InsertNextValue(10.0);
+    valueArray->InsertNextValue(30.0);
+
+    vtkSmartPointer<vtkIntArray> keyArray = vtkSmartPointer<vtkIntArray>::New();
+    keyArray->InsertNextValue(1);
+    keyArray->InsertNextValue(0);
+    keyArray->InsertNextValue(2);
+
+    std::cout << "Unsorted: " << valueArray->GetValue(0) << " "
+              << valueArray->GetValue(1) << " "
+              << valueArray->GetValue(2) << std::endl;
+
+    // Sort the array
+    vtkSmartPointer<vtkSortDataArray> sortDataArray = vtkSmartPointer<vtkSortDataArray>::New();
+    sortDataArray->Sort(keyArray, valueArray);
+
+    std::cout << "Sorted: " << valueArray->GetValue(0) << " "
+              << valueArray->GetValue(1) << " "
+              << valueArray->GetValue(2) << std::endl;
+
+    return EXIT_SUCCESS;
+}

recipes/vtk/config.yml

@@ -0,0 +1,3 @@
+versions:
+  "9.0.1":
+    folder: all