Add VTK/9.0.1 - help needed! #3280

atrelinski · 2020-10-20T18:12:29Z

Specify library name and version: vtk/9.0.1

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

…framework. Before first time build trial

…HOOK errors. Package not tested yet.

…ssfully, test test_package successful (no HOOK errors/warnings)

…eported.

…ind_package_multi" generators. Lnx not checked

CLAassistant · 2020-10-20T18:12:33Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

atrelinski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

atrelinski · 2020-10-20T18:48:43Z

Not sure why CLA is pending while I've signed it (after fixing commit email address)
Also I can't sign it second time, and recheck it doesn't work for me.
Please help

recipes/vtk/all/conanfile.py

conan-center-bot · 2020-10-29T05:18:55Z

All green in build 21 (9bf7762c3837bff942ecc022ba9613a770d4a028)! 😊

vtk/9.0.1: Generated 124 packages. All logs here

atrelinski · 2020-10-31T19:02:41Z

madebr, thank You for analysis!
It definitely move thing forward!,
unfortunately probably it will take a while to address all of that :(

stale · 2020-12-01T13:04:49Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

atrelinski · 2020-12-10T06:22:02Z

It looks like, I won't find more time to improve recipe :(

For those who would like to improve VTK 9.0.1 recipe or use it here is link to it:
https://github.com/atrelinski/conan-vtk/tree/stable/9.0.1

taoyouh · 2021-01-04T13:05:12Z

@madebr

I found that the 3rd-party libraries contained in VTK are modified special versions. The symbols are changed so that it should not conflict with the packages directly used by the user.

Is it still necessary to use the cci version of those packages?

jgsogo · 2021-01-25T14:45:46Z

Hi, @atrelinski

I see the license/cla is pending. I feel like there is nothing we can do on our side if the notification from the license/app doesn't arrive... maybe the easiest way for you is to close this PR and open a new one with these same changes.

prince-chrismc · 2021-01-30T03:29:46Z

recipes/vtk/all/conanfile.py

+            # FIXME: Missing qt recipe. Qt recipe PR: https://github.com/conan-io/conan-center-index/pull/1759
+            # When qt available, "self.requires("qt/5.15.1")" should replace below line.
+            raise ConanInvalidConfiguration("qt is not (yet) available on conan-center-index")


It was merged 🎉

prince-chrismc · 2021-01-30T03:29:58Z

recipes/vtk/all/conanfile.py

+        if self.options.group_rendering:
+            self.requires("opengl/system")
+        if self.options.module_ioxdmf3:
+            self.requires("boost/1.74.0")


Suggested change

self.requires("boost/1.74.0")

self.requires("boost/1.75.0")

prince-chrismc · 2021-01-30T03:30:33Z

recipes/vtk/all/conanfile.py

+        self._cmake = CMake(self)
+        self._cmake.definitions["BUILD_TESTING"] = "OFF"
+        self._cmake.definitions["BUILD_EXAMPLES"] = "OFF"
+        self._cmake.definitions["BUILD_SHARED_LIBS"] = "ON" if self.options.shared else "OFF"


Conan handles the translation

Suggested change

self._cmake.definitions["BUILD_SHARED_LIBS"] = "ON" if self.options.shared else "OFF"

self._cmake.definitions["BUILD_SHARED_LIBS"] = self.options.shared

I see elsewhere it's very strict... is that the case here?

prince-chrismc · 2021-01-30T03:32:17Z

recipes/vtk/all/conanfile.py

+        for module in self._modules:
+            # Defines shouldn't be left uninitalized, however VTK has so many _modules, that
+            # it ends up as "The command line is too long." error on Windows.
+            if self.options.get_safe("module_{}".format(module.lower()), default=False):


Suggested change

if self.options.get_safe("module_{}".format(module.lower()), default=False):

# FIXME: remove top level if

if self.options.get_safe("module_{}".format(module.lower()), default=False):

prince-chrismc · 2021-01-30T03:33:01Z

recipes/vtk/all/conanfile.py

+    def build(self):
+        if self.options.group_qt:
+            if self.options["qt"].shared == False:
+                raise ConanInvalidConfiguration("VTK option 'group_qt' requires 'qt:shared=True'")
+            if self.settings.os == "Linux":
+                if self.options["qt"].qtx11extras == False:
+                    raise ConanInvalidConfiguration("VTK option 'group_qt' requires 'qt:qtx11extras=True'")


Suggested change

def build(self):

if self.options.group_qt:

if self.options["qt"].shared == False:

raise ConanInvalidConfiguration("VTK option 'group_qt' requires 'qt:shared=True'")

if self.settings.os == "Linux":

if self.options["qt"].qtx11extras == False:

raise ConanInvalidConfiguration("VTK option 'group_qt' requires 'qt:qtx11extras=True'")

def validate(self):

if self.options.group_qt:

if self.options["qt"].shared == False:

raise ConanInvalidConfiguration("VTK option 'group_qt' requires 'qt:shared=True'")

if self.settings.os == "Linux":

if self.options["qt"].qtx11extras == False:

raise ConanInvalidConfiguration("VTK option 'group_qt' requires 'qt:qtx11extras=True'")

def build(self):

prince-chrismc · 2021-01-30T03:34:30Z

recipes/vtk/all/conanfile.py

+        if self.settings.compiler != "gcc":
+            return libs
+        libs_ordered = []
+        print('VTK libs before sort: ' + (';'.join(libs)))


There is a self.output.info for the conan-ization of print

prince-chrismc · 2021-01-30T03:35:12Z

recipes/vtk/all/conanfile.py

+
+        if not self.options.shared and self.options.group_qt:
+            if self.settings.os == 'Windows':
+                self.cpp_info.system_libs.append('Ws2_32')    # 'vtksys-9.0d.lib' require 'gethostbyname', 'gethostname', 'WSAStartup' and 'WSACleanup' which are in 'Ws2_32.lib' library


Suggested change

self.cpp_info.system_libs.append('Ws2_32') # 'vtksys-9.0d.lib' require 'gethostbyname', 'gethostname', 'WSAStartup' and 'WSACleanup' which are in 'Ws2_32.lib' library

self.cpp_info.system_libs.append('ws2_32') # 'vtksys-9.0d.lib' require 'gethostbyname', 'gethostname', 'WSAStartup' and 'WSACleanup' which are in 'Ws2_32.lib' library

prince-chrismc · 2021-01-30T03:36:03Z

recipes/vtk/all/conanfile.py

+        version_split = self.version.split('.')
+        short_version = "{}.{}".format(version_split[0], version_split[1])


Suggested change

version_split = self.version.split('.')

short_version = "{}.{}".format(version_split[0], version_split[1])

version = tools.Version(self.version)

short_version = "{}.{}".format(version.major, version.minor)

prince-chrismc · 2021-01-30T03:37:30Z

recipes/vtk/all/conanfile.py

+        # Why "vtknetcdf" and "vtknetcdfcpp" are treated exceptionally from all other _modules?
+        # There are a lot of other *.h in subfolders, should they be directly exposed too
+        # or maybe those two should be removed from below?


Is this how the CMake targets are exposed? Maybe put a link?

prince-chrismc

There's at time some fuss about mixing ' and ", being C++ developers there are strong preference for the double quote consistency.

There's a few items I listed above, can you please just make it consistent in your next commit?

prince-chrismc · 2021-01-30T03:42:52Z

You'll need to edit the commit authorship on all of commits to fix the CLA ( or just squash and force push )

There is no GitHub account associated to the email that the commits are being made against ( it needs to match the account you are using to open the PR )

conan-center-bot · 2021-03-07T20:37:45Z

Failure in build 22 (9bf7762c3837bff942ecc022ba9613a770d4a028):

vtk/9.0.1@:
CI failed to create some packages (All logs)

Logs for packageID efcd8bcea0e221bbd14c0dc9e532611086ae4385:

[settings]
arch=x86_64
arch_build=x86_64
build_type=Debug
compiler=clang
compiler.libcxx=libstdc++
compiler.version=11
os=Linux
os_build=Linux
[options]
vtk:shared=False

[ 15%] Building C object source_subfolder/ThirdParty/libproj/vtklibproj/src/CMakeFiles/libproj.dir/pj_strerrno.c.o
[ 15%] Building C object source_subfolder/ThirdParty/libproj/vtklibproj/src/CMakeFiles/libproj.dir/pj_transform.c.o
[ 15%] Building C object source_subfolder/ThirdParty/libproj/vtklibproj/src/CMakeFiles/libproj.dir/pj_tsfn.c.o
[ 15%] Building C object source_subfolder/ThirdParty/libproj/vtklibproj/src/CMakeFiles/libproj.dir/pj_units.c.o
[ 15%] Building C object source_subfolder/ThirdParty/libproj/vtklibproj/src/CMakeFiles/libproj.dir/pj_utils.c.o
[ 15%] Building C object source_subfolder/ThirdParty/libproj/vtklibproj/src/CMakeFiles/libproj.dir/pj_zpoly1.c.o
[ 15%] Building C object source_subfolder/ThirdParty/libproj/vtklibproj/src/CMakeFiles/libproj.dir/proj_mdist.c.o
[ 15%] Building C object source_subfolder/ThirdParty/libproj/vtklibproj/src/CMakeFiles/libproj.dir/proj_rouss.c.o
[ 15%] Building C object source_subfolder/ThirdParty/libproj/vtklibproj/src/CMakeFiles/libproj.dir/rtodms.c.o
[ 15%] Building C object source_subfolder/ThirdParty/libproj/vtklibproj/src/CMakeFiles/libproj.dir/vector1.c.o
[ 15%] Building C object source_subfolder/ThirdParty/libproj/vtklibproj/src/CMakeFiles/libproj.dir/pj_strtod.c.o
[ 15%] Linking C static library ../../../../../lib/libvtklibproj-9.0.a
[ 15%] Built target libproj
Makefile:148: recipe for target 'all' failed
vtk/9.0.1: 
CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_EXAMPLES
    CMAKE_EXPORT_NO_PACKAGE_REGISTRY


/home/conan/w/BuildSingleReference/.conan/data/vtk/9.0.1/_/_/build/efcd8bcea0e221bbd14c0dc9e532611086ae4385/source_subfolder/ThirdParty/gl2ps/vtkgl2ps/gl2ps.c:4408:17: warning: implicit conversion from 'unsigned long' to 'double' changes value from 18446744073709551614 to 18446744073709551616 [-Wimplicit-const-int-float-conversion]
  double dmax = ~1UL;
         ~~~~   ^~~~
/home/conan/w/BuildSingleReference/.conan/data/vtk/9.0.1/_/_/build/efcd8bcea0e221bbd14c0dc9e532611086ae4385/source_subfolder/ThirdParty/gl2ps/vtkgl2ps/gl2ps.c:4451:17: warning: implicit conversion from 'unsigned long' to 'double' changes value from 18446744073709551614 to 18446744073709551616 [-Wimplicit-const-int-float-conversion]
  double dmax = ~1UL;
         ~~~~   ^~~~
/home/conan/w/BuildSingleReference/.conan/data/vtk/9.0.1/_/_/build/efcd8bcea0e221bbd14c0dc9e532611086ae4385/source_subfolder/ThirdParty/gl2ps/vtkgl2ps/gl2ps.c:4476:17: warning: implicit conversion from 'unsigned long' to 'double' changes value from 18446744073709551614 to 18446744073709551616 [-Wimplicit-const-int-float-conversion]
  double dmax = ~1UL;
         ~~~~   ^~~~
3 warnings generated.
../../../lib/libvtkWrappingTools-9.0.a(vtkParse.tab.c.o):/home/conan/w/BuildSingleReference/.conan/data/vtk/9.0.1/_/_/build/efcd8bcea0e221bbd14c0dc9e532611086ae4385/source_subfolder/Wrapping/Tools/vtkParse.tab.c:224: multiple definition of `currentFunction'
CMakeFiles/WrapJava.dir/vtkWrapJava.c.o:/home/conan/w/BuildSingleReference/.conan/data/vtk/9.0.1/_/_/build/efcd8bcea0e221bbd14c0dc9e532611086ae4385/source_subfolder/Wrapping/Tools/vtkWrapJava.c:28: first defined here
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [bin/vtkWrapJava-9.0] Error 1
make[1]: *** [source_subfolder/Wrapping/Tools/CMakeFiles/WrapJava.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
../../../lib/libvtkWrappingTools-9.0.a(vtkParse.tab.c.o):/home/conan/w/BuildSingleReference/.conan/data/vtk/9.0.1/_/_/build/efcd8bcea0e221bbd14c0dc9e532611086ae4385/source_subfolder/Wrapping/Tools/vtkParse.tab.c:224: multiple definition of `currentFunction'
CMakeFiles/ParseJava.dir/vtkParseJava.c.o:/home/conan/w/BuildSingleReference/.conan/data/vtk/9.0.1/_/_/build/efcd8bcea0e221bbd14c0dc9e532611086ae4385/source_subfolder/Wrapping/Tools/vtkParseJava.c:28: first defined here
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [bin/vtkParseJava-9.0] Error 1
make[1]: *** [source_subfolder/Wrapping/Tools/CMakeFiles/ParseJava.dir/all] Error 2
make: *** [all] Error 2
vtk/9.0.1: WARN: Build folder is dirty, removing it: /home/conan/w/BuildSingleReference/.conan/data/vtk/9.0.1/_/_/build/efcd8bcea0e221bbd14c0dc9e532611086ae4385
vtk/9.0.1: ERROR: Package 'efcd8bcea0e221bbd14c0dc9e532611086ae4385' build failed
vtk/9.0.1: WARN: Build folder /home/conan/w/BuildSingleReference/.conan/data/vtk/9.0.1/_/_/build/efcd8bcea0e221bbd14c0dc9e532611086ae4385
ERROR: vtk/9.0.1: Error in build() method, line 307
	cmake.build()
	ConanException: Error 2 while executing cmake --build '/home/conan/w/BuildSingleReference/.conan/data/vtk/9.0.1/_/_/build/efcd8bcea0e221bbd14c0dc9e532611086ae4385/build' '--' '-j3'

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

stale · 2021-04-06T22:17:44Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2021-05-06T22:54:21Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

poretga99 · 2023-04-01T20:03:53Z

I would like to continue work on VTK recipe.
Should new PR be opened for this?

prince-chrismc · 2023-04-05T21:44:40Z

Please submit a PR !

atrelinski added 16 commits October 18, 2020 21:36

First round

6cd1ec1

All files should be in place, with very raw adoption to conan-center …

d5135a2

…framework. Before first time build trial

Fixes after applying conan-center hooks

fd99fd6

First fixes in way to successful build

156531b

First successful Win VS2019 Release local build, unfortunatelly with …

7c8d52c

…HOOK errors. Package not tested yet.

Fixing test_package project

4211f48

Fix HOOK errors

61ebafe

Eliminating next HOOK errors. Status: Builds (with HOOK errors) succe…

85609fa

…ssfully, test test_package successful (no HOOK errors/warnings)

First fully successful Win Release build package and test!!!!

14c305b

Win local Debug build + test_package successful. No errors by HOOKs r…

c098c80

…eported.

Polishing

36ba6ba

Implement "cmake_find_package_multi" generator

9138937

Fixing comments

18e1202

Remove revision_mode = "scm" - make recipe more universal

636c5e0

Fix/Polish Mac

799fa9a

Win and Mac should be fully functional with both "cmake" and "cmake_f…

37ac2e3

…ind_package_multi" generators. Lnx not checked

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Oct 20, 2020

Dummy change to have signed commit

9b14b7d

This comment has been minimized.

Sign in to view

Remove range in self.requires()

6afdbef