Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xz_utils: honor static runtime for clang-cl #25197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Sep 9, 2024

Summary

Changes to recipe: lib/[version]

Motivation

In case of a profile representing clang-cl with static runtime, runtime is not honored. This PR fixes it.

Details

see #25014 (comment)


@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (51a52796c0950166285623a0652acb445a417861):

  • xz_utils/5.4.5:
    All packages built successfully! (All logs)

  • xz_utils/5.4.0:
    All packages built successfully! (All logs)

  • xz_utils/5.4.4:
    All packages built successfully! (All logs)

  • xz_utils/5.2.5:
    All packages built successfully! (All logs)

  • xz_utils/5.4.2:
    All packages built successfully! (All logs)

  • xz_utils/5.2.10:
    All packages built successfully! (All logs)

  • xz_utils/5.2.4:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (51a52796c0950166285623a0652acb445a417861):

  • xz_utils/5.4.5:
    All packages built successfully! (All logs)

  • xz_utils/5.4.0:
    All packages built successfully! (All logs)

  • xz_utils/5.4.2:
    All packages built successfully! (All logs)

  • xz_utils/5.2.5:
    All packages built successfully! (All logs)

  • xz_utils/5.2.10:
    All packages built successfully! (All logs)

  • xz_utils/5.2.4:
    All packages built successfully! (All logs)

  • xz_utils/5.4.4:
    All packages built successfully! (All logs)

@jcar87 jcar87 self-assigned this Sep 11, 2024
@jcar87
Copy link
Contributor

jcar87 commented Jan 9, 2025

runtime is not honored.

For this profile and without changes from this PR:

Profile host:
[settings]
arch=armv8
build_type=Release
compiler=clang
compiler.cppstd=17
compiler.runtime=static
compiler.runtime_type=Release
compiler.runtime_version=v144
compiler.version=17
os=Windows
[conf]
tools.cmake.cmaketoolchain:generator=Visual Studio 17

I can se the /MT flag being passed correctly (and the test package passing, otherwise I imagine it would fail with the mismatch)

The /MT flag is correctly set by the Conan-generated .props - so while it is building the pre-existing configuration that doesn't have MT in the name - it is actually correctly obeying the Conan-passed settings - may be that the solution here is to just disregard that block altogether

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants