xz-utils: support armv8 and clang-cl on Windows #25014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
previously approved these changes
Aug 22, 2024
| @@ -124,16 +131,23 @@ def _build_msvc(self): | |||
| "<Import Project=\"$(VCTargetsPath)\\Microsoft.Cpp.targets\" />", | |||
| f"<Import Project=\"{conantoolchain_props}\" /><Import Project=\"$(VCTargetsPath)\\Microsoft.Cpp.targets\" />", | |||
| ) | |||
|
|
|||
| if self.settings.arch == "armv8": | |||
| replace_in_file(self, vcxproj_file, "x64", "ARM64") | |||
|
ARM64 build: |
|
clang-cl build (note that it requires Conan with conan-io/conan#16844 - otherwise it may silently use msvc instead) |
|
And this for the oldest supported version: |
franramirez688
previously approved these changes
Aug 22, 2024
This comment has been minimized.
This comment has been minimized.
jcar87
commented
Aug 22, 2024
AbrilRBS
approved these changes
Aug 22, 2024
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 (
|
franramirez688
approved these changes
Aug 22, 2024
SpaceIm
reviewed
Aug 29, 2024
Comment on lines
+56
to
+59
| assume_clang_cl = (self.settings.os == "Windows" | ||
| and self.settings.compiler == "clang" | ||
| and self.settings.get_safe("compiler.runtime") is not None) | ||
| return is_msvc(self) or assume_clang_cl |
There was a problem hiding this comment.
Can't it be simplified with just self.settings.get_safe("compiler.runtime") is not None?
|
In this recipe, there is also a logic based on I use this kind of trick now: conan-center-index/recipes/fltk/all/conanfile.py Lines 41 to 47 in 7266d08 conan-center-index/recipes/iphreeqc/all/conanfile.py Lines 33 to 39 in 151cf0e conan-center-index/recipes/opencv/4.x/conanfile.py Lines 223 to 229 in 7266d08 |
3 tasks
OMGtechy
pushed a commit
to OMGtechy/conan-center-index
that referenced
this pull request
Dec 31, 2024
* xz-utils: support armv8 and clang-cl on Windows * xz-utils: guard replacement with conditional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Was not previously working.