Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libidn: migrate to Conan v2, add shared MSVC build support #18641

Merged
merged 7 commits into from
Apr 19, 2024
Merged

libidn: migrate to Conan v2, add shared MSVC build support #18641

merged 7 commits into from
Apr 19, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 19, 2023 •
edited
Loading

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@prince-chrismc prince-chrismc mentioned this pull request Jul 24, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@valgur valgur closed this Jul 26, 2023
@valgur valgur reopened this Aug 18, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@toge
Copy link
Contributor

toge commented Sep 24, 2023

@valgur
Could you please run the CI again?
I am very hopeful that your libidn's conan v2 support will work.

@stale stale bot removed the stale label Sep 24, 2023
@valgur valgur closed this Sep 24, 2023
@valgur valgur reopened this Sep 24, 2023
@mayeut mayeut mentioned this pull request Oct 22, 2023
Merged
3 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Oct 23, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@AbrilRBS AbrilRBS self-assigned this Oct 26, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur mentioned this pull request Nov 8, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur changed the title libidn: migrate to Conan v2 libidn: migrate to Conan v2, add shared MSVC build support Dec 8, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 20 (e64a60831f342417133b3cbd9d5f19df5d81bc5f):

  • libidn/1.36:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 21 (e64a60831f342417133b3cbd9d5f19df5d81bc5f):

  • libidn/1.36:
    All packages built successfully! (All logs)

@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit e64a608
libidn/1.36@#d7e03db40820393508d815c043a49be5 
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libidn.dylib, libidn.12.dylib

@cregecambrin
Copy link

Is this PR going to be approved/merged anytime soon? I could use this package.

@valgur
Copy link
Contributor Author

valgur commented Apr 17, 2024

@RubenRBS maybe check out this one as well. Probably similar to the libidn2 one.

AbrilRBS
AbrilRBS approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for also taking the time to fix the Windows support, really appreciated :)

@conan-center-bot conan-center-bot merged commit b547df8 into conan-io:master Apr 19, 2024
13 checks passed
franramirez688 pushed a commit to toge/conan-center-index that referenced this pull request Apr 23, 2024
@valgur @franramirez688
(conan-io#18641) libidn: migrate to Conan v2, add shared MSVC build s…
39cf098 
…upport

* libidn: migrate to Conan v2

* libidn: fix MSVC build

* libidn: --disable-csharp

* libidn: fix shared lib not being found in v1

* libidn: fix MSVC build, add shared MSVC build support

* libidn: tc.extra_cflags.append("-FS")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toge toge toge approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@fdgStilla fdgStilla fdgStilla approved these changes

@uilianries uilianries Awaiting requested review from uilianries

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@valgur @conan-center-bot @toge @AbrilRBS @cregecambrin @fdgStilla @uilianries