Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Googleapis add versions #14240

Closed
wants to merge 5 commits into from
Closed

Conversation

peterSW
Copy link

@peterSW peterSW commented Nov 17, 2022

googleapis cci.20220531, cci.20220618 and cci.20221020

Adding versions of googleapis that match what google-cloud-cpp uses.
google-cloud-cpp currently downloads a copy internally and other dependencies not matching that creates build errors.
I have found the versions added here allow getting google-cloud-cpp versions 2.4.0, 1.42.1 and 1.40.1 working.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@CLAassistant
Copy link

CLAassistant commented Nov 17, 2022

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

This corresponds with what google-cloud-cpp/1.42.1 uses.
@peterSW peterSW force-pushed the googleapis-add-versions branch from 2289f66 to 615df56 Compare November 18, 2022 14:25
@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Nov 29, 2022

I detected other pull requests that are modifying googleapis/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

Failure in build 5 (91f43f57fbfcc482ca68c5eff89b8e229c8f9817):

  • googleapis/cci.20220618@:
    All packages built successfully! (All logs)

  • googleapis/cci.20221020@:
    CI failed to create some packages (All logs)

    Logs for packageID 9c7f1f4c160f05ab583088babe50892aba41fa1c:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=Visual Studio
    compiler.runtime=MD
    compiler.version=15
    os=Windows
    [options]
    googleapis:shared=False
    
    [...]
      route_modifiers.pb.cc
      route_travel_mode.pb.cc
      Building Custom Rule C:/J/w/prod/BuildSingleReference/s/549562/1/CMakeLists.txt
      google_devtools_artifactregistry_v1_artifactregistry_proto.vcxproj -> C:\J\w\prod\BuildSingleReference\s\549562\1\lib\google_devtools_artifactregistry_v1_artifactregistry_proto.lib
      routes_service.pb.cc
      routing_preference.pb.cc
      speed_reading_interval.pb.cc
      toll_info.pb.cc
      toll_passes.pb.cc
      units.pb.cc
      vehicle_emission_type.pb.cc
      Running cpp protocol buffer compiler on C:/J/w/prod/BuildSingleReference/s/549562/1/google/maps/addressvalidation/v1/address.proto
      sensitive_action_payload.pb.cc
      vehicle_info.pb.cc
      waypoint.pb.cc
      google_bigtable_admin_v2_admin_proto.vcxproj -> C:\J\w\prod\BuildSingleReference\s\549562\1\lib\google_bigtable_admin_v2_admin_proto.lib
      Running cpp protocol buffer compiler on C:/J/w/prod/BuildSingleReference/s/549562/1/google/maps/addressvalidation/v1/address_validation_service.proto
      Running cpp protocol buffer compiler on C:/J/w/prod/BuildSingleReference/s/549562/1/google/maps/addressvalidation/v1/geocode.proto
      Running cpp protocol buffer compiler on C:/J/w/prod/BuildSingleReference/s/549562/1/google/maps/addressvalidation/v1/metadata.proto
      Running cpp protocol buffer compiler on C:/J/w/prod/BuildSingleReference/s/549562/1/google/maps/addressvalidation/v1/usps_data.proto
      Building Custom Rule C:/J/w/prod/BuildSingleReference/s/549562/1/CMakeLists.txt
      google_cloud_sensitiveaction_logging_v1_logging_proto.vcxproj -> C:\J\w\prod\BuildSingleReference\s\549562\1\lib\google_cloud_sensitiveaction_logging_v1_logging_proto.lib
      address.pb.cc
      address_validation_service.pb.cc
      geocode.pb.cc
      metadata.pb.cc
      usps_data.pb.cc
      google_maps_routing_v2_routing_proto.vcxproj -> C:\J\w\prod\BuildSingleReference\s\549562\1\lib\google_maps_routing_v2_routing_proto.lib
      google_maps_addressvalidation_v1_addressvalidation_proto.vcxproj -> C:\J\w\prod\BuildSingleReference\s\549562\1\lib\google_maps_addressvalidation_v1_addressvalidation_proto.lib
    googleapis/cci.20221020: 
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_EXPORT_NO_PACKAGE_REGISTRY
        CMAKE_INSTALL_BINDIR
        CMAKE_INSTALL_DATAROOTDIR
        CMAKE_INSTALL_INCLUDEDIR
        CMAKE_INSTALL_LIBDIR
        CMAKE_INSTALL_LIBEXECDIR
        CMAKE_INSTALL_OLDINCLUDEDIR
        CMAKE_INSTALL_SBINDIR
    
    
    googleapis/cci.20221020: ERROR: Unrecognized dep: monitoring_proto -- google\api\BUILD.bazel
    googleapis/cci.20221020: ERROR: Unrecognized dep: quota_proto -- google\api\BUILD.bazel
    googleapis/cci.20221020: ERROR: Package '9c7f1f4c160f05ab583088babe50892aba41fa1c' build failed
    googleapis/cci.20221020: WARN: Build folder C:\J\w\prod\BuildSingleReference/s\549562\1
    ERROR: googleapis/cci.20221020: Error in build() method, line 163
    	cmake.build()
    	ConanException: Error 1 while executing cmake --build C:\J\w\prod\BuildSingleReference/s\549562\1 --config Release -- /m:8 /verbosity:minimal
    
  • googleapis/cci.20220426@:
    All packages built successfully! (All logs)


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@stale
Copy link

stale bot commented Jan 21, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Feb 21, 2023

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@stale stale bot closed this Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants