-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
googleapis: modernize more & bump protobuf #15601
googleapis: modernize more & bump protobuf #15601
Conversation
SpaceIm
commented
Jan 31, 2023
- trick to avoid having protobuf both in requirements & build requirements (if native build for 1 & 2 profiles)
- use rm_safe
- use self.dependencies
- use tool_requires
- reorder methods by order of execution to give a better understanding of global recipe logic
- I've read the contributing guidelines.
- I've used a recent Conan client version close to the currently deployed.
- I've tried at least one configuration locally with the conan-center hook activated.
I detected other pull requests that are modifying googleapis/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
From my own local testing, I'm pretty sure that It's unclear why it went from working (3.21.4) to not working (3.21.9), but it could be simply be caused as a side effect of the order of implicitly included headers changing.
this may be fixed in newer versions of protobuf: |
This comment has been minimized.
This comment has been minimized.
There's merge conflicts and the downstream dep was fixed should be good to move forward |
well, transitive_libs is missing |
This comment has been minimized.
This comment has been minimized.
@@ -67,28 +71,35 @@ def validate(self): | |||
if self.options.shared and not self.dependencies["protobuf"].options.shared: | |||
raise ConanInvalidConfiguration("If built as shared, protobuf must be shared as well. Please, use `protobuf:shared=True`") | |||
|
|||
@property | |||
def _cmake_new_enough(self): | |||
def _cmake_new_enough(self, required_version): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is can be removed with the new portable binaries
Super minor nits |
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Conan v1 pipeline ✔️All green in build 11 (
Conan v2 pipeline (informative, not required for merge) ✔️
All green in build 9 (
|
#16034 has the same changes so we will have merge conflicts :( |
* modernize more * remove duplicated copy import * fix _cmake_new_enough() and bump cmake * remove protobuf full_package_mode() * properly manage native build & protobuf * bump cmake * transitive_libs for protobuf * add comment Co-authored-by: Chris Mc <prince.chrismc@gmail.com> --------- Co-authored-by: Chris Mc <prince.chrismc@gmail.com>