MAE-501: Fix unable to send direct debit notifications. #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP does not allow different method signature when override method from the parent class. As the sendEmail method in the child class requires different arguments, the method name has been changed to address the warning.
This abstract common class to decouple functions that duplicate in Contribution and Membership Email classes
The methods in parents class have been moved from the parent class to the traits. In order to use the functions in the traits which is not static, we need to change the context of method that calls the function in traits to have the same context.
Since the common code have been moved from common class to the traits in CiviCRM core, we need to refactor these classes to align with CiviCRM core.
erawat
changed the title
ahed-compucorp
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When using Find contributions / Find memberships to search for contribution or memberships, Manual Direct Debit extensions provide a feature to send direct debit notifications on the actions using Manual Direct Templates.
The implementation was extended CiviCRM core functions which were moved from the class to traits since CiviCRM 5.34 here.
This PR refactors the code in the Manual Direct Debit to align with the changes in the CiviCRM core.
Before
Error was present when sending email from "Send Direct Debit Notifications" actions when using Direct Debit templates or CiviCRM templates.
After
Email can be sent when using Send Direct Debit Notifications when using either
Technical Details
This PR also takes an opportunity to refactor codes to fix or address as the following: