Remove functions from EmailCommon that were moved to the trait #19214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
dep2
branch
from
a1b53d8
to
d581861
Compare
|
test this please |
|
Jenkins re test this please |
|
I performed an r-run of this on the test site and confirmed that the send once off email still worked as expected merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes the form handling functions from EmailCommon except the one still in use
Before
Functionality was moved to the trait and cleaned up but left in deprecated state for 10 months
After
Functionality removed
Technical Details
As deprecated functions go this is particularly likely to be broken as it shares a tpl with the trait which has been altered since the deprecation
Comments