PCHR-3635: Fix hoek GitHub security vulnerability warning #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneolivo
approved these changes
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See compucorp/civihr#2589 for details about the issue.
In this repo
hoekis a 4th-level dependency (at best) of the gulp-sass package, and they are stuck with it as well: see hereGiven that
gulp-sassversion had been updated, the way that the sass files are processed has changed, that's why the .css files are included in this PR. The changes are not substantial, mostly about how the nested selectors are processed, for example (.crm-container #task-section .select2-container [disabled].select2-choiceis now.crm-container #task-section .select2-container .select2-choice[disabled])