PCHR-3635: Fix hoek GitHub security vulnerability warning #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkA84
force-pushed
the
PCHR-3635-fix-hoek-github-warning
branch
from
e80fe34 to
b74baa3
Compare
reneolivo
approved these changes
Apr 27, 2018
AkA84
pushed a commit
that referenced
this pull request
Apr 27, 2018
The changes in #335, didn't work as expected. Pushing this commit directly to staging to see if it has any effect
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See compucorp/civihr-tasks-assignments#352 for details about the issue.
Technical details
This reference was wrong
as it was mentioning a partial that had been moved as part of this PR: compucorp/org.civicrm.shoreditch#105.
The correct reference is now
The changes had been tested with BackstopJS, not diff found