Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

UI Language selection #533

Closed
MichaelKohler opened this issue Nov 12, 2021 · 10 comments
Closed

UI Language selection #533

MichaelKohler opened this issue Nov 12, 2021 · 10 comments

Comments

@MichaelKohler
Copy link
Member

I think we should add a UI language dropdown somewhere once all the localization is ready. We might want a certain amount of strings already translated to enable that, similar to what Common Voice decides whether a language is ready to contribute to. This is to be figured out.

@HarikalarKutusu
Copy link
Contributor

I was just adding that to #532 ...
Many languages in Pontoon are <90% already and translation of SC strings will take some time.

In my past projects, in these situations, I was outputting the fallback language strings in different colors and warning the user that UI is not fully translated, providing them with a link. Maybe this idea will be of help...

@MichaelKohler
Copy link
Member Author

MichaelKohler commented Nov 12, 2021

I'm not sure if we'd even need that. Right now English is the only thing. If somebody gets English with a few translated sentences it's not perfect, but might be better than English only. We can also leave it without any selection for some time and then enable it once more and more languages have translated the Sentence Collector strings as well. The selection through the url /de/review for example would still work.

@MichaelKohler
Copy link
Member Author

Also filed #535 inspired by your suggestion :)

@HarikalarKutusu
Copy link
Contributor

HarikalarKutusu commented Nov 12, 2021

You might be able to get the lines starting with "sc-" from locale/messages.ftl and calculate the percentage for a decision?
That can be done at release time perhaps?
If it is 100%, do not put the Pontoon link, else put warning etc...
Or on UI selector you can put an asterisk to indicate more translation needed...

@MichaelKohler
Copy link
Member Author

Yeah, we could do that. I'm currently creating milestones and for now I'm putting it in the first quarter of 2022. But we could do it before then of course.

@MichaelKohler MichaelKohler added this to the Q1 2022 milestone Nov 12, 2021
@HarikalarKutusu
Copy link
Contributor

Can't we target January 1st? It is International Public Domain Day...

I'm eager to help wherever I can like always :)

@MichaelKohler
Copy link
Member Author

We can see how it goes until the end of the year and enable the dropdown whenever we feel it's beneficial already.

@HarikalarKutusu
Copy link
Contributor

HarikalarKutusu commented Nov 12, 2021

In the meantime, if you can put the data into Pontoon, people will get started and many languages can be ready :)

There can only be a handful of additions due to code changes that can easily be done...

@MichaelKohler
Copy link
Member Author

Yeah, I just assigned #525 to me and will do that this weekend.

@MichaelKohler MichaelKohler self-assigned this Nov 20, 2021
MichaelKohler pushed a commit that referenced this issue Nov 25, 2021
# [2.14.0](v2.13.1...v2.14.0) (2021-11-25)

### Bug Fixes

* add note for addition process to language addition section (fixes [#474](#474)) ([#561](#561)) ([3ab0cf1](3ab0cf1))
* do not persist allLanguages, languages, router and review sentences from store (fixes [#550](#550)) ([#559](#559)) ([97e5217](97e5217))

### Features

* add UI language selector to profile (fixes [#533](#533)) ([#563](#563)) ([de59b70](de59b70))
* only enable languages also enabled on Pontoon ([#558](#558)) ([0da87d0](0da87d0)), closes [#534](#534)
@MichaelKohler
Copy link
Member Author

🎉 This issue has been resolved in version 2.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants