Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Add link to Language Addition process in Profile #474

Closed
MichaelKohler opened this issue Sep 4, 2021 · 5 comments
Closed

Add link to Language Addition process in Profile #474

MichaelKohler opened this issue Sep 4, 2021 · 5 comments
Assignees
@MichaelKohler
Labels
area: profile enhancement New feature or request frontend P2
Milestone
Q1 2022

Comments

@MichaelKohler
Copy link
Member

MichaelKohler commented Sep 4, 2021 •
edited
Loading

Currently there is no way to request a new language if the language is not in Sentence Collector yet. We should mention that flow next to the dropdown, and point to https://discourse.mozilla.org/t/readme-how-to-see-my-language-on-common-voice/31530

image

The section can be found at https://github.com/common-voice/sentence-collector/blob/ed168c802bdbe3290848bea6b876d4f54965da12/web/src/components/add-language-section.tsx.

Let's add the following string below the dropdown: "If your language is not listed here, you can request it through this process."
@HarikalarKutusu
Copy link
Contributor

HarikalarKutusu commented Nov 6, 2021 •
edited
Loading

After the decision on Option 2 here, is this still necessary or will this just become a link to Pontoon?

I still could not get how Localization & SC database & CV languages will be related...

@MichaelKohler
Copy link
Member Author

If the language is not yet enabled in Sentence Collector, it's highly likely that it's not enabled in Common Voice at all. For that case I think it's more beneficial to link to the Discourse topic, as that also explains the process apart from the localization itself.

@MichaelKohler
Copy link
Member Author

I still could not get how Localization & SC database & CV languages will be related...

I'll document the Localization process for Sentence Collector soon-ish. The Localization part does not change anything on how the Sentence Collector database and Common Voice languages work. I'll CC you on the documentation PR and you can then file a new issue with questions in case the documentation does not answer a question you have, does that make sense?

@HarikalarKutusu
Copy link
Contributor

OK...

@MichaelKohler MichaelKohler mentioned this issue Nov 12, 2021
Closed
@MichaelKohler MichaelKohler added this to the Q1 2022 milestone Nov 12, 2021
@MichaelKohler MichaelKohler mentioned this issue Nov 20, 2021
Merged
@MichaelKohler MichaelKohler removed the good first issue Good for newcomers label Nov 20, 2021
@MichaelKohler MichaelKohler self-assigned this Nov 20, 2021
MichaelKohler pushed a commit that referenced this issue Nov 25, 2021
@semantic-release-bot
chore(release): 2.14.0
390bc6b 
# [2.14.0](v2.13.1...v2.14.0) (2021-11-25)

### Bug Fixes

* add note for addition process to language addition section (fixes [#474](#474)) ([#561](#561)) ([3ab0cf1](3ab0cf1))
* do not persist allLanguages, languages, router and review sentences from store (fixes [#550](#550)) ([#559](#559)) ([97e5217](97e5217))

### Features

* add UI language selector to profile (fixes [#533](#533)) ([#563](#563)) ([de59b70](de59b70))
* only enable languages also enabled on Pontoon ([#558](#558)) ([0da87d0](0da87d0)), closes [#534](#534)
@MichaelKohler
Copy link
Member Author

🎉 This issue has been resolved in version 2.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MichaelKohler MichaelKohler

Labels
area: profile enhancement New feature or request frontend P2
Projects
None yet
Milestone
Q1 2022
Development

No branches or pull requests
2 participants
@MichaelKohler @HarikalarKutusu