Remove unmaintained packages disabled since ghc-9.2, ie after lts-19 #7511
Conversation
|
Can a curator please let me know whether this has any hope of getting merged if I rebase it? If this is too large, what about a start with a smaller set of packages? Like just Accelerate, Biobase or web3? |
| - vcswrapper < 0 # tried vcswrapper-0.1.6, but its *library* requires containers >=0.5.5.1 && < 0.6 and the snapshot contains containers-0.6.8 | ||
| - vcswrapper < 0 # tried vcswrapper-0.1.6, but its *library* requires mtl >=2.0.1.0 && < 2.3 and the snapshot contains mtl-2.3.1 | ||
| - vcswrapper < 0 # tried vcswrapper-0.1.6, but its *library* requires text >=0.11.1.5 && < 1.3 and the snapshot contains text-2.1.1 | ||
| - vector-circular < 0 # tried vector-circular-0.1.4, but its *library* requires base >=4.11 && < 4.17 and the snapshot contains base-4.19.1.0 |
There was a problem hiding this comment.
Oops, this one was compatible with GHC 9.2, which is later than what I aimed to exclude. Should I remove it?
There was a problem hiding this comment.
That might be more consistent then.
If no one gets to it before the week of 16th, I'll do it.
I think a smaller set of packages will make it easier to review, but will cause more churn. Up to you |
|
Just curious, how do you generate the list? Any script for this? Overall looks good, thank you very much: I agree it's good to clean-away packages that have been disabled for multiple ghc versions. 👍 We need better tooling... |
juhp
changed the title
I use this regex (that I posted in the commit message). Here it is: When a match is found, I search for its name and delete all references to it. If I delete it from the author←package mapping, I might also have to delete the name and e-mail, to prevent empty blocks.
I am not accounting for when the packages were disabled. If packages were disabled because they we not compatible with e.g. ghc-9.2, how would they become enabled again anyway? Only if there is a problem with the commenter, and the comments aren't actually true. I have tried to do spot checks. Will rebase some time this weekend. |
ysangkok
force-pushed
the
remove-unmaintained
branch
from
577b679
to
fd79c8b
Compare
ysangkok
force-pushed
the
remove-unmaintained
branch
from
fd79c8b
to
7fd5f35
Compare
|
Ok, rebased and ready for review/merge. |
|
Thanks for your work! ❤️ (to be honest I've only verified half of the changes, but next nightly would tell any unexpected change - but I'm nearly 100% sure everything matches perfectly!) |
This removes packages that were disabled with the upgrade to GHC 9.2, and
haven't been enabled since.
I removed the checklist since it talking about adding packages, not removing
them.