Fix steering angle offset on NO_DSU TSS1 cars #767
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems some C-HR do not have ["STEER_TORQUE_SENSOR"]['STEER_ANGLE']. Here's a drive from a 2017 C-HR Hybrid in the Netherlands from udaikp on Discord. https://my.comma.ai/cabana/?route=b909455c1b10aa79%7C2019-08-19--09-34-55&max=38&url=https%3A%2F%2Fchffrprivate-vzn.azureedge.net%2Fchffrprivate3%2Fv2%2Fb909455c1b10aa79%2Ff4d66b99a38c6b6da3c04171cada2e4d_2019-08-19--09-34-55 |
|
My guess is the new angle message exists on 2018, the year the camry was launched |
debugged-tech
pushed a commit
to debugged-tech/DebuggedPilot
that referenced
this pull request
Jan 12, 2021
* toyota rsa logic * no arne messaging and add opedit * add gas_press, smartspeed and spdval1 to carstate * more fixes * new_message * thats right we dont have anglelater code yet. * revert to working mapd code? and pylint ignore mapd * flake8 ignore. * flake8 e701 fix * control df with distance button? * wrong struct * Update carstate.py * update missing * start MessagedArneThread * Update carstate.py * pubmaster? * message * update carstate.py * no .status * pm * use dp_dynamic_follow to send DF status * sntax * encoding='utf8' * Update carstate.py * Update carstate.py * pyopencl pipenv * change the order so we can display right thing with distance toggle * doesnt work well with dg * Revert "change the order so we can display right thing with distance toggle" This reverts commit ee4522a. * turn off distance button for now. * Parametrize MIN_CAN_SPEED in car interfaces * Parametrize stoppingBrakeRate * Parametrize startingBrakeRate * add the parameter to cereal . * Update dp_common.py * tune dg * add AVALON_2021 in dp080 * sync (#93) * Update dp_common.py * Update dp_common.py * RSA, Distance button and briskspirit longcontrol (commaai#762) * toyota rsa logic * no arne messaging and add opedit * add gas_press, smartspeed and spdval1 to carstate * more fixes * new_message * thats right we dont have anglelater code yet. * revert to working mapd code? and pylint ignore mapd * flake8 ignore. * flake8 e701 fix * control df with distance button? * wrong struct * Update carstate.py * update missing * start MessagedArneThread * Update carstate.py * pubmaster? * message * update carstate.py * no .status * pm * use dp_dynamic_follow to send DF status * sntax * encoding='utf8' * Update carstate.py * Update carstate.py * pyopencl pipenv * change the order so we can display right thing with distance toggle * doesnt work well with dg * Revert "change the order so we can display right thing with distance toggle" This reverts commit ee4522a. * turn off distance button for now. * Parametrize MIN_CAN_SPEED in car interfaces * Parametrize stoppingBrakeRate * Parametrize startingBrakeRate * add the parameter to cereal . * Update dp_common.py Co-authored-by: Arne Schwarck <arneschwarck@gmail.com> Co-authored-by: George Hotz <george@comma.ai> Co-authored-by: Igor <briskspirit@users.noreply.github.com> * corolla_TSS2: tune (commaai#760) * Update interface.py updated corollatss2 tuning * Update toyota_nodsu_pt_generated.dbc * Update toyota_nodsu_hybrid_pt_generated.dbc * Update op_params.py * Create toyota_nodsu_pt_generated_corolla_tss2.dbc * Create toyota_nodsu_pt_generated_corollah_tss2.dbc * revert to stock. * revert to stock * point corolla and corollah to its own separate dbc. * add corolla and corollah dbc to release. * Update interface.py Co-authored-by: Kumar <36933347+rav4kumar@users.noreply.github.com> Co-authored-by: Arne Schwarck <arneschwarck@gmail.com> Co-authored-by: George Hotz <george@comma.ai> Co-authored-by: Igor <briskspirit@users.noreply.github.com> Co-authored-by: SCshredder17 <57152954+SCshredder17@users.noreply.github.com> * added dbc to release and test route. * cant use the route since comma doesnt got it. * i cant spell Co-authored-by: Arne Schwarck <arneschwarck@gmail.com> Co-authored-by: George Hotz <george@comma.ai> Co-authored-by: Igor <briskspirit@users.noreply.github.com> Co-authored-by: SCshredder17 <57152954+SCshredder17@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based off #757, thanks @zorrobyte