Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to understand the vanishing point formula #760

Closed
gucasbrg opened this issue Jul 25, 2019 · 3 comments
Closed

how to understand the vanishing point formula #760

gucasbrg opened this issue Jul 25, 2019 · 3 comments

Comments

@gucasbrg
Copy link

new_vp = eon_intrinsics.dot(view_frame_from_device_frame.dot(trans))

trans means speed? can you provide some article to explanation these formula

@dek3rr
Copy link

dek3rr commented Jul 30, 2019

trans as in translation of the camera frame.
this is probably a decent start to understand frames and camera properties
http://ksimek.github.io/2013/08/13/intrinsic/

@gucasbrg
Copy link
Author

gucasbrg commented Aug 7, 2019

@dekerr

def handle_cam_odom(self, log):
trans, rot = log.cameraOdometry.trans, log.cameraOdometry.rot
if np.linalg.norm(trans) > MIN_SPEED_FILTER and abs(rot[2]) < MAX_YAW_RATE_FILTER:
  new_vp = eon_intrinsics.dot(view_frame_from_device_frame.dot(trans))

the defination of trans in CameraOdometry,looks like m/s in device frame

struct CameraOdometry {
  trans @0 :List(Float32); # m/s in device frame
  rot @1 :List(Float32); # rad/s in device frame
  transStd @2 :List(Float32); # std m/s in device frame
  rotStd @3 :List(Float32); # std rad/s in device frame
}

@gucasbrg
Copy link
Author

1566294427109

debugged-tech pushed a commit to debugged-tech/DebuggedPilot that referenced this issue Jan 11, 2021
* Update interface.py

updated corollatss2 tuning

* Update toyota_nodsu_pt_generated.dbc

* Update toyota_nodsu_hybrid_pt_generated.dbc

* Update op_params.py

* Create toyota_nodsu_pt_generated_corolla_tss2.dbc

* Create toyota_nodsu_pt_generated_corollah_tss2.dbc

* revert to stock.

* revert to stock

* point corolla and corollah to its own separate dbc.

* add corolla and corollah dbc to release.

* Update interface.py

Co-authored-by: Kumar <36933347+rav4kumar@users.noreply.github.com>
rav4kumar added a commit to rav4kumar/openpilot that referenced this issue Jan 11, 2021
* Update dp_common.py

* Update dp_common.py

* RSA, Distance button and briskspirit longcontrol (commaai#762)

* toyota rsa logic

* no arne messaging and add opedit

* add gas_press, smartspeed and spdval1 to carstate

* more fixes

* new_message

* thats right we dont have anglelater code yet.

* revert to working mapd code? and pylint ignore mapd

* flake8 ignore.

* flake8 e701 fix

* control df with distance button?

* wrong struct

* Update carstate.py

* update missing

* start MessagedArneThread

* Update carstate.py

* pubmaster?

* message

* update carstate.py

* no .status

* pm

* use dp_dynamic_follow to send DF status

* sntax

* encoding='utf8'

* Update carstate.py

* Update carstate.py

* pyopencl pipenv

* change the order so we can display right thing with distance toggle

* doesnt work well with dg

* Revert "change the order so we can display right thing with distance toggle"

This reverts commit ee4522a.

* turn off distance button for now.

* Parametrize MIN_CAN_SPEED in car interfaces

* Parametrize stoppingBrakeRate

* Parametrize startingBrakeRate

* add the parameter to cereal .

* Update dp_common.py

Co-authored-by: Arne Schwarck <arneschwarck@gmail.com>
Co-authored-by: George Hotz <george@comma.ai>
Co-authored-by: Igor <briskspirit@users.noreply.github.com>

* corolla_TSS2: tune (commaai#760)

* Update interface.py

updated corollatss2 tuning

* Update toyota_nodsu_pt_generated.dbc

* Update toyota_nodsu_hybrid_pt_generated.dbc

* Update op_params.py

* Create toyota_nodsu_pt_generated_corolla_tss2.dbc

* Create toyota_nodsu_pt_generated_corollah_tss2.dbc

* revert to stock.

* revert to stock

* point corolla and corollah to its own separate dbc.

* add corolla and corollah dbc to release.

* Update interface.py

Co-authored-by: Kumar <36933347+rav4kumar@users.noreply.github.com>

Co-authored-by: Arne Schwarck <arneschwarck@gmail.com>
Co-authored-by: George Hotz <george@comma.ai>
Co-authored-by: Igor <briskspirit@users.noreply.github.com>
Co-authored-by: SCshredder17 <57152954+SCshredder17@users.noreply.github.com>
debugged-tech pushed a commit to debugged-tech/DebuggedPilot that referenced this issue Jan 12, 2021
* toyota rsa logic

* no arne messaging and add opedit

* add gas_press, smartspeed and spdval1 to carstate

* more fixes

* new_message

* thats right we dont have anglelater code yet.

* revert to working mapd code? and pylint ignore mapd

* flake8 ignore.

* flake8 e701 fix

* control df with distance button?

* wrong struct

* Update carstate.py

* update missing

* start MessagedArneThread

* Update carstate.py

* pubmaster?

* message

* update carstate.py

* no .status

* pm

* use dp_dynamic_follow to send DF status

* sntax

* encoding='utf8'

* Update carstate.py

* Update carstate.py

* pyopencl pipenv

* change the order so we can display right thing with distance toggle

* doesnt work well with dg

* Revert "change the order so we can display right thing with distance toggle"

This reverts commit ee4522a.

* turn off distance button for now.

* Parametrize MIN_CAN_SPEED in car interfaces

* Parametrize stoppingBrakeRate

* Parametrize startingBrakeRate

* add the parameter to cereal .

* Update dp_common.py

* tune dg

* add AVALON_2021 in dp080

* sync (#93)

* Update dp_common.py

* Update dp_common.py

* RSA, Distance button and briskspirit longcontrol (commaai#762)

* toyota rsa logic

* no arne messaging and add opedit

* add gas_press, smartspeed and spdval1 to carstate

* more fixes

* new_message

* thats right we dont have anglelater code yet.

* revert to working mapd code? and pylint ignore mapd

* flake8 ignore.

* flake8 e701 fix

* control df with distance button?

* wrong struct

* Update carstate.py

* update missing

* start MessagedArneThread

* Update carstate.py

* pubmaster?

* message

* update carstate.py

* no .status

* pm

* use dp_dynamic_follow to send DF status

* sntax

* encoding='utf8'

* Update carstate.py

* Update carstate.py

* pyopencl pipenv

* change the order so we can display right thing with distance toggle

* doesnt work well with dg

* Revert "change the order so we can display right thing with distance toggle"

This reverts commit ee4522a.

* turn off distance button for now.

* Parametrize MIN_CAN_SPEED in car interfaces

* Parametrize stoppingBrakeRate

* Parametrize startingBrakeRate

* add the parameter to cereal .

* Update dp_common.py

Co-authored-by: Arne Schwarck <arneschwarck@gmail.com>
Co-authored-by: George Hotz <george@comma.ai>
Co-authored-by: Igor <briskspirit@users.noreply.github.com>

* corolla_TSS2: tune (commaai#760)

* Update interface.py

updated corollatss2 tuning

* Update toyota_nodsu_pt_generated.dbc

* Update toyota_nodsu_hybrid_pt_generated.dbc

* Update op_params.py

* Create toyota_nodsu_pt_generated_corolla_tss2.dbc

* Create toyota_nodsu_pt_generated_corollah_tss2.dbc

* revert to stock.

* revert to stock

* point corolla and corollah to its own separate dbc.

* add corolla and corollah dbc to release.

* Update interface.py

Co-authored-by: Kumar <36933347+rav4kumar@users.noreply.github.com>

Co-authored-by: Arne Schwarck <arneschwarck@gmail.com>
Co-authored-by: George Hotz <george@comma.ai>
Co-authored-by: Igor <briskspirit@users.noreply.github.com>
Co-authored-by: SCshredder17 <57152954+SCshredder17@users.noreply.github.com>

* added dbc to release and test route.

* cant use the route since comma doesnt got it.

* i cant spell

Co-authored-by: Arne Schwarck <arneschwarck@gmail.com>
Co-authored-by: George Hotz <george@comma.ai>
Co-authored-by: Igor <briskspirit@users.noreply.github.com>
Co-authored-by: SCshredder17 <57152954+SCshredder17@users.noreply.github.com>
debugged-tech pushed a commit to debugged-tech/DebuggedPilot that referenced this issue Jan 12, 2021
* toyota rsa logic

* no arne messaging and add opedit

* add gas_press, smartspeed and spdval1 to carstate

* more fixes

* new_message

* thats right we dont have anglelater code yet.

* revert to working mapd code? and pylint ignore mapd

* flake8 ignore.

* flake8 e701 fix

* control df with distance button?

* wrong struct

* Update carstate.py

* update missing

* start MessagedArneThread

* Update carstate.py

* pubmaster?

* message

* update carstate.py

* no .status

* pm

* use dp_dynamic_follow to send DF status

* sntax

* encoding='utf8'

* Update carstate.py

* Update carstate.py

* pyopencl pipenv

* change the order so we can display right thing with distance toggle

* doesnt work well with dg

* Revert "change the order so we can display right thing with distance toggle"

This reverts commit ee4522a.

* turn off distance button for now.

* Parametrize MIN_CAN_SPEED in car interfaces

* Parametrize stoppingBrakeRate

* Parametrize startingBrakeRate

* add the parameter to cereal .

* Update dp_common.py

* tune dg

* add AVALON_2021 in dp080

* sync (#93)

* Update dp_common.py

* Update dp_common.py

* RSA, Distance button and briskspirit longcontrol (commaai#762)

* toyota rsa logic

* no arne messaging and add opedit

* add gas_press, smartspeed and spdval1 to carstate

* more fixes

* new_message

* thats right we dont have anglelater code yet.

* revert to working mapd code? and pylint ignore mapd

* flake8 ignore.

* flake8 e701 fix

* control df with distance button?

* wrong struct

* Update carstate.py

* update missing

* start MessagedArneThread

* Update carstate.py

* pubmaster?

* message

* update carstate.py

* no .status

* pm

* use dp_dynamic_follow to send DF status

* sntax

* encoding='utf8'

* Update carstate.py

* Update carstate.py

* pyopencl pipenv

* change the order so we can display right thing with distance toggle

* doesnt work well with dg

* Revert "change the order so we can display right thing with distance toggle"

This reverts commit ee4522a.

* turn off distance button for now.

* Parametrize MIN_CAN_SPEED in car interfaces

* Parametrize stoppingBrakeRate

* Parametrize startingBrakeRate

* add the parameter to cereal .

* Update dp_common.py

Co-authored-by: Arne Schwarck <arneschwarck@gmail.com>
Co-authored-by: George Hotz <george@comma.ai>
Co-authored-by: Igor <briskspirit@users.noreply.github.com>

* corolla_TSS2: tune (commaai#760)

* Update interface.py

updated corollatss2 tuning

* Update toyota_nodsu_pt_generated.dbc

* Update toyota_nodsu_hybrid_pt_generated.dbc

* Update op_params.py

* Create toyota_nodsu_pt_generated_corolla_tss2.dbc

* Create toyota_nodsu_pt_generated_corollah_tss2.dbc

* revert to stock.

* revert to stock

* point corolla and corollah to its own separate dbc.

* add corolla and corollah dbc to release.

* Update interface.py

Co-authored-by: Kumar <36933347+rav4kumar@users.noreply.github.com>

Co-authored-by: Arne Schwarck <arneschwarck@gmail.com>
Co-authored-by: George Hotz <george@comma.ai>
Co-authored-by: Igor <briskspirit@users.noreply.github.com>
Co-authored-by: SCshredder17 <57152954+SCshredder17@users.noreply.github.com>

* added dbc to release and test route.

* cant use the route since comma doesnt got it.

* i cant spell

* add PIControllerk_f

* Add kfV and kfBP to PIDTuning

* update the car interfaces for bfv and kfbp tunning.

* Add scanner for Cython dependencies

* cleanup unused android libs in phonelibs (commaai#19702)

Co-authored-by: Comma Device <device@comma.ai>

* syntax

* E502 flake8 fix

* fix

* make it list.

* ugh list

* kfV

* forgot vw

* update ford

* Shanes PIDController: orvershooting fix

* action fix.

* restore crash logging trackign of fork and branch.

* add pirus to nodsu

* fix

* fix for crash

* my bad.

* revert.

* working.

Co-authored-by: Arne Schwarck <arneschwarck@gmail.com>
Co-authored-by: George Hotz <george@comma.ai>
Co-authored-by: Igor <briskspirit@users.noreply.github.com>
Co-authored-by: SCshredder17 <57152954+SCshredder17@users.noreply.github.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
rav4kumar added a commit to rav4kumar/openpilot that referenced this issue Jan 13, 2021
* support for kfv and kfbp and overshooting fix (commaai#768)

* toyota rsa logic

* no arne messaging and add opedit

* add gas_press, smartspeed and spdval1 to carstate

* more fixes

* new_message

* thats right we dont have anglelater code yet.

* revert to working mapd code? and pylint ignore mapd

* flake8 ignore.

* flake8 e701 fix

* control df with distance button?

* wrong struct

* Update carstate.py

* update missing

* start MessagedArneThread

* Update carstate.py

* pubmaster?

* message

* update carstate.py

* no .status

* pm

* use dp_dynamic_follow to send DF status

* sntax

* encoding='utf8'

* Update carstate.py

* Update carstate.py

* pyopencl pipenv

* change the order so we can display right thing with distance toggle

* doesnt work well with dg

* Revert "change the order so we can display right thing with distance toggle"

This reverts commit ee4522a.

* turn off distance button for now.

* Parametrize MIN_CAN_SPEED in car interfaces

* Parametrize stoppingBrakeRate

* Parametrize startingBrakeRate

* add the parameter to cereal .

* Update dp_common.py

* tune dg

* add AVALON_2021 in dp080

* sync (#93)

* Update dp_common.py

* Update dp_common.py

* RSA, Distance button and briskspirit longcontrol (commaai#762)

* toyota rsa logic

* no arne messaging and add opedit

* add gas_press, smartspeed and spdval1 to carstate

* more fixes

* new_message

* thats right we dont have anglelater code yet.

* revert to working mapd code? and pylint ignore mapd

* flake8 ignore.

* flake8 e701 fix

* control df with distance button?

* wrong struct

* Update carstate.py

* update missing

* start MessagedArneThread

* Update carstate.py

* pubmaster?

* message

* update carstate.py

* no .status

* pm

* use dp_dynamic_follow to send DF status

* sntax

* encoding='utf8'

* Update carstate.py

* Update carstate.py

* pyopencl pipenv

* change the order so we can display right thing with distance toggle

* doesnt work well with dg

* Revert "change the order so we can display right thing with distance toggle"

This reverts commit ee4522a.

* turn off distance button for now.

* Parametrize MIN_CAN_SPEED in car interfaces

* Parametrize stoppingBrakeRate

* Parametrize startingBrakeRate

* add the parameter to cereal .

* Update dp_common.py

Co-authored-by: Arne Schwarck <arneschwarck@gmail.com>
Co-authored-by: George Hotz <george@comma.ai>
Co-authored-by: Igor <briskspirit@users.noreply.github.com>

* corolla_TSS2: tune (commaai#760)

* Update interface.py

updated corollatss2 tuning

* Update toyota_nodsu_pt_generated.dbc

* Update toyota_nodsu_hybrid_pt_generated.dbc

* Update op_params.py

* Create toyota_nodsu_pt_generated_corolla_tss2.dbc

* Create toyota_nodsu_pt_generated_corollah_tss2.dbc

* revert to stock.

* revert to stock

* point corolla and corollah to its own separate dbc.

* add corolla and corollah dbc to release.

* Update interface.py

Co-authored-by: Kumar <36933347+rav4kumar@users.noreply.github.com>

Co-authored-by: Arne Schwarck <arneschwarck@gmail.com>
Co-authored-by: George Hotz <george@comma.ai>
Co-authored-by: Igor <briskspirit@users.noreply.github.com>
Co-authored-by: SCshredder17 <57152954+SCshredder17@users.noreply.github.com>

* added dbc to release and test route.

* cant use the route since comma doesnt got it.

* i cant spell

* add PIControllerk_f

* Add kfV and kfBP to PIDTuning

* update the car interfaces for bfv and kfbp tunning.

* Add scanner for Cython dependencies

* cleanup unused android libs in phonelibs (commaai#19702)

Co-authored-by: Comma Device <device@comma.ai>

* syntax

* E502 flake8 fix

* fix

* make it list.

* ugh list

* kfV

* forgot vw

* update ford

* Shanes PIDController: orvershooting fix

* action fix.

* restore crash logging trackign of fork and branch.

* add pirus to nodsu

* fix

* fix for crash

* my bad.

* revert.

* working.

Co-authored-by: Arne Schwarck <arneschwarck@gmail.com>
Co-authored-by: George Hotz <george@comma.ai>
Co-authored-by: Igor <briskspirit@users.noreply.github.com>
Co-authored-by: SCshredder17 <57152954+SCshredder17@users.noreply.github.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>

* better logging for fingerprint missing

* Function log_fingerprinted not needed

Co-authored-by: Arne Schwarck <arneschwarck@gmail.com>
Co-authored-by: George Hotz <george@comma.ai>
Co-authored-by: Igor <briskspirit@users.noreply.github.com>
Co-authored-by: SCshredder17 <57152954+SCshredder17@users.noreply.github.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
rav4kumar added a commit to rav4kumar/openpilot that referenced this issue Jan 14, 2021
* support for kfv and kfbp and overshooting fix (commaai#768)

* toyota rsa logic

* no arne messaging and add opedit

* add gas_press, smartspeed and spdval1 to carstate

* more fixes

* new_message

* thats right we dont have anglelater code yet.

* revert to working mapd code? and pylint ignore mapd

* flake8 ignore.

* flake8 e701 fix

* control df with distance button?

* wrong struct

* Update carstate.py

* update missing

* start MessagedArneThread

* Update carstate.py

* pubmaster?

* message

* update carstate.py

* no .status

* pm

* use dp_dynamic_follow to send DF status

* sntax

* encoding='utf8'

* Update carstate.py

* Update carstate.py

* pyopencl pipenv

* change the order so we can display right thing with distance toggle

* doesnt work well with dg

* Revert "change the order so we can display right thing with distance toggle"

This reverts commit ee4522a.

* turn off distance button for now.

* Parametrize MIN_CAN_SPEED in car interfaces

* Parametrize stoppingBrakeRate

* Parametrize startingBrakeRate

* add the parameter to cereal .

* Update dp_common.py

* tune dg

* add AVALON_2021 in dp080

* sync (#93)

* Update dp_common.py

* Update dp_common.py

* RSA, Distance button and briskspirit longcontrol (commaai#762)

* toyota rsa logic

* no arne messaging and add opedit

* add gas_press, smartspeed and spdval1 to carstate

* more fixes

* new_message

* thats right we dont have anglelater code yet.

* revert to working mapd code? and pylint ignore mapd

* flake8 ignore.

* flake8 e701 fix

* control df with distance button?

* wrong struct

* Update carstate.py

* update missing

* start MessagedArneThread

* Update carstate.py

* pubmaster?

* message

* update carstate.py

* no .status

* pm

* use dp_dynamic_follow to send DF status

* sntax

* encoding='utf8'

* Update carstate.py

* Update carstate.py

* pyopencl pipenv

* change the order so we can display right thing with distance toggle

* doesnt work well with dg

* Revert "change the order so we can display right thing with distance toggle"

This reverts commit ee4522a.

* turn off distance button for now.

* Parametrize MIN_CAN_SPEED in car interfaces

* Parametrize stoppingBrakeRate

* Parametrize startingBrakeRate

* add the parameter to cereal .

* Update dp_common.py

Co-authored-by: Arne Schwarck <arneschwarck@gmail.com>
Co-authored-by: George Hotz <george@comma.ai>
Co-authored-by: Igor <briskspirit@users.noreply.github.com>

* corolla_TSS2: tune (commaai#760)

* Update interface.py

updated corollatss2 tuning

* Update toyota_nodsu_pt_generated.dbc

* Update toyota_nodsu_hybrid_pt_generated.dbc

* Update op_params.py

* Create toyota_nodsu_pt_generated_corolla_tss2.dbc

* Create toyota_nodsu_pt_generated_corollah_tss2.dbc

* revert to stock.

* revert to stock

* point corolla and corollah to its own separate dbc.

* add corolla and corollah dbc to release.

* Update interface.py

Co-authored-by: Kumar <36933347+rav4kumar@users.noreply.github.com>

Co-authored-by: Arne Schwarck <arneschwarck@gmail.com>
Co-authored-by: George Hotz <george@comma.ai>
Co-authored-by: Igor <briskspirit@users.noreply.github.com>
Co-authored-by: SCshredder17 <57152954+SCshredder17@users.noreply.github.com>

* added dbc to release and test route.

* cant use the route since comma doesnt got it.

* i cant spell

* add PIControllerk_f

* Add kfV and kfBP to PIDTuning

* update the car interfaces for bfv and kfbp tunning.

* Add scanner for Cython dependencies

* cleanup unused android libs in phonelibs (commaai#19702)

Co-authored-by: Comma Device <device@comma.ai>

* syntax

* E502 flake8 fix

* fix

* make it list.

* ugh list

* kfV

* forgot vw

* update ford

* Shanes PIDController: orvershooting fix

* action fix.

* restore crash logging trackign of fork and branch.

* add pirus to nodsu

* fix

* fix for crash

* my bad.

* revert.

* working.

Co-authored-by: Arne Schwarck <arneschwarck@gmail.com>
Co-authored-by: George Hotz <george@comma.ai>
Co-authored-by: Igor <briskspirit@users.noreply.github.com>
Co-authored-by: SCshredder17 <57152954+SCshredder17@users.noreply.github.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>

* better logging for fingerprint missing

* Function log_fingerprinted not needed

* F821 and F722

* Update values.py

21 Genesis G70 optimization

Co-authored-by: Arne Schwarck <arneschwarck@gmail.com>
Co-authored-by: George Hotz <george@comma.ai>
Co-authored-by: Igor <briskspirit@users.noreply.github.com>
Co-authored-by: SCshredder17 <57152954+SCshredder17@users.noreply.github.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: sebastian4k <69202924+sebastian4k@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants