Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved radar signal building #444

Closed
wants to merge 11 commits into from
Closed

Conversation

dek3rr
Copy link

@dek3rr dek3rr commented Nov 21, 2018

-adds clear pairing of signal name and corresponding value split into packets
-automatically calculate message lengths based on number of signal names
-easier checks
-removes hard coded messages in radar interface
-removes hard coded radar dbc reference
-uses cleaner angle conversions

@rbiasini
Copy link
Contributor

I've cherry-picked few lines (like using CV class when needed and other minor things) but overall decided against the generalization of the radar signal building. The added 60 lines does not seem worth it.

@rbiasini rbiasini closed this Sep 11, 2019
pd0wm pushed a commit that referenced this pull request Feb 19, 2020
ccf75c4 Volkswagen safety updates: Phase 1 (#444)

git-subtree-dir: panda
git-subtree-split: ccf75c4
pd0wm pushed a commit that referenced this pull request Feb 20, 2020
2ebbe36 Subaru: disengage on gas press (#446)
ccf75c4 Volkswagen safety updates: Phase 1 (#444)

git-subtree-dir: panda
git-subtree-split: 2ebbe36
pd0wm pushed a commit that referenced this pull request Feb 20, 2020
b2ffaae Chrysler: disengage on gas press  (#442)
2ebbe36 Subaru: disengage on gas press (#446)
ccf75c4 Volkswagen safety updates: Phase 1 (#444)

git-subtree-dir: panda
git-subtree-split: b2ffaae
pd0wm pushed a commit that referenced this pull request Mar 12, 2020
0696730 Toyota: add missing offset from speed signal (#469)
5b1a8dc Filtering LKAS HUD messages (#468)
99050f4 test_spam_can_buses was missing from Nissan
0f21b19 Cleanup pedal nomenclature (#467)
ceff91d Standardize brake safety tests (#465)
04809e1 Hyundai brake check (#464)
74c8ee0 Subaru brake check (#463)
4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks
c7d0d5f Volkswagen safety updates: Phase 3 (#462)
4368748 WIP: Toyota brake check.  (#459)
2ef996f fix addr frequencies
e063b26 Second test fix tentative
88e2593 This should fix the test replay
ebb8866 Added NISSAN replay test
b2dbb50 remove toyota ipas safety code and tests (#460)
a379faf White Panda's Wi-Fi setup instructions (#457)
11ef24b Improve tests (#456)
fb02390 Subaru checksum counter (#455)
9a44499 Fix Subaru Legacy Torque driver bug (#454)
dfa6b07 separating subary legacy safety mode from global (#452)
dad5858 Chrysler: add brakepress cancellation (#451)
db94a5b Added Nissan safety (#244)
d7f1195 Chrysler Checksum/counter (#450)
96e535e abstract crc function (#448)
1b49d3e Hyundai: add gas disengage and tests (#447)
598074c Volkswagen safety updates: Phase 2 (#445)
b2ffaae Chrysler: disengage on gas press  (#442)
2ebbe36 Subaru: disengage on gas press (#446)
ccf75c4 Volkswagen safety updates: Phase 1 (#444)

git-subtree-dir: panda
git-subtree-split: 0696730
pd0wm pushed a commit that referenced this pull request Mar 13, 2020
0696730 Toyota: add missing offset from speed signal (#469)
5b1a8dc Filtering LKAS HUD messages (#468)
99050f4 test_spam_can_buses was missing from Nissan
0f21b19 Cleanup pedal nomenclature (#467)
ceff91d Standardize brake safety tests (#465)
04809e1 Hyundai brake check (#464)
74c8ee0 Subaru brake check (#463)
4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks
c7d0d5f Volkswagen safety updates: Phase 3 (#462)
4368748 WIP: Toyota brake check.  (#459)
2ef996f fix addr frequencies
e063b26 Second test fix tentative
88e2593 This should fix the test replay
ebb8866 Added NISSAN replay test
b2dbb50 remove toyota ipas safety code and tests (#460)
a379faf White Panda's Wi-Fi setup instructions (#457)
11ef24b Improve tests (#456)
fb02390 Subaru checksum counter (#455)
9a44499 Fix Subaru Legacy Torque driver bug (#454)
dfa6b07 separating subary legacy safety mode from global (#452)
dad5858 Chrysler: add brakepress cancellation (#451)
db94a5b Added Nissan safety (#244)
d7f1195 Chrysler Checksum/counter (#450)
96e535e abstract crc function (#448)
1b49d3e Hyundai: add gas disengage and tests (#447)
598074c Volkswagen safety updates: Phase 2 (#445)
b2ffaae Chrysler: disengage on gas press  (#442)
2ebbe36 Subaru: disengage on gas press (#446)
ccf75c4 Volkswagen safety updates: Phase 1 (#444)

git-subtree-dir: panda
git-subtree-split: 0696730
pd0wm pushed a commit that referenced this pull request Mar 13, 2020
0696730 Toyota: add missing offset from speed signal (#469)
5b1a8dc Filtering LKAS HUD messages (#468)
99050f4 test_spam_can_buses was missing from Nissan
0f21b19 Cleanup pedal nomenclature (#467)
ceff91d Standardize brake safety tests (#465)
04809e1 Hyundai brake check (#464)
74c8ee0 Subaru brake check (#463)
4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks
c7d0d5f Volkswagen safety updates: Phase 3 (#462)
4368748 WIP: Toyota brake check.  (#459)
2ef996f fix addr frequencies
e063b26 Second test fix tentative
88e2593 This should fix the test replay
ebb8866 Added NISSAN replay test
b2dbb50 remove toyota ipas safety code and tests (#460)
a379faf White Panda's Wi-Fi setup instructions (#457)
11ef24b Improve tests (#456)
fb02390 Subaru checksum counter (#455)
9a44499 Fix Subaru Legacy Torque driver bug (#454)
dfa6b07 separating subary legacy safety mode from global (#452)
dad5858 Chrysler: add brakepress cancellation (#451)
db94a5b Added Nissan safety (#244)
d7f1195 Chrysler Checksum/counter (#450)
96e535e abstract crc function (#448)
1b49d3e Hyundai: add gas disengage and tests (#447)
598074c Volkswagen safety updates: Phase 2 (#445)
b2ffaae Chrysler: disengage on gas press  (#442)
2ebbe36 Subaru: disengage on gas press (#446)
ccf75c4 Volkswagen safety updates: Phase 1 (#444)

git-subtree-dir: panda
git-subtree-split: 0696730
pd0wm pushed a commit that referenced this pull request Mar 13, 2020
0696730 Toyota: add missing offset from speed signal (#469)
5b1a8dc Filtering LKAS HUD messages (#468)
99050f4 test_spam_can_buses was missing from Nissan
0f21b19 Cleanup pedal nomenclature (#467)
ceff91d Standardize brake safety tests (#465)
04809e1 Hyundai brake check (#464)
74c8ee0 Subaru brake check (#463)
4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks
c7d0d5f Volkswagen safety updates: Phase 3 (#462)
4368748 WIP: Toyota brake check.  (#459)
2ef996f fix addr frequencies
e063b26 Second test fix tentative
88e2593 This should fix the test replay
ebb8866 Added NISSAN replay test
b2dbb50 remove toyota ipas safety code and tests (#460)
a379faf White Panda's Wi-Fi setup instructions (#457)
11ef24b Improve tests (#456)
fb02390 Subaru checksum counter (#455)
9a44499 Fix Subaru Legacy Torque driver bug (#454)
dfa6b07 separating subary legacy safety mode from global (#452)
dad5858 Chrysler: add brakepress cancellation (#451)
db94a5b Added Nissan safety (#244)
d7f1195 Chrysler Checksum/counter (#450)
96e535e abstract crc function (#448)
1b49d3e Hyundai: add gas disengage and tests (#447)
598074c Volkswagen safety updates: Phase 2 (#445)
b2ffaae Chrysler: disengage on gas press  (#442)
2ebbe36 Subaru: disengage on gas press (#446)
ccf75c4 Volkswagen safety updates: Phase 1 (#444)

git-subtree-dir: panda
git-subtree-split: 0696730
pd0wm pushed a commit that referenced this pull request Mar 14, 2020
0696730 Toyota: add missing offset from speed signal (#469)
5b1a8dc Filtering LKAS HUD messages (#468)
99050f4 test_spam_can_buses was missing from Nissan
0f21b19 Cleanup pedal nomenclature (#467)
ceff91d Standardize brake safety tests (#465)
04809e1 Hyundai brake check (#464)
74c8ee0 Subaru brake check (#463)
4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks
c7d0d5f Volkswagen safety updates: Phase 3 (#462)
4368748 WIP: Toyota brake check.  (#459)
2ef996f fix addr frequencies
e063b26 Second test fix tentative
88e2593 This should fix the test replay
ebb8866 Added NISSAN replay test
b2dbb50 remove toyota ipas safety code and tests (#460)
a379faf White Panda's Wi-Fi setup instructions (#457)
11ef24b Improve tests (#456)
fb02390 Subaru checksum counter (#455)
9a44499 Fix Subaru Legacy Torque driver bug (#454)
dfa6b07 separating subary legacy safety mode from global (#452)
dad5858 Chrysler: add brakepress cancellation (#451)
db94a5b Added Nissan safety (#244)
d7f1195 Chrysler Checksum/counter (#450)
96e535e abstract crc function (#448)
1b49d3e Hyundai: add gas disengage and tests (#447)
598074c Volkswagen safety updates: Phase 2 (#445)
b2ffaae Chrysler: disengage on gas press  (#442)
2ebbe36 Subaru: disengage on gas press (#446)
ccf75c4 Volkswagen safety updates: Phase 1 (#444)

git-subtree-dir: panda
git-subtree-split: 0696730
pd0wm pushed a commit that referenced this pull request Mar 16, 2020
0696730 Toyota: add missing offset from speed signal (#469)
5b1a8dc Filtering LKAS HUD messages (#468)
99050f4 test_spam_can_buses was missing from Nissan
0f21b19 Cleanup pedal nomenclature (#467)
ceff91d Standardize brake safety tests (#465)
04809e1 Hyundai brake check (#464)
74c8ee0 Subaru brake check (#463)
4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks
c7d0d5f Volkswagen safety updates: Phase 3 (#462)
4368748 WIP: Toyota brake check.  (#459)
2ef996f fix addr frequencies
e063b26 Second test fix tentative
88e2593 This should fix the test replay
ebb8866 Added NISSAN replay test
b2dbb50 remove toyota ipas safety code and tests (#460)
a379faf White Panda's Wi-Fi setup instructions (#457)
11ef24b Improve tests (#456)
fb02390 Subaru checksum counter (#455)
9a44499 Fix Subaru Legacy Torque driver bug (#454)
dfa6b07 separating subary legacy safety mode from global (#452)
dad5858 Chrysler: add brakepress cancellation (#451)
db94a5b Added Nissan safety (#244)
d7f1195 Chrysler Checksum/counter (#450)
96e535e abstract crc function (#448)
1b49d3e Hyundai: add gas disengage and tests (#447)
598074c Volkswagen safety updates: Phase 2 (#445)
b2ffaae Chrysler: disengage on gas press  (#442)
2ebbe36 Subaru: disengage on gas press (#446)
ccf75c4 Volkswagen safety updates: Phase 1 (#444)

git-subtree-dir: panda
git-subtree-split: 0696730
pd0wm pushed a commit that referenced this pull request Mar 16, 2020
0696730 Toyota: add missing offset from speed signal (#469)
5b1a8dc Filtering LKAS HUD messages (#468)
99050f4 test_spam_can_buses was missing from Nissan
0f21b19 Cleanup pedal nomenclature (#467)
ceff91d Standardize brake safety tests (#465)
04809e1 Hyundai brake check (#464)
74c8ee0 Subaru brake check (#463)
4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks
c7d0d5f Volkswagen safety updates: Phase 3 (#462)
4368748 WIP: Toyota brake check.  (#459)
2ef996f fix addr frequencies
e063b26 Second test fix tentative
88e2593 This should fix the test replay
ebb8866 Added NISSAN replay test
b2dbb50 remove toyota ipas safety code and tests (#460)
a379faf White Panda's Wi-Fi setup instructions (#457)
11ef24b Improve tests (#456)
fb02390 Subaru checksum counter (#455)
9a44499 Fix Subaru Legacy Torque driver bug (#454)
dfa6b07 separating subary legacy safety mode from global (#452)
dad5858 Chrysler: add brakepress cancellation (#451)
db94a5b Added Nissan safety (#244)
d7f1195 Chrysler Checksum/counter (#450)
96e535e abstract crc function (#448)
1b49d3e Hyundai: add gas disengage and tests (#447)
598074c Volkswagen safety updates: Phase 2 (#445)
b2ffaae Chrysler: disengage on gas press  (#442)
2ebbe36 Subaru: disengage on gas press (#446)
ccf75c4 Volkswagen safety updates: Phase 1 (#444)

git-subtree-dir: panda
git-subtree-split: 0696730
pd0wm pushed a commit that referenced this pull request Mar 16, 2020
0696730 Toyota: add missing offset from speed signal (#469)
5b1a8dc Filtering LKAS HUD messages (#468)
99050f4 test_spam_can_buses was missing from Nissan
0f21b19 Cleanup pedal nomenclature (#467)
ceff91d Standardize brake safety tests (#465)
04809e1 Hyundai brake check (#464)
74c8ee0 Subaru brake check (#463)
4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks
c7d0d5f Volkswagen safety updates: Phase 3 (#462)
4368748 WIP: Toyota brake check.  (#459)
2ef996f fix addr frequencies
e063b26 Second test fix tentative
88e2593 This should fix the test replay
ebb8866 Added NISSAN replay test
b2dbb50 remove toyota ipas safety code and tests (#460)
a379faf White Panda's Wi-Fi setup instructions (#457)
11ef24b Improve tests (#456)
fb02390 Subaru checksum counter (#455)
9a44499 Fix Subaru Legacy Torque driver bug (#454)
dfa6b07 separating subary legacy safety mode from global (#452)
dad5858 Chrysler: add brakepress cancellation (#451)
db94a5b Added Nissan safety (#244)
d7f1195 Chrysler Checksum/counter (#450)
96e535e abstract crc function (#448)
1b49d3e Hyundai: add gas disengage and tests (#447)
598074c Volkswagen safety updates: Phase 2 (#445)
b2ffaae Chrysler: disengage on gas press  (#442)
2ebbe36 Subaru: disengage on gas press (#446)
ccf75c4 Volkswagen safety updates: Phase 1 (#444)

git-subtree-dir: panda
git-subtree-split: 0696730
Vaggysag pushed a commit to Vaggysag/openpilot that referenced this pull request Apr 21, 2020
* Checkpoint Panda refactoring updates

* Rename MQB safety tests in preparation for PQ

* Refactor MQB tests, add missing torque test

* Bring in MQB init without CRC LUT setup

* Fix to ACC_06 test case

* Fix to ACC_06 test case

* Tweak comment for clarity

* Drop superfluous return
github-actions bot pushed a commit to LexusRXopenpilotUG/openpilot that referenced this pull request Aug 12, 2021
* fix version

* fix
dzid26 added a commit to dzid26/openpilot-for-BMW-E8x-E9x that referenced this pull request Jan 2, 2022
d32345dd Removed prints that were used for test, but cannot be compiled for the target
ba74138 Added BMW safety tests. Updated safety to limit maximum commanded target delta. Fixed safety bugs with speed scaling and other type bugs.
d3cde431 Testing helpers
c4c8cce7 Added dummy state to gmlan testing
9a2e2d6c Reduced repeated code
e1aef2e1 Made compatible with d301a59
ed075850 Merge branch 'master' of https://github.com/commaai/panda
437d7ac2 BMW hooks. Number commaai#12 used for safety.
74c8ee0 Subaru brake check (commaai#463)
4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks
c7d0d5f Volkswagen safety updates: Phase 3 (commaai#462)
4368748 WIP: Toyota brake check.  (commaai#459)
2ef996f fix addr frequencies
e063b26 Second test fix tentative
88e2593 This should fix the test replay
ebb8866 Added NISSAN replay test
b2dbb50 remove toyota ipas safety code and tests (commaai#460)
a379faf White Panda's Wi-Fi setup instructions (commaai#457)
11ef24b Improve tests (commaai#456)
fb02390 Subaru checksum counter (commaai#455)
9a44499 Fix Subaru Legacy Torque driver bug (commaai#454)
dfa6b07 separating subary legacy safety mode from global (commaai#452)
dad5858 Chrysler: add brakepress cancellation (commaai#451)
db94a5b Added Nissan safety (commaai#244)
f88af30e Merge remote-tracking branch 'remotes/Comma/master'
d7f1195 Chrysler Checksum/counter (commaai#450)
96e535e abstract crc function (commaai#448)
1b49d3e Hyundai: add gas disengage and tests (commaai#447)
598074c Volkswagen safety updates: Phase 2 (commaai#445)
b2ffaae Chrysler: disengage on gas press  (commaai#442)
2ebbe36 Subaru: disengage on gas press (commaai#446)
ccf75c4 Volkswagen safety updates: Phase 1 (commaai#444)
d686a2ce Fixed GMLAN switch tickle interrupt

git-subtree-dir: panda
git-subtree-split: d32345ddcf9f70872b54886fc6c949c20dcc8650
dzid26 added a commit to dzid26/openpilot-for-BMW-E8x-E9x that referenced this pull request Feb 22, 2022
d32345dd Removed prints that were used for test, but cannot be compiled for the target
ba74138 Added BMW safety tests. Updated safety to limit maximum commanded target delta. Fixed safety bugs with speed scaling and other type bugs.
d3cde431 Testing helpers
c4c8cce7 Added dummy state to gmlan testing
9a2e2d6c Reduced repeated code
e1aef2e1 Made compatible with d301a59
ed075850 Merge branch 'master' of https://github.com/commaai/panda
437d7ac2 BMW hooks. Number commaai#12 used for safety.
74c8ee0 Subaru brake check (commaai#463)
4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks
c7d0d5f Volkswagen safety updates: Phase 3 (commaai#462)
4368748 WIP: Toyota brake check.  (commaai#459)
2ef996f fix addr frequencies
e063b26 Second test fix tentative
88e2593 This should fix the test replay
ebb8866 Added NISSAN replay test
b2dbb50 remove toyota ipas safety code and tests (commaai#460)
a379faf White Panda's Wi-Fi setup instructions (commaai#457)
11ef24b Improve tests (commaai#456)
fb02390 Subaru checksum counter (commaai#455)
9a44499 Fix Subaru Legacy Torque driver bug (commaai#454)
dfa6b07 separating subary legacy safety mode from global (commaai#452)
dad5858 Chrysler: add brakepress cancellation (commaai#451)
db94a5b Added Nissan safety (commaai#244)
f88af30e Merge remote-tracking branch 'remotes/Comma/master'
d7f1195 Chrysler Checksum/counter (commaai#450)
96e535e abstract crc function (commaai#448)
1b49d3e Hyundai: add gas disengage and tests (commaai#447)
598074c Volkswagen safety updates: Phase 2 (commaai#445)
b2ffaae Chrysler: disengage on gas press  (commaai#442)
2ebbe36 Subaru: disengage on gas press (commaai#446)
ccf75c4 Volkswagen safety updates: Phase 1 (commaai#444)
d686a2ce Fixed GMLAN switch tickle interrupt

git-subtree-dir: panda
git-subtree-split: d32345ddcf9f70872b54886fc6c949c20dcc8650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants