cabana: fix occasional ellipsis on y axis ticks #27142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfeiferj
pushed a commit
to pfeiferj/pfeifer-pilot-patches
that referenced
this pull request
Feb 7, 2023
* fix routes with dashcam override param * move to bottom Ford: set radarOffCan (commaai#27120) Fix process replay: add Ford Bronco Sport segment (commaai#27112) * Add Ford segment to process replay * fix dashcam cars * clean up * fix NotImplementedError * Update refs [RAM 1500 5TH GEN] Disable Live Torque (commaai#27121) * revert ram on live torque * update refs * update refs cabana: remove extra frame border in logs (commaai#27133) remove extra frame border cabana: DoubleValidator fix locale (commaai#27129) cabana: fix crash when combining graphs on MacOS (commaai#27128) bump panda (commaai#27136) * bump panda * bump add signs to glonass ksy Revert "add signs to glonass ksy" This reverts commit aa71947. cabana: fix overlap in byte highlighting (commaai#27139) cabana: replace space by underscore when editing signal name (commaai#27130) cabana: replace space by _ whene editing signal name cabana: fix occasional ellipsis on y axis ticks (commaai#27142) cabana: show dots when zoomed far into a signal (commaai#27145) * cabana: show dots when zoomed far into a signal * review comments cabana: only update the colors of newly fetched messages in historylog (commaai#27144) only update new msgs color Cabana: load commaai/opendbc from menu (commaai#27114) * load from opendbc * move load from commaai/opendbc to menu * keep margins cabana: small improvements to charts (commaai#27140) * cabana: small improvements to charts toolbar * show column count when wide enough * call setspacing * set in same place * remove call to updateToolBar() MacOS: build fixes (commaai#27143) * MacOS: exclude common/gpio.cc * MacOS: no spi for boardd * MacOS: loggerd: no v4l_encoder.cc * MacOS: update libdbc path for cabana cabana: refactor and improve signal view (commaai#26997) * refactor and improve signal view * cleanup undostack after save * set clean * fix logswidget::refresh * fix bugs in historylog * historylog:dont reset display_type on msg changed * inline displaySignals * historylog:add stretch to header * remove sizePolicy * always show toolbar * add icon to tabwidget * create new chart on top * fix 'show plot' btn state sync issue * rename removeSeries to removeItem * historylog::fix displayRange * MessageListModeL: improve setFilterString * set as current index after expanded * disable update during setmessage * ChartWidget: fix issue in updateState * skip align charts if there only one chart * fix updateLayout * cleanup historylog * updateState before end reset model * add validator * improve sigmodel * expand new signal * add comment * reserve vector * cleanup condition * single click on row to expand signal * improve layout for canfd(64 bytes) * cleanup * return false on default * show the latest signal value next to the signal name * update sig value after setmessage.to make the value updated in pause mode. * better size policy * +1 for grid size * better palette * set autofillbg cabana: fixed the column selector is always hidden if settings.chart_column_count is 1 (commaai#27146) fix column selector cabana: draw message bytes at the same width (commaai#27150) cabana: remove the margins of the legend item (commaai#27152) cabana: small improvements to MessageListModel::setFilterString (commaai#27153) cabana: restrict the rubber band in plot area. (commaai#27154) Ubloxd: glonass parsing tests (commaai#27125) * add glonass kaitai parsing * add kaita generated files * remove glonass from build * add string non immediate type * fix kaitai bug * cleanUp * add patch file * fix scons order * make lookup const * remove comments * rename * add to release files * remove printf * add signs * add glonass parsing test * finish up glonass kaitai tests * move cereal back to master * ignore test_runner * sign is not two complement * address comments --------- Co-authored-by: Kurt Nistelberger <kurt.nistelberger@gmail.com> Ubloxd: move gps parsing to function (commaai#27122) move ublox gps parsing to function Co-authored-by: Kurt Nistelberger <kurt.nistelberger@gmail.com> fix micd input device (commaai#27160) * try no device * unused * move sounddevice import cabana: add --dbc command line argument (commaai#27132) replay: fix hang if started with a special segment and there is no INIT_DATA in events (commaai#27107) * add events if allow or block is specified * add init_data Ford longitudinal control (commaai#27161) ford long Add Hyundai Ioniq 5 Fingerprint (commaai#27137) * added 2022 ioniq 5 fingerprint * removed extra eps field * fixed eps value * removed cornerradar * Apply suggestions from code review --------- Co-authored-by: Shane Smiskol <shane@smiskol.com> GM camera ACC: reliable relay open init (commaai#27163) Reliable relay open panda.cc: fix possible heap overflow on wrong checksum (commaai#27151) * panda.cc: fix possible heap overflow on wrong checksum * off by one VW MQB: Add FW for 2016 SEAT Leon (commaai#27168) VW MNB: Volkswagen Crafter Mk2 (commaai#26006) * VW MNB: Volkswagen Crafter Mk2 * Crafter has a min steer speed :( * add to non_tested_cars for now * autogratitude * Revert "autogratitude" This reverts commit 8f19085. * autogratitude * regen docs Ford CAN FD (commaai#27166) * add LateralMotionControl2 message * send LatCtl2 message on CAN FD cars Fix 2017 Genesis G80 car harness and shop link in docs (commaai#27127) * Fix 2017 Genesis G80 car harness * Revert "Fix 2017 Genesis G80 car harness" This reverts commit 2d5a92b. * split and make G80 2017 have J harness * generate and change min enable speed * adjust min steer speed --------- Co-authored-by: Shane Smiskol <shane@smiskol.com> Genesis G80 2017: group with Hyundai Genesis (commaai#27170) * Revert "Fix 2017 Genesis G80 car harness and shop link in docs (commaai#27127)" This reverts commit cf94394. * The HGenesis became rebranded to G80 in 2017 (2018 model year). G80 2017 fingerprints as Hyundai Genesis, and we handle the min steer speed correctly https://en.wikipedia.org/wiki/Genesis_G80 https://en.wikipedia.org/wiki/Hyundai_Genesis * fix cabana: dynamically switch between OpenGL (commaai#27167) * cabana: dynamically switch between OpenGL * put back todo * only switch when x axis changes cabana: render light or dark icon based on system theme (commaai#27155) Toyota: make LKAS message 5hz (commaai#26830) * Toyota: make LKAS message 5hz * update refs --------- Co-authored-by: Shane Smiskol <shane@smiskol.com> Toyota: add FW engine for Brazilian Corolla Hybrid (commaai#26943) * Add miss FW engine for Toyota Corolla Hybrid Test route ` 4f50e44908cc46b8|2023-01-12--21-08-57 ` * braziliam toyota corolla hybrid 2023 is US affected by TSK? * add a new entry for south america * Revert "add a new entry for south america" This reverts commit 28454c0. * CARS.md is autogenerated! * delete CARS.md to fix merge conflict * space * i don't know if we know for sure not all international 2023's have TSK --------- Co-authored-by: Shane Smiskol <shane@smiskol.com> Hyundai: add FW for Genesis and Genesis G80 (commaai#27171) * add FW for Genesis and G80 * move to top GM camera ACC: reliable relay closing (commaai#27164) * Reliable relay open * Reliable relay close * ign in a loop * fixes * we need this * log * comment to remind me tmrw * ign fix * this makes it 2x more reliable, but messyyy * Revert "this makes it 2x more reliable, but messyyy" This reverts commit 03401dc. * revert non-related stuff * comments, spaces * a stands for indefinite article * not applicable for non-camera acc * something... * Revert "something..." This reverts commit de8a158. * Update ref_commit paramsd: Check if roll from the localizer is actually valid (commaai#27105) * add roll_valid check, use localizer roll when it is valid * increase std to 1.5 * btter check * avoid numpy * update refs * update refs Hyundai: remove HYUNDAI_GENESIS from legacy steer max blacklist (commaai#27176) Hyundai: Enable radar tracks for Santa Fe 2019 (commaai#27175) Multilang: add missing Thai translations (commaai#27148) * Multilang: add missing Thai translations * Multilang: update Thai translations * Multilang: add missing Thai translations Ubloxd: gps add iodc check (commaai#27162) * gps add iodc check * add test * simplify * update ref --------- Co-authored-by: Kurt Nistelberger <kurt.nistelberger@gmail.com> Support for Kia Niro PHEV 2020 (commaai#27158) * Update values.py * Update values.py Added support for Kia Niro PHEV 2020 * Update values.py Added support for Kia Niro PHEV 2020 * Update values.py Changed the fingerprint to be 4 seperate IDs * Apply suggestions from code review * generate * gen docs --------- Co-authored-by: Shane Smiskol <shane@smiskol.com> fix pigeond device reset get_present_ecus: check available pandas (commaai#27181) * add num_pandas to get_present_ecus * always bugged me * move this to function signature boardd: enable fingerprinting with both multiplexed modes (commaai#27159) Co-authored-by: Shane Smiskol <shane@smiskol.com> boardd: update loopback test with new param cabana: show series colors in tooltip (commaai#27186) show series colors in tooltip updated: fix brief notification of update for same version (commaai#27182) rename carState.radarOffCan to radarUnavailable (commaai#27187) * rename carState.radarOffCan to radarUnavailable * bump cereal Ford: restore radar DBC, check radarUnavailable (commaai#27188) Bump total scons nodes cabana: remove the hardcoded width for columns (commaai#27185) cabana: improve line marker (commaai#27189) cabana: do not round time when seeking from chartswidget (commaai#27141) * cabana: do not round time when seeking from chartswidget * prevent zooming/seeking past end of route cabana: add button to suppress highlighted bytes (commaai#27131) cabana: add capability for switching between line and scatter plots (commaai#27169) * add capability for switching between line and scatter plots * Update tools/cabana/chartswidget.cc Co-authored-by: Willem Melching <willem.melching@gmail.com> * setUserOpengl in createSeries * update series title * set marker size by pixels_per_point * sync menu state * cleanup * set default series type in settings dlg * remove qdebug --------- Co-authored-by: Willem Melching <willem.melching@gmail.com> Chrysler: disable radar parsing (commaai#27190) * Chrysler: disable radar parsing * update refs ui: tap experimental mode icon to toggle (commaai#27064) * ui: tap experimental mode icon to toggle After experimental mode has been enabled for the first time (confirmed), it can be toggled by tapping the engage-ability/experimental mode icon in the upper right. Closes commaai#27002 * replace with QPushButton * fixes * cleanup loggerd: rotate if segment length is >20% longer than expected (commaai#27193) * loggerd: rotate if segment length is >20% expected * add that back * comment --------- Co-authored-by: Comma Device <device@comma.ai> controlsd: don't show steer saturated if recently overriding (commaai#27191) * controlsd: don't show steer saturated if recently overriding * 2s * update refs Glonass support, ubloxd add ephemeris parsing (commaai#27119) * add glonass kaitai parsing * add kaita generated files * remove glonass from build * add string non immediate type * fix kaitai bug * cleanUp * add patch file * fix scons order * make lookup const * remove comments * rename * add to release files * add signs * final ublox parsing * bump cereal * update ref --------- Co-authored-by: Kurt Nistelberger <kurt.nistelberger@gmail.com> glonass support laikad (commaai#27173) * add glonass kaitai parsing * add kaita generated files * remove glonass from build * add string non immediate type * fix kaitai bug * cleanUp * add patch file * fix scons order * make lookup const * remove comments * add to release files * init * add laika * remove printf * laikad add glonass ephem parsing * add signs * final ublox parsing * rev gps * bump subs * address comments * disable internet for laikad --------- Co-authored-by: Kurt Nistelberger <kurt.nistelberger@gmail.com> cabana: syc the last messages after seeking (commaai#27149) * fix wrong last message time * update last messages after seekto * cleanup * remove src,address from CanData * merge master merge master Ford: add Lincoln Aviator 2021 to Ford Explorer platform (commaai#27095) * add Lincoln Aviator 2021 to Ford Explorer platform Based on the Ford Explorer, the Aviator has very similar firmware versions. Add these to the Explorer platform and create a new CarInfo for the Aviator. f0709d2bc6ca451f|2022-12-10--12-36-59--0 VIN: 5LM5J7XC8MGL09541 * Ford: new gear shifter signal to support Aviator * probably don't need these * don't need to pass None here, it defaults to None * will rename in DBC * bump opendbc * bump process replay ref HKG: Car Port for Kia K5 Hybrid 2020 (commaai#26947) * HKG: Car Port for Kia K5 Hybrid 2020 * Add test route (Experimental Mode) * No abs * remove extra trans * move up --------- Co-authored-by: Shane Smiskol <shane@smiskol.com> Hyundai: Add FW Versions for 2020 Ioniq Plug-in Hybrid (commaai#27196) * Hyundai: Add FW Versions for 2020 Ioniq Plug-in Hybrid * Aha! * Another one * Update selfdrive/car/hyundai/values.py * missing a radar --------- Co-authored-by: Shane Smiskol <shane@smiskol.com> Add support for Malaysian Civic 2022 (commaai#27126) Co-authored-by: Shane Smiskol <shane@smiskol.com> 2020 Hyundai Santa Fe fingerprint update (commaai#27135) * add new transmission fwVersion for 2020 hyundai santa fe * use shorter trans, add missing fw * duplicate --------- Co-authored-by: Shane Smiskol <shane@smiskol.com> Added new fingerprint for Toyota Corolla Cross GR Sport (commaai#26693) Co-authored-by: Shane Smiskol <shane@smiskol.com> cabana: elide long signal names (commaai#27202) elide long signal names cabana: fix chart buttons occasionally did not respond to click. (commaai#27198) * fix btn not responding on click * change icon from gear to list(menu) Hyundai: update Hyundai Genesis tuning (commaai#27197) cabana: add dialog to open route from remote or local (commaai#27183) * add OpenRouteDialog * cleanup * failed_to_load * fix load * clear message list and stream after open new route * show message * remove all tabs and charts after open * use textEdited * check route format * cleanup loadRoute cabana: fix incorrect point size after adding new series to chart or changing series type (commaai#27199) * update pointers after create series * cleanup laikad: add laikad startup tests (commaai#27207) * add laikad startup test * move debug files to xx * add laikad startup and ephemeris test --------- Co-authored-by: Kurt Nistelberger <kurt.nistelberger@gmail.com> navd: check duration_typical before using (commaai#27184) check duration_typical Co-authored-by: Kurt Nistelberger <kurt.nistelberger@gmail.com> docs: Add cabana to tools (commaai#27208) cabana: better window title for live streaming (commaai#27214) better title for live streaming Add missing HIGHLANDER_TSS2 engine f/w (commaai#27220) @Arnold Jagt#4866 2023 Highlander LE (ICE) DongleID/route b75bae9b9bde6210|2023-02-04--17-44-15 Add sveral missing LEXUS_ESH_TSS2 firmwares (commaai#27219) * Add sveral missing LEXUS_ESH_TSS2 firmwares @salmankalicommaai#7352 2023 Lexus ES 300h DongleID/route c010a8cd3af884f5|2023-02-04--03-27-12 * docs.py gen'd CARS.md w/ 2023 Lexus ES Hybrid update Add missing AVALONH_TSS2 fwdRadar f/w (commaai#27215) `@shankapotamous#6637` 2022 Avalon Hybrid DongleID/route 301800decccd6669|2023-02-04--10-09-55 cabana: delay starting live streaming thread (commaai#27213) cabana: improve align charts (commaai#27217) * improve align charts * set range on need * cleanup * remove unused include cabana: only relayout charts when needed (commaai#27210) cabana: fix incorrect clamp (commaai#27218) * fix incorrect clamp * fix type error docs: update cabana usage in README (commaai#27225) * Add ecam * Update README.md --------- Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com> setup pre-built master-ci (commaai#27205) * try this * add as release branch * set the name * build on master-ci cabana: concurrently update chart series (commaai#27230) cabana: click on legend to show/hide series (commaai#27231) * click on legend to show/hide series * update axis y * add move icon settings: highlight nightly in branch switcher (commaai#27227) setup: fix button label on ethernet (commaai#27235) * setup: continue without wi-fi on ethernet * switch around cabana: fixed wrong plot area after changed column count (commaai#27228) installer: do not translate git progress strings (commaai#27238)
twilsonco
pushed a commit
to twilsonco/openpilot
that referenced
this pull request
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes there would be ellipsis shown on the y axis ticks. Forcing the label format to 1 digit, and also using
applyNiceNumbersfor constant signals fixes this.Before:
After:
