Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format files using rustfmt #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rolv-Apneseth
Copy link

Split from #16

I guess I'll do these sequentially? They'll all be conflicting otherwise. If you don't want this format one let me know and I'll move on to the clippy warnings.

@fenhl
Copy link
Collaborator

fenhl commented Nov 15, 2023

I'm going to need some time to review this. My first impression is that a lot of the changes are making things harder to read, for example the inconsistency introduced in the asserts, and the extra braces around match arm bodies. I'll have to do some research on why rustfmt does these things.

@Rolv-Apneseth
Copy link
Author

Sure thing, take your time. Maybe for more consistent asserts I could increase the line length to something that keeps them all on one line. Personally I think the changes make it more readable but of course that's just personal preference and this is not my project so I have no issue skipping this formatting step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants