Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to decide if this is even necessary but these are the changes in this small PR:
rustfmt
clippy
warningsI suppose the main thing is the tests going into modules, as that cleans up the test specific imports and puts all tests behind a
#[cfg(test)]
attribute which should keep all those test functions from needing to be included in the final compilation even when not testing. This seemed to lead to saving an admittedly tiny 2k (48k to 46k) from thelibshlex.rlib
withcargo build --lib --release
on my machine.