Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address format localizations #29

Closed
agitator opened this issue Nov 14, 2016 · 3 comments
Closed

address format localizations #29

agitator opened this issue Nov 14, 2016 · 3 comments
Labels

Comments

@agitator
Copy link
Member

agitator commented Nov 14, 2016

the standard address format (french) is
10 Streetname

in german the address would be
Streetname 10

how could this be implemented (besides overriding views)?

@agitator
Copy link
Member Author

it would also be nice to be able to change the order within edit

@cedricmessiant
Copy link
Contributor

Maybe we should implement something like get_street_address in Address view and check the localization there to determine the order for number and street.
I don't really know if address format differ more largely (city, zip code, etc) according to languages or if it is limited to street/number order.

@vincentfretin
Copy link
Member

Not tested, but I think you can just change in browser/templates/address.pt:

    <div class="street-address" class="address_line street-address" i18n:translate="address_line">
        <span i18n:name="number" tal:replace="address/number"></span>
        <span i18n:name="street" tal:replace="address/street"></span>
</div>

and translate in German address_line msgid to "${street} ${number}"
If you can do a PR, I'll merge it.

frisi added a commit that referenced this issue Jan 13, 2017
as this is more common in most countries (see discussion in #36).
refs #29
vincentfretin added a commit that referenced this issue Jan 17, 2017
agitator pushed a commit that referenced this issue Feb 7, 2017
agitator pushed a commit that referenced this issue Feb 7, 2017
as this is more common in most countries (see discussion in #36).
refs #29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants