Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address format in vcard - still shown in "french" #52

Open
agitator opened this issue Jul 23, 2018 · 4 comments
Open

address format in vcard - still shown in "french" #52

agitator opened this issue Jul 23, 2018 · 4 comments
Labels

Comments

@agitator
Copy link
Member

We had the discussion about localization of the address format #29

The vcard still puts the number before the street.

I suppose the code to generate the vcard is in https://github.com/collective/collective.contact.core/blob/master/src/collective/contact/core/adapters.py#L55 but it's not clear to me how the number still is before the street.

@tdesvenain @frisi Any ideas?

@agitator
Copy link
Member Author

@vincentfretin
Copy link
Member

Can you please show us what is produced and what do you expect?
You should probably look at the vcard package to know how it is rendered, I don't know myself.

@agitator
Copy link
Member Author

screen shot 2018-07-24 at 11 04 01

The contents of the vcard look like this:

BEGIN:VCARD
VERSION:3.0
ADR:10;PO Box;My Street;City;;8000;Country
FN:Mr. Firstname Lastname
N:Mr. Firstname Lastname;;;;
END:VCARD

and produces following address book entry

screen shot 2018-07-24 at 10 57 16

I'm not too familiar with the vcard format, would like to see something like this

screen shot 2018-07-24 at 10 58 19

I think I would have to override the adapter, but how is this particular order produced?

@agitator
Copy link
Member Author

I patched it, since grok makes it impossible to override the adapter in a sane way...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants